Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <000000000000eb49a905f061ada5@google.com> <0000000000000ca36b05fc780953@google.com>
In-Reply-To: <0000000000000ca36b05fc780953@google.com>
From:   Aleksandr Nogikh <nogikh@google.com>
Date:   Thu, 25 May 2023 12:01:10 +0200
Message-ID: <CANp29Y68oXAQZBAChyiB58qebXS5bNOGda6tG=B+kKa7QRh6EQ@mail.gmail.com>
Subject: Re: [syzbot] [ntfs3?] WARNING in do_symlinkat
To:     syzbot <syzbot+e78eab0c1cf4649256ed@syzkaller.appspotmail.com>
Cc:     almaz.alexandrovich@paragon-software.com,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        ntfs3@lists.linux.dev, syzkaller-bugs@googlegroups.com,
        viro@zeniv.linux.org.uk
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, May 25, 2023 at 12:29=E2=80=AFAM syzbot
<syzbot+e78eab0c1cf4649256ed@syzkaller.appspotmail.com> wrote:
>
> syzbot suspects this issue was fixed by commit:
>
> commit 267a36ba30a7425ad59d20e7e7e33bbdcc9cfb0a
> Author: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
> Date:   Mon Jan 16 08:52:10 2023 +0000
>
>     fs/ntfs3: Remove noacsrules
>
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=3D15fdf76128=
0000
> start commit:   ec35307e18ba Merge tag 'drm-fixes-2023-02-17' of git://an=
o..
> git tree:       upstream
> kernel config:  https://syzkaller.appspot.com/x/.config?x=3D5f0b8e3df6f76=
ec
> dashboard link: https://syzkaller.appspot.com/bug?extid=3De78eab0c1cf4649=
256ed
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=3D12570890c80=
000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=3D14523acf48000=
0
>
> If the result looks correct, please mark the issue as fixed by replying w=
ith:
>
> #syz fix: fs/ntfs3: Remove noacsrules

This commit definitely removes one of the options used by the
reproducer, though at least from the stack trace it's not clear
whether the problem was in noacsrules or we're just now not mounting
the image because of invalid mount options.

Anyway, let's close the bug, it will reappear on syzbot if it's not fixed.

#syz fix: fs/ntfs3: Remove noacsrules

>
> For information about bisection process see: https://goo.gl/tpsmEJ#bisect=
ion
>