Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 May 2023 11:31:24 +0100
From:   Lee Jones <lee@kernel.org>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: intel-lpss: hide suspend/resume functions in #ifdef
Message-ID: <20230525103124.GC9691@google.com>
References: <20230516202746.561111-1-arnd@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230516202746.561111-1-arnd@kernel.org>
Precedence: bulk

On Tue, 16 May 2023, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> When CONFIG_PM is disabled, the prototypes for these two functions
> are not visible:
> 
> drivers/mfd/intel-lpss.c:482:5: error: no previous prototype for 'intel_lpss_suspend' [-Werror=missing-prototypes]
>   482 | int intel_lpss_suspend(struct device *dev)
>       |     ^~~~~~~~~~~~~~~~~~
> drivers/mfd/intel-lpss.c:503:5: error: no previous prototype for 'intel_lpss_resume' [-Werror=missing-prototypes]
>   503 | int intel_lpss_resume(struct device *dev)
> 
> Add the same #ifdef around the definition of the unused functions,
> which avoids the warning and slightly reduces the code size.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/mfd/intel-lpss.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks

-- 
Lee Jones [李琼斯]