Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 May 2023 11:33:28 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Geert Uytterhoeven <geert+renesas@glider.be>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Osama Muhammad <osmtendev@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] regulator: core: Fix more error checking for
 debugfs_create_dir()
Message-ID: <22d1dd88-6bf4-444a-8ea1-61ef627ca7a0@sirena.org.uk>
References: <cover.1684930647.git.geert+renesas@glider.be>
 <f8e4716278b0a6fe7d9e5537715eb21dcd991d1d.1684930647.git.geert+renesas@glider.be>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="1Ew73XuzqX1/lYTh"
Content-Disposition: inline
In-Reply-To: <f8e4716278b0a6fe7d9e5537715eb21dcd991d1d.1684930647.git.geert+renesas@glider.be>
Precedence: bulk


--1Ew73XuzqX1/lYTh
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 24, 2023 at 02:22:17PM +0200, Geert Uytterhoeven wrote:
> In case of failure, debugfs_create_dir() does not return NULL, but an
> error pointer.  Most incorrect error checks were fixed, but the one in
> create_regulator() was forgotten.

This breaks the build:

/build/stage/linux/drivers/regulator/core.c:1916:11: error: expected identi=
fier=20
or =E2=80=98(=E2=80=99 before =E2=80=98else=E2=80=99
 1916 |         } else {
      |           ^~~~
/build/stage/linux/drivers/regulator/core.c:1933:9: error: expected identif=
ier o
r =E2=80=98(=E2=80=99 before =E2=80=98if=E2=80=99
 1933 |         if (!regulator_ops_is_valid(rdev, REGULATOR_CHANGE_STATUS) =
&&
      |         ^~
/build/stage/linux/drivers/regulator/core.c:1937:9: error: expected identif=
ier o
r =E2=80=98(=E2=80=99 before =E2=80=98return=E2=80=99
 1937 |         return regulator;
      |         ^~~~~~
/build/stage/linux/drivers/regulator/core.c:1938:1: error: expected identif=
ier or =E2=80=98(=E2=80=99 before =E2=80=98}=E2=80=99 token
 1938 | }
      | ^

--1Ew73XuzqX1/lYTh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRvOXcACgkQJNaLcl1U
h9BgKgf+IxF8wNfDs3nf1qMktu3v4cIvlrN/cvCtFlQohBYLfBxs2I9E3qcORK0c
KvBo194IcIal+LDov9i6/CMMjkmvmR4VgtD3TplTb18NKBBgtYr6vi4LTVvmiqVZ
tWp6KtaAtEazfLIlr4ysGIBK69KTzdD4ghJAFmaaIvjfVuQ7E9CrR/Elu59Ru487
78+pURiWPCajru5USKgj1ve3gvITJ1q+I2xECqXHLgiLP/CkqXQ1RxF8RfnxNpzx
yOMmyLfzaMvRsYbTM1yZ1madTjdo1f4WfVhk3i3tS1n8aQ3xIRXWo3z8ecYPcAyV
MgIjjUXtZWCI2ItOEI0Oy2wkl2SQXA==
=gwy9
-----END PGP SIGNATURE-----

--1Ew73XuzqX1/lYTh--