Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8302be1b-416a-de32-c43b-73bd378f8122@intel.com>
Date:   Thu, 25 May 2023 13:08:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH net-next 08/11] iavf: switch to Page Pool
Content-Language: en-US
To:     David Christensen <drc@linux.vnet.ibm.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Michal Kubiak <michal.kubiak@intel.com>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        "Jesper Dangaard Brouer" <hawk@kernel.org>,
        Ilias Apalodimas <ilias.apalodimas@linaro.org>,
        Christoph Hellwig <hch@lst.de>, <netdev@vger.kernel.org>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>
References: <20230516161841.37138-1-aleksander.lobakin@intel.com>
 <20230516161841.37138-9-aleksander.lobakin@intel.com>
 <4c6723df-5d40-2504-fcdc-dfdc2047f92c@linux.vnet.ibm.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <4c6723df-5d40-2504-fcdc-dfdc2047f92c@linux.vnet.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnlyRE9McUhUN2Z0VHowUHFxdEpmOWdTWjJraFVPYW00Qzk3TGZlOHlBdEJQ?=
 =?utf-8?B?UFp5OHB0WEhaNVY4cDd2K0VuMDc3OFl2cldvdTE3ei9LMEloczJFKzhvOWY5?=
 =?utf-8?B?ZVBLQXNVVktoaUJaK0drVXdBU2QyL2NFMFRrME52SWkya0ovUXBiWEdhQkJa?=
 =?utf-8?B?RkhLcTJ1NmFIcnRoZVAybWZmZjZWMjZydG4vcXZGV1lVR2h2cTJkUTd0dCtB?=
 =?utf-8?B?cElwdEkrY1NJM3dLRUFrN1pyQ2NKKzdlUTcvMXVHNGhpdHBjd0RLY1FRNjJM?=
 =?utf-8?B?Vk9yY2R1bnFmdldMZXNoRnorYmhKS2Y5b2h1d2hheVFPMFZnUTBXazdOdmVW?=
 =?utf-8?B?V0M3eExCeTVyMVp4aWFrTEdIOHVLcU5VK1dZVmhRNjREODRmRjdFQklvNFl3?=
 =?utf-8?B?SUZwdGhoeTFEVkZ2Y0xhdnVxUUt4VUUwSFU5ZnVLUS8xNzJoRGVWdUVqMGEx?=
 =?utf-8?B?c250VkxJL3V2NHk4YUYrRzFQLzhrSXpPRWxvVSs0bUxQd0JpYUd3b0ZwczQ4?=
 =?utf-8?B?eGJzaTJnOHlQTmJ3QUhybEdBd0lndlpERlZjOGJRS2dzanIxeVVKZVZxTUlS?=
 =?utf-8?B?YzA2MTluSCtkSHd1WElMdVU0OG0yaklZeWRsK1FVTko0UmR4MGlPdER3eHdy?=
 =?utf-8?B?SkZZdlV4bTVFeVVEOTM4WmgwbFJnRHE4UW9kOEs1ZlI1djdVSmhqU001KzE5?=
 =?utf-8?B?MFhBQ09ocWt6aGRqZEoyVFUybW91S3VteGxmZ1ZDbDg5aHpZNE81ekRURi8x?=
 =?utf-8?B?ODdLOWZTSHFPZGRnaEI1dVFhOUI1Ri82QzZxaGoyVEFjS3hGQzVDUFUrS1BL?=
 =?utf-8?B?OVVSSGFpWW9LYkd6cnpoSVpqdkFhbXdtMzdkU3RmT3YwZGxjdXBxOElJTlMv?=
 =?utf-8?B?SnF2RkNsOU5MMHZKZVVhNmtnVnlIa0JjQ0VFVW1xYUN3MWFCbm9rRDlmZmYw?=
 =?utf-8?B?TjczT0pPMWRqQWc0YnZadzUxc2QrSHVLdlNQd2RPUGNrZ1lWcVd1WXFoS2d2?=
 =?utf-8?B?VUl0YktMK09ZZnBneWV5Skh3aXgvWEk4MXBrR3BsU2Y3dmtlU0tGaUZCYXll?=
 =?utf-8?B?djFOZnR6QXBTZDM1aGZ1RnRwK1VVZ3Q3MzBqSVJNMHo2VlYwSXJXdmZUWXFz?=
 =?utf-8?B?b3FNYkRGd05Vekk1ODBHWThvUURGcnFMeGhzay96cnJnNDhRR1ZQRHN1U2tK?=
 =?utf-8?B?RHNMWnpQNm1rOFA5VExFb0NlTlNjTWtuTDM5d1BmOGJGMHdVdUI5dDhvVHRH?=
 =?utf-8?B?YnpzZW1BaUF5Tm9EWlBYTXdyYjIwWU5Mb1dKaGFvUG5YT0dENlUvY1Q5ZUNh?=
 =?utf-8?B?a1V3WU1hODRLQjJmZEJwQTlCUWE5a0pDQlJ3V21BSTJMSm9VUUo5Ylhzckcy?=
 =?utf-8?B?VFNCemhYSXUzTkRBTENTcXZiM1lzYmRlc2VyWS9KSXZ1TVRGRHBGSnd2enA1?=
 =?utf-8?B?eEFpMyt4WVV1MnhVTmx0UFQrZnhyeGlyWkgvUkFnNXFuVXRuc3ZqTGVyMGQ0?=
 =?utf-8?B?Vmk0VmZPa1FDcllLaitvcnpON2dNSENGTm1pbHluVHNuVzQ4TDZsVTZ3ZE1O?=
 =?utf-8?B?eUZzdjBKL0pjbmhXblJENUtsVWVLR0xhaS81Rk53bkRiUTgzTHlZZW8wQytE?=
 =?utf-8?B?T29RUDBPMVBkTnhqK0FHMSttcTZqS2ZqWU4wVkk5ckRpTGRrT0N4T25GRm1M?=
 =?utf-8?B?NHU2RkkvanY2eUh1ZC9KN0ppRXU0U0kyZmlzck56bm9tbzhHaXU2dkdIblZL?=
 =?utf-8?B?dXZnTXJnUHRobU04c0tJbno4RDJvNVFDMmtDdENnYTU3NHhCY1dxUUZVZWVF?=
 =?utf-8?B?UDhxTm56QWxoMU1BdUFIUEhsKzMwQUlDbytMNWdic1FyZmNHa2tLSFJkRVN6?=
 =?utf-8?B?eVlqOG0vY1lXU3N6Wk9UMjBjU0JaWnk0WGR1NjVYcHdhWFlaME9aMzJDYnJi?=
 =?utf-8?B?VDRuRHd0SUJ2RGpmSU91cHlUWGNMUWpMNXZwbWE0T1VmNGFjZTFnZ1F2VGxR?=
 =?utf-8?B?UmRwbjF4cWV2U3N6VDIwSGIvbzYyQVlrRytkZWVYaVhGb20xS0tvK0h1MVlC?=
 =?utf-8?B?MitkVitGTlFVTHowWUM1UlNudGtzOHJtbGJ2cEE5cXR2ajkvRVRubGdMZU5r?=
 =?utf-8?B?eHcrVHFJa0xZQUJzTy85NDZycys3NzRXc1MzVXZpWjMxZW5MWlgwU0ZlejM0?=
 =?utf-8?B?aXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 39622f31-4c32-47c2-3f22-08db5d106046
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2023 11:08:32.3230
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U2ze96b4ZP0XEGHlYgbiM8MTU5siOA9f3rci/OiUrUohILZRQEXWbq+BpgRHL/agrCt3UjJyPk7bB42zQJ5SOZv4uE+9i8/EnEi1xgFXvf8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7317
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: David Christensen <drc@linux.vnet.ibm.com>
Date: Tue, 23 May 2023 15:42:28 -0700

> 
> 
> On 5/16/23 9:18 AM, Alexander Lobakin wrote:
>> Now that the IAVF driver simply uses dev_alloc_page() + free_page() with
>> no custom recycling logics and one whole page per frame, it can easily
>> be switched to using Page Pool API instead.
> 
> Any plans to add page pool fragmentation support (i.e.
> PP_FLAG_PAGE_FRAG) in the future to better support architectures with
> larger page sizes such as 64KB on ppc64le?

Currently no, we resigned from page fragmentation due to the complexity
and restrictions it provides for no benefits on x86_64. But I remember
that pages > 4 Kb exist (I have a couple MIPS boards where I have fun
sometimes and page size is set to 16 Kb there. But still always use 1
page per frame).
By "better support" you mean reducing memory usage or something else?

> 
> Dave

Thanks,
Olek