Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 May 2023 13:02:39 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc:     Mark Brown <broonie@kernel.org>, davem@davemloft.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        alexis.lothore@bootlin.com, thomas.petazzoni@bootlin.com,
        Andrew Lunn <andrew@lunn.ch>, Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>
Subject: Re: [PATCH net-next v2 1/4] net: mdio: Introduce a regmap-based mdio
 driver
Message-ID: <ZG9AT4EeCmoyN5N2@corigine.com>
References: <20230525101126.370108-1-maxime.chevallier@bootlin.com>
 <20230525101126.370108-2-maxime.chevallier@bootlin.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230525101126.370108-2-maxime.chevallier@bootlin.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7k0U+NOcAmt7eWaNziT5OtAFz6pChoFHzGjBQQuLQphHyXpO1L7MDLgf0sma?=
 =?us-ascii?Q?ogZL4Blr0jEKvcUzqvAweFw1TV/xtitVBDulRmHB6JEpC4O+YgebHpkEbSW8?=
 =?us-ascii?Q?+9LMd6TEenRvn13t5QO91LSDX1nj4lTzKXVkRcGcxyhmSLa25Oe9XtjvXJRW?=
 =?us-ascii?Q?fHJj8aiGO18OqKUJ5j9n3YjatDYKLcVGVgbEhnGXIzIpuuBtwWVeY58fYzak?=
 =?us-ascii?Q?QxLJJLjTmeEi2gm+FMgxXgiFuioT6E64atnHwMlxhxijkki0PV/DXqBcKVl8?=
 =?us-ascii?Q?L9cNYDl+IUe5WZrrCv73hhcDLqiKWGZ1cL/U/TyO8z+MnS6qn3/1BvSLl2NV?=
 =?us-ascii?Q?5JiJ45FYIx7KyVrmFggcYGW4gXBaZNtLvgcyuU3dNtl9ulX6QFWulCOc7u7C?=
 =?us-ascii?Q?ye1tXCKQZh6l4QzyteQ+rqWgrtg+g0UoaWTL6jRT9nd60NqyW6aotaG0j+0s?=
 =?us-ascii?Q?Mm0gzSlDXPD1FBRl1OHJpoVgAGGrInsoisTU8Eu54oeharCzfH40jjRBI6rl?=
 =?us-ascii?Q?L6gFqBSNLq2gq4El3HUyFP6xen+zJNqLT9kXrmhGB9MYOzkP04E0RkBL3SbO?=
 =?us-ascii?Q?AwAdTY9ANfOQF7axrPCyA4V/Y4mnNz7RpzgLdMwrUnTTyDwaHOEaOO/ZH3kN?=
 =?us-ascii?Q?7z6TaofbMWcj7SoF00RpKSv/epTkAxIfcyTJR0s+/rxv7RhNvXwV92TeZCsW?=
 =?us-ascii?Q?EjrfLmprnTWIkJtdJExyKWNnmfR0BI6YsFnAwcHrBq4thss/U//MIUpF1Rn4?=
 =?us-ascii?Q?QAhrfkb42j3zEcPzca5t+0QsnxTgWzpBQRCompkdEFrzEUPCzIOGm5iSx0g7?=
 =?us-ascii?Q?Hos6hTVu0IAYGfVx7OgvTMrfpyO+1aC7nPg2iHO5mgGzXZmtM94VNwlBH7eR?=
 =?us-ascii?Q?yYYvezuVmi4PjFTP/1MMcRToiJPu74TlXcD3gclZUay0l9Yx5I3jTI/jphA/?=
 =?us-ascii?Q?V6K4dNnVB5pgUm1v/LgpDDm3AInu+uKWVwFht4LmZgIYoXSa++C4OibdKeTE?=
 =?us-ascii?Q?QhrBXIxifaLgULk0nt69tTcA2RM3cJzQQfE6a3um7TT+rb7bUR+ypy+CM4tB?=
 =?us-ascii?Q?LRqNA3EV2Indn0LTrRr9f9gnCgGb3Oy/xuqDZFtqrKgoC+CODyrKfX8xNfs7?=
 =?us-ascii?Q?6EbU3asXtj75yVlm9Ze+Rl/ujEtc8Z2rbWg5bChCm7iblHEbVYxEaEUwFC+r?=
 =?us-ascii?Q?um6lYsXwY+aDPq8ww/y4khtp/eqtdEVunD6kVo27HIDiM8FRmh0/M9jjaP8e?=
 =?us-ascii?Q?8foSycTrdLo3Jg6S1jhgQ8lx3EXZQyApJze+tRbYzVGtdAgyPKt0IQcqNqTd?=
 =?us-ascii?Q?lrFAnBPRm7xW+AIhPjxgsB1y1egarxofHNlUPfBoLod0rxJl9ZbdmGh7Jfqh?=
 =?us-ascii?Q?VCp8tVfWDiMkWDvwB9j1P+hr7Vf5YJv7FrYGPRXP93LY/eyCT/VgfN+tEqRs?=
 =?us-ascii?Q?8yfFNj2B47dpvIvvYnmlWAThcLrUVx1AA446KkpE5UZt5LPu5OG2eD8fZUmX?=
 =?us-ascii?Q?6J9+RtSgkvA5TYRmSgOj5wNKgMFWBbnZemLxj4bBeqd/GvwJ5hKt5WqbuOMx?=
 =?us-ascii?Q?cVbkfk+hZCRUTm+xg+pH7mRivtIyhrkprG7PZ9222IRLiO3N5ZIoro4NIcxx?=
 =?us-ascii?Q?FaIV35uSvZ/4CcX1kU27Sa9JRZ66lu9xOirtSvfCbEwOxPqYtjBb89n1HCy8?=
 =?us-ascii?Q?hMc+dw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc028bfa-0873-4937-b56d-08db5d0f93c0
X-MS-Exchange-CrossTenant-AuthSource: BY3PR13MB4834.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2023 11:02:49.1663
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CjRYaZypxr5c9JSYFkBYPdcwErarxYROuBit13nunTVOBrlPRoKrQrxcThTyTjn5/BueMLEJeqMWvWYg6Ic4NFVY2F68bj89Fb/n4G7iBmE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR13MB5676
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 25, 2023 at 12:11:23PM +0200, Maxime Chevallier wrote:
> There exists several examples today of devices that embed an ethernet
> PHY or PCS directly inside an SoC. In this situation, either the device
> is controlled through a vendor-specific register set, or sometimes
> exposes the standard 802.3 registers that are typically accessed over
> MDIO.
> 
> As phylib and phylink are designed to use mdiodevices, this driver
> allows creating a virtual MDIO bus, that translates mdiodev register
> accesses to regmap accesses.
> 
> The reason we use regmap is because there are at least 3 such devices
> known today, 2 of them are Altera TSE PCS's, memory-mapped, exposed
> with a 4-byte stride in stmmac's dwmac-socfpga variant, and a 2-byte
> stride in altera-tse. The other one (nxp,sja1110-base-tx-mdio) is
> exposed over SPI.
> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

...

> +struct mii_bus *devm_mdio_regmap_register(struct device *dev,
> +					  const struct mdio_regmap_config *config)
> +{
> +	struct mdio_regmap_config *mrc;
> +	struct mii_bus *mii;
> +	int rc;
> +
> +	if (!config->parent)
> +		return ERR_PTR(-EINVAL);
> +
> +	mii = devm_mdiobus_alloc_size(config->parent, sizeof(*mrc));
> +	if (!mii)
> +		return ERR_PTR(-ENOMEM);
> +
> +	mrc = mii->priv;
> +	memcpy(mrc, config, sizeof(*mrc));
> +
> +	mrc->regmap = config->regmap;
> +	mrc->valid_addr = config->valid_addr;
> +
> +	mii->name = DRV_NAME;
> +	strscpy(mii->id, config->name, MII_BUS_ID_SIZE);
> +	mii->parent = config->parent;
> +	mii->read = mdio_regmap_read_c22;
> +	mii->write = mdio_regmap_write_c22;
> +
> +	if (config->autoscan)
> +		mii->phy_mask = ~BIT(config->valid_addr);
> +	else
> +		mii->phy_mask = ~0UL;

Hi Maxime,

phy_mask is a u32.
But 0UL may be either 32 or 64 bits wide.

I think a better approach would be to use U32_MAX.

> +
> +	rc = devm_mdiobus_register(dev, mii);
> +	if (rc) {
> +		dev_err(config->parent, "Cannot register MDIO bus![%s] (%d)\n", mii->id, rc);
> +		return ERR_PTR(rc);
> +	}
> +
> +	return mii;
> +}
> +EXPORT_SYMBOL_GPL(devm_mdio_regmap_register);
> +
> +MODULE_DESCRIPTION("MDIO API over regmap");
> +MODULE_AUTHOR("Maxime Chevallier <maxime.chevallier@bootlin.com>");
> +MODULE_LICENSE("GPL");