Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
        Anjelique Melendez <quic_amelende@quicinc.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Conor Dooley <conor.dooley@microchip.com>,
        =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Lu Hongfei <11117923@bbktel.com>,
        linux-leds@vger.kernel.org (open list:LED SUBSYSTEM),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: [PATCH] led: qcom-lpg: Fix resource leaks in for_each_available_child_of_node() loops
Date:   Thu, 25 May 2023 19:17:03 +0800
Message-Id: <20230525111705.3055-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OlT+9ik5qU1Iz9iXTT3v9UFYCvFihFi7uMyp+SPU3n9jE7r4iPF0T7WykwVH?=
 =?us-ascii?Q?NpktQcIQIZqYbFsQZPKhDg2PormTmKFbLAEVBROyO3r1Mwopwbt+Cm5x0FKK?=
 =?us-ascii?Q?OGXgugtFAnKIaHH9wGAixbs1oRCvFcpj7tfxyTaFA1AdTU+nn65riPnQHYpc?=
 =?us-ascii?Q?ESsvRswpNs//AvksiSUVrdPbjTXwmsHNA/LHm4pN+S5EMO6jbW7Vy28f74ac?=
 =?us-ascii?Q?pIywVQwPtC/Vfx+YrBBxrAwU3++8rLbWEPqTMZF4pNcKHlOecN39D58hrkqS?=
 =?us-ascii?Q?sf89+IM7DTxLdXQa1pXTFOhxDl4dXU9gTTBLwBJTqGb2EL0rDLJpKr9Z6D5E?=
 =?us-ascii?Q?U+jFYii8d27WHSHf67KAjkxZPPBVBkXtTrOlH+Z5U1BSGljzL+rcQfgcqJTN?=
 =?us-ascii?Q?Ttic0HzQ68BRjPpAlCmbjaLQFTJGLrKwwBN20SB0HgVkhihw88p6SnZMYtnQ?=
 =?us-ascii?Q?julHmkm1xCYxXeR+HTDuEz8rf2acGdlpqPkfNnnM4wrN3pUrqPZ/pUM21rbv?=
 =?us-ascii?Q?bWy0B/PVe56v/G7wByzlu5jru/cC/ytlnro7e/3mWfVVSlCZFk7ZI+qfTXAj?=
 =?us-ascii?Q?90/L1rkdnokuQvdY6E3o6d7rcakfYTx88EVCyMWngqlPGgkBjSSLDgW35OEH?=
 =?us-ascii?Q?FB0YUJCwalXVpD2bv/x5KuFxShPZRci3qgnwYirgISE0ZRIMPz3dzMX1kp0/?=
 =?us-ascii?Q?RvcVYRMX90grtLmeBVI+0T9UeD3LsVzDWTCCzBP/IaXIcFakObYxdMANCE/a?=
 =?us-ascii?Q?QJeMFyfP0uIplWZ8ushId/URvrQNr9HHMDYnMnKNzp44ejdulkFSgEw0ZclA?=
 =?us-ascii?Q?BhYDpwcGj/DK3+NxPJkRZOsieonRLoz4niCSuXzmnnyWyqPAtm0B6YT2MpDN?=
 =?us-ascii?Q?Ia2qlDffDL4AhEtnPBnEG1M7Qp3XZ8tNCeZUzBX/LWU/ufSZk/U0jnehLiLv?=
 =?us-ascii?Q?OSWdqKeYm4zqy7sqRliAa438WY6UVF+qhMlUBtRnToAk5j4q6Wev7D7AeZya?=
 =?us-ascii?Q?O/vE2QmqpAbvpj/r0ykRs7Zb68sJvrQ7y2uXxP7vSwtsRD6XppE/ZNbumFi2?=
 =?us-ascii?Q?dc/8V09nTKdwiWZ7nfVM9TFy+7k6+JhVYgYolA9b+9bMt69KQeyD1hnxr/aG?=
 =?us-ascii?Q?vkFy854fX+Jdzcft8tZMk7RD5mO+drTmbuUGM/2gtPwvC7fwiFdxephD/s0e?=
 =?us-ascii?Q?MJzVNxmLo5m/Oke8pdg8lV3lbAAOEdVlmtq6trhfDoBtfjph/DAOW0mEELQF?=
 =?us-ascii?Q?xSoQR6f21wGi+TIdIC9GRh8Sf9DF68W5qNmHEoMlwgH2djvsulFV/0GSFeMM?=
 =?us-ascii?Q?xs3VIr1jAe0lBQ7MDTPGhaZ+3pLIYYdexaCuy5w8YBDb+vq33jQP2Fr5l+vw?=
 =?us-ascii?Q?mSZw7N8WTbYSI/ODkQPefpi+KrWg7BRnG5GVhZOgaQBp0+WU09ZQ2uPPdVq8?=
 =?us-ascii?Q?0+A9AJ/BQfDwXNDtlXeiiA1E6/tLsM1b2hBDQPIEA3yL23sDo3cGM07UZvhA?=
 =?us-ascii?Q?EynaN2gB9xxN9BMAoBzjgdZ4GRMMSOeqXUnglN+drEaRJQ7qxtf56MEn2RAZ?=
 =?us-ascii?Q?qLl/X8kqvr9jHwWhwNGBGHAfuKWca/jR4lKBPlUq?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ab77395-31c2-44b9-76c9-08db5d119c6e
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2023 11:17:22.9677
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ys48pXGKuwdlhNyTo6QEiqHYkd1o264t7TMsxJoUnfcHhzVUHmSFW/istHujw+2cZ79ktygA0yQehCpkdkjGbQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4447
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

for_each_available_child_of_node in lpg_probe and lpg_add_led need
to execute of_node_put before return. this patch could fix this bug.

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
 drivers/leds/rgb/leds-qcom-lpg.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
 mode change 100644 => 100755 drivers/leds/rgb/leds-qcom-lpg.c

diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c
index 55a037234df1..0e8ff36c4bf7
--- a/drivers/leds/rgb/leds-qcom-lpg.c
+++ b/drivers/leds/rgb/leds-qcom-lpg.c
@@ -1173,8 +1173,10 @@ static int lpg_add_led(struct lpg *lpg, struct device_node *np)
 		i = 0;
 		for_each_available_child_of_node(np, child) {
 			ret = lpg_parse_channel(lpg, child, &led->channels[i]);
-			if (ret < 0)
+			if (ret < 0) {
+				of_node_put(child);
 				return ret;
+			}
 
 			info[i].color_index = led->channels[i]->color;
 			info[i].intensity = 0;
@@ -1352,8 +1354,10 @@ static int lpg_probe(struct platform_device *pdev)
 
 	for_each_available_child_of_node(pdev->dev.of_node, np) {
 		ret = lpg_add_led(lpg, np);
-		if (ret)
+		if (ret) {
+			of_node_put(np);
 			return ret;
+		}
 	}
 
 	for (i = 0; i < lpg->num_channels; i++)
-- 
2.39.0