Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ed82970f-691a-b508-604a-17f78db9fdc1@linaro.org>
Date:   Thu, 25 May 2023 14:12:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v3 2/5] soc: qcom: smem: Switch to EXPORT_SYMBOL_GPL()
To:     Robert Marko <robimarko@gmail.com>, agross@kernel.org,
        andersson@kernel.org, ilia.lin@kernel.org, rafael@kernel.org,
        viresh.kumar@linaro.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org
Cc:     ansuelsmth@gmail.com
References: <20230525120956.3095317-1-robimarko@gmail.com>
 <20230525120956.3095317-2-robimarko@gmail.com>
Content-Language: en-US
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20230525120956.3095317-2-robimarko@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 25.05.2023 14:09, Robert Marko wrote:
> SMEM has been GPL licensed from the start, and there is no reason to use
> EXPORT_SYMBOL() so switch to the GPL version.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  drivers/soc/qcom/smem.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
> index 6be7ea93c78c..bc98520c4969 100644
> --- a/drivers/soc/qcom/smem.c
> +++ b/drivers/soc/qcom/smem.c
> @@ -500,7 +500,7 @@ int qcom_smem_alloc(unsigned host, unsigned item, size_t size)
>  
>  	return ret;
>  }
> -EXPORT_SYMBOL(qcom_smem_alloc);
> +EXPORT_SYMBOL_GPL(qcom_smem_alloc);
>  
>  static void *qcom_smem_get_global(struct qcom_smem *smem,
>  				  unsigned item,
> @@ -674,7 +674,7 @@ void *qcom_smem_get(unsigned host, unsigned item, size_t *size)
>  	return ptr;
>  
>  }
> -EXPORT_SYMBOL(qcom_smem_get);
> +EXPORT_SYMBOL_GPL(qcom_smem_get);
>  
>  /**
>   * qcom_smem_get_free_space() - retrieve amount of free space in a partition
> @@ -719,7 +719,7 @@ int qcom_smem_get_free_space(unsigned host)
>  
>  	return ret;
>  }
> -EXPORT_SYMBOL(qcom_smem_get_free_space);
> +EXPORT_SYMBOL_GPL(qcom_smem_get_free_space);
>  
>  static bool addr_in_range(void __iomem *base, size_t size, void *addr)
>  {
> @@ -770,7 +770,7 @@ phys_addr_t qcom_smem_virt_to_phys(void *p)
>  
>  	return 0;
>  }
> -EXPORT_SYMBOL(qcom_smem_virt_to_phys);
> +EXPORT_SYMBOL_GPL(qcom_smem_virt_to_phys);
>  
>  static int qcom_smem_get_sbl_version(struct qcom_smem *smem)
>  {