Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp879542rwd; Thu, 25 May 2023 05:25:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6oZJLDPdsMSwq3X+LOhaSWQ4TJ5i/KQr/y+o8riBIk4RzZqUlVmQPXc+3rQtgrpnV/aLwR X-Received: by 2002:a17:90b:1291:b0:255:f397:448d with SMTP id fw17-20020a17090b129100b00255f397448dmr1615974pjb.25.1685017513457; Thu, 25 May 2023 05:25:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685017513; cv=none; d=google.com; s=arc-20160816; b=gux6NaCGIH1XcSl5T/aikBqE7zCOC/bEk5VaieSE1ZqM7dnYolHp5Iws+zE0DP41DB zEuWGpMSIQgco03JfHSaELTj1ws+3uSCCIi9MNyyVmO+q3x6d19tfHfBeEcSKOGdoUoF lpPoNz+YvHxFZoZ1scH2LxHiBjt6HkfJleZPWu2ADeSZerb8xNyyN8TdW2gfBca4yYGF xPZYpY+A2k5veabJuh/DBS597kzXLK/EYpc1FxkyuI83G/qNDIxsiBHS4WDrfptvT5dV FmZcSptZH15PuY71a5pIC5rk+J9NRkj0wYTaMhMzvL9Go7A020QRE6yDVOyuZEeQqSFo Qh6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=37kNqkPyUf4TnEYJyzQObHu7NHQNLxL0IatVTq7bsd4=; b=al5kSPE0VKZUtjSpolYSTx9UHsF5/AebCKa3AquyxQSjpo8pZcSbzhTg5uuWrIAa0F km7kkzmeFO5vCOE0bAfEerwPpFG68fH2A5c37kwQCi9JssSwXj8XYvHUb+DeYTPuKvzT sV3x5ROV2WIB1ipP+kNvipwscQwJRr+Z3/03No3IM8QBssHVgsi997wNjW/nroH5FARj sG/TR+C8G/p5zVMWBqDorQq1a5D4EW4wnQ52WouNfOHbhXe0fo6Yrmp6xDX1raKjbZZY UEstPUZ6AcmnPawKjjEJhkVWQTT8N0fw4hmLvrnh9cudtcnMY2PTBkHK/mj7TJkvQkA4 JsWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tnkvNLlr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mg1-20020a17090b370100b00247304b4a27si589775pjb.173.2023.05.25.05.24.57; Thu, 25 May 2023 05:25:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tnkvNLlr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240169AbjEYMCc (ORCPT + 99 others); Thu, 25 May 2023 08:02:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229754AbjEYMCa (ORCPT ); Thu, 25 May 2023 08:02:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC2DD13A; Thu, 25 May 2023 05:02:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 60135644EF; Thu, 25 May 2023 12:02:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69EC6C433EF; Thu, 25 May 2023 12:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685016148; bh=6cMWfyYxquh84atqJ0WzGSDvducDprtXvAOZRpr31oI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tnkvNLlr3a3x8Et9TQ8vy2AlfVZcIiCRCGv6tEHDyJTXxTv3CsSZ75a/ttzPxs1/O tRS8OiqD0QxYW94FzpEHoCdh84oD3lBhaoqFXCsuH8xlnluCn+WO6EWUC4O1dpW94R BUScCsjemNDrUVvuE0ndm/ZoN/vT4gHTUJ8LCvy86gJlejQjbEz/DCiDvdtnuNt8vP gU/I6+ciIaPktxIPdZAO1egTUVmfSwygzxd4MQrddYrVK5wajLQSPjjOb3Y9SbG+Rv 9xFBoRT34nvd7wAg0PebxgyZ8KzEQ2w7caNm4tKQ6IEFCXtkQ7o1LirdrhtSaYjsDP rXQYJRWJZK6zg== Date: Thu, 25 May 2023 13:02:23 +0100 From: Lee Jones To: Lu Hongfei Cc: Pavel Machek , Anjelique Melendez , Thierry Reding , Conor Dooley , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Dmitry Baryshkov , Lu Hongfei <11117923@bbktel.com>, "open list:LED SUBSYSTEM" , open list , opensource.kernel@vivo.com Subject: Re: [PATCH] led: qcom-lpg: Fix resource leaks in for_each_available_child_of_node() loops Message-ID: <20230525120223.GB443478@google.com> References: <20230525111705.3055-1-luhongfei@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230525111705.3055-1-luhongfei@vivo.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 May 2023, Lu Hongfei wrote: > for_each_available_child_of_node in lpg_probe and lpg_add_led need > to execute of_node_put before return. this patch could fix this bug. > > Signed-off-by: Lu Hongfei > --- > drivers/leds/rgb/leds-qcom-lpg.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > mode change 100644 => 100755 drivers/leds/rgb/leds-qcom-lpg.c I made a few tweaks to the commit messaged. Applied, thanks -- Lee Jones [李琼斯]