Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Ding, Shenghao" <shenghao-ding@ti.com>
To:     Takashi Iwai <tiwai@suse.de>
CC:     Shenghao Ding <13916275206@139.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "perex@perex.cz" <perex@perex.cz>,
        "pierre-louis.bossart@linux.intel.com" 
        <pierre-louis.bossart@linux.intel.com>,
        "Lu, Kevin" <kevin-lu@ti.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Xu, Baojun" <x1077012@ti.com>, "Gupta, Peeyush" <peeyush@ti.com>,
        "Navada Kanyana, Mukund" <navada@ti.com>,
        "gentuser@gmail.com" <gentuser@gmail.com>,
        "Ryan_Chu@wistron.com" <Ryan_Chu@wistron.com>,
        "Sam_Wu@wistron.com" <Sam_Wu@wistron.com>
Subject: RE: [EXTERNAL] Re: [PATCH v3 4/5] ALSA: hda/tas2781: Add tas2781 HDA
 driver
Thread-Topic: [EXTERNAL] Re: [PATCH v3 4/5] ALSA: hda/tas2781: Add tas2781 HDA
 driver
Thread-Index: AQHZi7qiFX/KEOnLRkSXJDizgQHnya9nuCRggABbjACAAuPwoA==
Date:   Thu, 25 May 2023 12:53:38 +0000
Message-ID: <0102db2e22dc472091a586bb73b467d9@ti.com>
References: <20230519080227.20224-1-13916275206@139.com>
        <871qjayuvv.wl-tiwai@suse.de>   <9daf95da47b540329aa9fbbd2df5e504@ti.com>
 <87353ngtp1.wl-tiwai@suse.de>
In-Reply-To: <87353ngtp1.wl-tiwai@suse.de>
Accept-Language: en-US, zh-CN
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk


> -----Original Message-----
> From: Takashi Iwai <tiwai@suse.de>
> Sent: Tuesday, May 23, 2023 7:43 PM
> To: Ding, Shenghao <shenghao-ding@ti.com>
> Cc: Shenghao Ding <13916275206@139.com>; broonie@kernel.org;
> devicetree@vger.kernel.org; krzysztof.kozlowski+dt@linaro.org;
> robh+dt@kernel.org; lgirdwood@gmail.com; perex@perex.cz; pierre-
> louis.bossart@linux.intel.com; Lu, Kevin <kevin-lu@ti.com>; alsa-
> devel@alsa-project.org; linux-kernel@vger.kernel.org; Xu, Baojun
> <x1077012@ti.com>; Gupta, Peeyush <peeyush@ti.com>; Navada Kanyana,
> Mukund <navada@ti.com>; gentuser@gmail.com; Ryan_Chu@wistron.com;
> Sam_Wu@wistron.com
> Subject: Re: [EXTERNAL] Re: [PATCH v3 4/5] ALSA: hda/tas2781: Add tas2781
> HDA driver
>=20
> On Tue, 23 May 2023 13:22:03 +0200,
> Ding, Shenghao wrote:
> >
> > > +	[ALC287_FIXUP_TAS2781_I2C_2] =3D {
> > > +		.type =3D HDA_FIXUP_FUNC,
> > > +		.v.func =3D tas2781_fixup_i2c,
> > > +		.chained =3D true,
> > > +		.chain_id =3D ALC269_FIXUP_THINKPAD_ACPI,
> > > +	},
> > > +	[ALC287_FIXUP_TAS2781_I2C_4] =3D {
> > > +		.type =3D HDA_FIXUP_FUNC,
> > > +		.v.func =3D tas2781_fixup_i2c,
> > > +		.chained =3D true,
> > > +		.chain_id =3D ALC269_FIXUP_THINKPAD_ACPI,
> > > +	},
> >
> > What's a difference between *_2 and *_4?
> > Combine them into ALC287_FIXUP_TAS2781_I2C
>=20
> Hm, so there is no difference in stereo and quad speakers?
Yes, our firmware defines the stereo or quad speaker
>=20
> > > +static int tas2781_save_calibration(struct tasdevice_priv
> > > +*tas_priv) {
> > > +	efi_guid_t efi_guid =3D EFI_GUID(0x02f9af02, 0x7734, 0x4233, 0xb4,
> 0x3d,
> > > +		0x93, 0xfe, 0x5a, 0xa3, 0x5d, 0xb3);
> > > +	static efi_char16_t efi_name[] =3D L"CALI_DATA";
> > > +	struct hda_codec *codec =3D tas_priv->codec;
> > > +	unsigned int subid =3D codec->core.subsystem_id & 0xFFFF;
> > > +	struct tm *tm =3D &tas_priv->tm;
> > > +	unsigned int attr, crc;
> > > +	unsigned int *tmp_val;
> > > +	efi_status_t status;
> > > +	int ret =3D 0;
> > > +
> > > +	//Lenovo devices
> > > +	if ((subid =3D=3D 0x387d) || (subid =3D=3D 0x387e) || (subid =3D=3D=
 0x3881)
> > > +		|| (subid =3D=3D 0x3884) || (subid =3D=3D 0x3886) || (subid =3D=3D=
 0x38a7)
> > > +		|| (subid =3D=3D 0x38a8) || (subid =3D=3D 0x38ba) || (subid =3D=3D
> 0x38bb)
> > > +		|| (subid =3D=3D 0x38be) || (subid =3D=3D 0x38bf) || (subid =3D=3D=
 0x38c3)
> > > +		|| (subid =3D=3D 0x38cb) || (subid =3D=3D 0x38cd))
> > > +		efi_guid =3D EFI_GUID(0x1f52d2a1, 0xbb3a, 0x457d, 0xbc, 0x09,
> > > +			0x43, 0xa3, 0xf4, 0x31, 0x0a, 0x92);
> >
> > Here can be a problem: the device ID is embedded here, and it's hard to
> find out.  You'd better to make it some quirk flag that is set in a commo=
n
> place and check the flag here instead of checking ID at each place.
> >
> > Do you have example of the solution? I found some quirk flag is static =
in
> the patch_realtek.c, can't be accessed outside that file.
>=20
> You may store some values in struct hda_component, I suppose?
I will try it.
>=20
> BTW, please try to fix your mailer to do citation more correctly...
accept
>=20
>=20
> thanks,
>=20
> Takashi