Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 May 2023 14:56:46 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Osama Muhammad <osmtendev@gmail.com>
Cc:     jinpu.wang@ionos.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] omap_ssi_port.c: Fix error checking for
 debugfs_create_dir
Message-ID: <20230525125646.f4rfjb2limbtuh2c@mercury.elektranox.org>
References: <20230523172434.13477-1-osmtendev@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="thqsfdjzhqzzc6kc"
Content-Disposition: inline
In-Reply-To: <20230523172434.13477-1-osmtendev@gmail.com>
Precedence: bulk


--thqsfdjzhqzzc6kc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, May 23, 2023 at 10:24:34PM +0500, Osama Muhammad wrote:
> This patch fixes the error checking in omap_ssi_port.c in
> debugfs_create_dir. The correct way to check if an error occurred
> is 'IS_ERR' inline function.
>=20
> Signed-off-by: Osama Muhammad <osmtendev@gmail.com>
> ---

This masks the error code. But the proper fix is to just ignore any
errors as the help text for debugfs_create_dir() explains. Please send
a new patch removing the 'if (!dir) return -ENOMEM;'. Also the
function can be changed to be of type void afterwards.

Thanks,

-- Sebastian

>  drivers/hsi/controllers/omap_ssi_port.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/hsi/controllers/omap_ssi_port.c b/drivers/hsi/contro=
llers/omap_ssi_port.c
> index b9495b720f1b..7ad41599baa5 100644
> --- a/drivers/hsi/controllers/omap_ssi_port.c
> +++ b/drivers/hsi/controllers/omap_ssi_port.c
> @@ -157,12 +157,12 @@ static int ssi_debug_add_port(struct omap_ssi_port =
*omap_port,
>  	struct hsi_port *port =3D to_hsi_port(omap_port->dev);
> =20
>  	dir =3D debugfs_create_dir(dev_name(omap_port->dev), dir);
> -	if (!dir)
> +	if (IS_ERR(dir))
>  		return -ENOMEM;
>  	omap_port->dir =3D dir;
>  	debugfs_create_file("regs", S_IRUGO, dir, port, &ssi_port_regs_fops);
>  	dir =3D debugfs_create_dir("sst", dir);
> -	if (!dir)
> +	if (IS_ERR(dir))
>  		return -ENOMEM;
>  	debugfs_create_file_unsafe("divisor", 0644, dir, port,
>  				   &ssi_sst_div_fops);
> --=20
> 2.34.1
>=20

--thqsfdjzhqzzc6kc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmRvWwEACgkQ2O7X88g7
+ppt8hAAk2PTNjGFlYd6h3hSQhJ8lwjxNdtDToPXUdXukbpQw74/bSUFDGVjUEZf
y/IzRmFtQFHYyd9ax+4FfHhFyw8Wnm9LXuVrO+ugrpNm8riqRmhC4tBEhDanyhI6
B1opsYj+n8vt8gVphI87Nv6ZIkuYiRXzXmcm9vBxxYj9cOBqqBc3uWjZ3zmPnyMK
+CJaoJgtz4HYEGMRBSte3iQQ3LXoVItnY6NkKPRdp4W6GQs8jcJDzsqQEbM+D5cm
/3xd1gPDZ8OfR2DFyHJCMwC0GTuFMpsjbFaxkX70h5rkIHnXfKPwr84wMMM82dQA
D8NoeRUTMWOvKNukiqONOT9zXdMYQCJ+CczM5+YAQYV/RDLGTM0LqBJQshjuWYXn
qCAV2FD5GcRbVXDzxUgLnEtoW9EO+eYICjks5vQLAkhHMjc1DQdCGIPipgurzFi1
1gVjn5F0PzoqXkE9dOjnM2k3zgFXjc8bsBl7pna8zpOeYC25AICvOrBhvf3AfaSL
+1Tyy09RrPu+jo6f0EY53kJP1/nw0JwRXkKBcSYOzjCDEEWs37zZft5aFH2nCp2Q
AiYsHTIAqat9ecTPAQRiDwB6f1ku5xLPkkj5VDRY6h5AMycn8G5xeJ9aYVUHqhPg
k1UPP8gjhhZpuWT2EdTeZWovJYfiHIWLMcIUBhR0cRqRKpwDiQo=
=rPGM
-----END PGP SIGNATURE-----

--thqsfdjzhqzzc6kc--