Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230525040324.3773741-1-hugo@hugovil.com> <ZG84KCeMIINFVTMh@surfacebook>
 <20230525092627.edf4f7f9df4b9b1cf7b568a4@hugovil.com>
In-Reply-To: <20230525092627.edf4f7f9df4b9b1cf7b568a4@hugovil.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 25 May 2023 16:37:17 +0300
Message-ID: <CAHp75VenvvkC1evsmhSBNT5=V=D92RX1JXnwZWAtsJ2TrADvRA@mail.gmail.com>
Subject: Re: [PATCH v3 00/11] serial: sc16is7xx: fix GPIO regression and rs485 improvements
To:     Hugo Villeneuve <hugo@hugovil.com>
Cc:     gregkh@linuxfoundation.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        jirislaby@kernel.org, jringle@gridpoint.com,
        tomasz.mon@camlingroup.com, l.perczak@camlintechnologies.com,
        linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        Hugo Villeneuve <hvilleneuve@dimonoff.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, May 25, 2023 at 4:26=E2=80=AFPM Hugo Villeneuve <hugo@hugovil.com> =
wrote:
> On Thu, 25 May 2023 13:27:52 +0300
> andy.shevchenko@gmail.com wrote:
> > Thu, May 25, 2023 at 12:03:13AM -0400, Hugo Villeneuve kirjoitti:
> > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > >
> > > Hello,
> > > this patch series mainly fixes a GPIO regression and improve RS485 fl=
ags and properties
> > > detection from DT.
> > >
> > > It now also includes various small fixes and improvements that were p=
reviously
> > > sent as separate patches, but that made testing everything difficult.
> >
> > > Patches 1 and 2 are simple comments fix/improvements.
> >
> > Usually we put fixes at the beginning of the series, but these patches =
are
> > missing Fixed tag. Are they really fixes or can be simply moved to the =
end of
> > the series?
>
> these are not code fixes, they are comments improvements. I was not aware=
 that you need to put a Fixes tag for correcting syntax errors in comments,=
 or adding comments to improve clarity.
>
> I often submit such comments patches but was never asked to put a Fixes t=
ag before. Seems strange to me...

In this case there are probably no conflicts, but the usual grouping
of patches is following
1) fixes that may be backported;
2) cleanups / refactoring /etc;
3) new features.
4) additional light-weit cleanups, such as whitespace cleaning (it's a
radical, we probably do not accept pure whitespace cleaning patches,
but you got the idea).

Seems patches 1 and 2 fall into category 4).

--=20
With Best Regards,
Andy Shevchenko