Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 May 2023 14:55:42 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Anup Patel <anup@brainfault.org>
CC:     Anup Patel <apatel@ventanamicro.com>,
        Atish Patra <atishp@atishpatra.org>,
        Alexandre Ghiti <alex@ghiti.fr>, <robh@kernel.org>,
        Alexandre Ghiti <alexghiti@rivosinc.com>,
        <jeeheng.sia@starfivetech.com>, <linux-kernel@vger.kernel.org>,
        <palmer@rivosinc.com>, <leyfoon.tan@starfivetech.com>,
        <mason.huo@starfivetech.com>, Guo Ren <guoren@kernel.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Song Shuai <suagrfillet@gmail.com>,
        <linux-riscv@lists.infradead.org>,
        Andrew Jones <ajones@ventanamicro.com>
Subject: Re: Bug report: kernel paniced when system hibernates
Message-ID: <20230525-shrapnel-precut-26500fca4a48@wendy>
References: <20230517-preacher-primer-f41020b3376a@wendy>
 <CAHVXubhMLgb54_7zV2yFuGPoMKCkUXwozHbDvghc7kQqNLK-JA@mail.gmail.com>
 <CAAhSdy3tKAk1xjinwnSWan0ivdDapcLvSb+hGNynPFZMUsoB9A@mail.gmail.com>
 <fe8d716c-fb4f-1f3f-6c69-de1d8b9fb6af@ghiti.fr>
 <CAK9=C2X1BjZCHfYM33pZQtavu7yRqxwsypWL5OWj79bJrnDMQg@mail.gmail.com>
 <CAOnJCULpa-TJuG=TtCDOxOdUviZzWheLE-GMiU1r7GWaKn0nuQ@mail.gmail.com>
 <20230525-guacamole-swimmer-68048a73baac@wendy>
 <CAK9=C2WUyLxZwQO37cN-i+V+A3yxmEoaj=uE8yR8nseYTDW7oQ@mail.gmail.com>
 <20230525-postnasal-monopoly-98adb96ffaa1@wendy>
 <CAAhSdy06nQh4H1FP_K_-VF462mhj+F2M=4AV4QSCUGe5XVqX0g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="OFwHiDdDsq9ntBHt"
Content-Disposition: inline
In-Reply-To: <CAAhSdy06nQh4H1FP_K_-VF462mhj+F2M=4AV4QSCUGe5XVqX0g@mail.gmail.com>
Precedence: bulk

--OFwHiDdDsq9ntBHt
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 25, 2023 at 07:13:11PM +0530, Anup Patel wrote:
> On Thu, May 25, 2023 at 7:08=E2=80=AFPM Conor Dooley <conor.dooley@microc=
hip.com> wrote:
> >
> > On Thu, May 25, 2023 at 06:51:28PM +0530, Anup Patel wrote:
> >
> > > > We should only rely on this node name for known bad versions of ope=
nsbi
> > > > IMO. Going forward, if something needs to be reserved for firmware,=
 the
> > > > firmware should make sure that it is reserved by using the property=
 for
> > > > that purpose :)
> >
> > > There is no issue with OpenSBI since it does the right thing by marki=
ng
> > > memory as reserved in the DT. This real issue is with the kernel hand=
ling
> > > of reserved memory for hibernate.
> >
> > I don't think we are talking about the same thing here. I meant the
> > no-map property which OpenSBI does not set.
>=20
> Yes, we are talking about the same thing. It's not just OpenSBI not
> setting no-map property in reserved memory node because other
> SBI implementations would be doing the same thing (i.e. not setting
> no-map property)

Other SBI implementations doing the same thing doesn't make it any more
correct though, right?

> > > Like Atish mentioned, not just OpenSBI, there will be other entities
> > > (like TSM) or some other M-mode firmware which will also reserve
> > > memory in DT/ACPI so clearly kernel needs a SBI implementation
> > > independent way of handling reserved memory for hibernate.
> >
> > > > > Another option is to use compatible string or label property to i=
ndicate
> > > > > that this memory region is not to be saved/restored during hibern=
ation.
> > > > > This can be documented in RISC-V DT bindings as well as the booti=
ng guide
> > > > > doc that alex was talking about.
> > > >
> > > > Sure, a dt-binding for sbi reserved regions doesn't immediately sou=
nd
> > > > like an awful idea... But we still have to work around the borked
> > > > firmware - be that disabling hibernation or using the mmode_resv no=
de
> > > > when we know that the version of OpenSBI is one of those with the
> > > > problem.
> >
> > Did you skip over this? I was agreeing that defining a common binding f=
or
> > sbi reserved regions was a good idea.

--OFwHiDdDsq9ntBHt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZG9o3gAKCRB4tDGHoIJi
0gmsAQDEkuoMF0HDEcJQCW9qndjbk4bpKWaSwzgKHMvPTLClDwD/Tx9ATCMUdkIN
Yr7l0UleTYU8XObDH+OTvhupiW7CAAA=
=9IgR
-----END PGP SIGNATURE-----

--OFwHiDdDsq9ntBHt--