Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 May 2023 17:00:04 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc:     Mark Brown <broonie@kernel.org>, davem@davemloft.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        alexis.lothore@bootlin.com, thomas.petazzoni@bootlin.com,
        Andrew Lunn <andrew@lunn.ch>, Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>
Subject: Re: [PATCH net-next v2 1/4] net: mdio: Introduce a regmap-based mdio
 driver
Message-ID: <ZG939BnbaRP4GiI4@corigine.com>
References: <20230525101126.370108-1-maxime.chevallier@bootlin.com>
 <20230525101126.370108-2-maxime.chevallier@bootlin.com>
 <ZG9AT4EeCmoyN5N2@corigine.com>
 <20230525144359.0cb16996@pc-7.home>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230525144359.0cb16996@pc-7.home>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nV8isRmATYhMxQjQvpoFY8J8RrPYvwoKw+dAuGxIr9mrL5zIO/aqEmEYgwdR?=
 =?us-ascii?Q?11ulS+JNGdlRK2xY8So9DgH7+KWS6T1pqPxxrlZOKJ8GXHS1rpV0Wxwz0RFa?=
 =?us-ascii?Q?4GAaLEl443c0SwxhEjegfzWizwguM6kJUPhoFfo/kUVr2PAKzxN8VqnULmJS?=
 =?us-ascii?Q?zvnf3r9AhXeZWWB7jOHvYU9WnrhRhJq2uTBDLf0TD1uloYRswcujztLhNXUZ?=
 =?us-ascii?Q?r0eKGcjQBMWbfoKarVxAm1AF9jCtMZ3l6cEyEId9e03aa67v4FaxTm+oWSFL?=
 =?us-ascii?Q?jciVP95KnO57WJd+W3iRVuCqfqF0nLdOaZIjqi5arRDY4ep0Vd7IN/a2+2Uf?=
 =?us-ascii?Q?M64Bs3nvZ1+gVfeIEdzLfvhO9kMI5H6pOMUeoS0wuVz6rSkiNfPARcPfl0P/?=
 =?us-ascii?Q?XaslpZ4fRUPH9tW2dY1lL/CWtaPLuT/vY8K1zfanoS4No/m5n3LwgPEO1MQJ?=
 =?us-ascii?Q?bSRc8aIxiAOzjp8wq3+7jGEXMJXgi58GgVyNfR/+tY/7148VM2vqtgL4JSoX?=
 =?us-ascii?Q?a6g5KLA4Cs/dyIY9L68I0pcaYcwf7xzYabtNEmrwCKcgSCOJ4uktvsr+o+hj?=
 =?us-ascii?Q?iGI+xJPL8zp+y91jEeEickz3I/FCrImJnZ/cOSQyXv1MW4egzlBr6Q2J+/Hi?=
 =?us-ascii?Q?kUFJk2TRzKTkRHnTMRnIcfpju+JAiiq40Rp1R1qa65rpqIB1xSoNeHytY1Tm?=
 =?us-ascii?Q?N1l+dUSd99SOBQMcfujAj+qt6a29kQtShyvxSlWTiSfdtAb5C5WXvr3RaG6Q?=
 =?us-ascii?Q?OPi1jRS+/0Yqqa/oBh1qfTxJlnOOxFymQUNBbuLp9wC0uC8C9AGPgwWbOvC1?=
 =?us-ascii?Q?aczDWIJNy0nphOVL5KagAsM2X3Ktt5VfV8l3f2FdzdHC4I7jHvoGpZGnU6XW?=
 =?us-ascii?Q?4jiTaVueTBRzfu3Sy2dwqWigzIPbiInr80wpaz8fYo2ASdrE1Dyjh/jpT2wm?=
 =?us-ascii?Q?kQ6tgJGti3fZik/s9ibL/GDTsCxiIU8NQeATlKa+yL65FFsepb+pN4BNK2ph?=
 =?us-ascii?Q?Y6NHXtmyVoeQ2HAPV6Wnc/uXtIfNFgV8KkckjoLVfN7ScbXIJiLFkfotzxEd?=
 =?us-ascii?Q?dimRcy4ACl27sQMbdu2AXeupm31L5QbYV31j14N+y6yaCMA0zUv3FZFOscOP?=
 =?us-ascii?Q?/dgdgqOCk8Ujxh6qBneuFqu0TFJLvY5QJfkWzTnBSGo/CGCuSoRByTz9Yu43?=
 =?us-ascii?Q?f403IF1MqqpU3w/aN1Zb0XrSkJSo7JxpCBw3BcX53+28wyZDlQVbN2zRe12U?=
 =?us-ascii?Q?xByjp5CzHsaDp1Yb9yntWyPrHQp/+vQDYP+XRR7etVnpBTx4UZlAHHFNX7+o?=
 =?us-ascii?Q?1lG19dxoSBWpyQBD3EjN783GjRu3DFQNdghQercrMKrG0Umigqu+fXBqlK8A?=
 =?us-ascii?Q?fX1oh+hrztasQPs6jqHz1VcRHR4ntDoNBoQJUsQk3x6Zeo1mioIt6wHTaqVC?=
 =?us-ascii?Q?sYTUgE/Jy4P9hwDl/+3eief80aIvGx5KMfuldJK0hwivJzG5a4af2aUenI3r?=
 =?us-ascii?Q?QRClDv438tm2JDLqj/Fdns/a52XwUtZyrj56ryTZePgwTUnXjhSZKgRLFVZN?=
 =?us-ascii?Q?HdCYUeOUslLc1OOxjYwX+TPkYvL72x8UUhGPEAjESuAACQmJLbNI6lu4EYfb?=
 =?us-ascii?Q?x//QtjiqQCpCFfuYXArd8yXevvHL4ZNi26Atdi8dZ28QFa8LBR4V9Y9gqWmV?=
 =?us-ascii?Q?SKDm+Q=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc6c601a-d5b2-47c3-1d7a-08db5d30bd32
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2023 15:00:12.3675
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lyiQFVrx0szKERgHHm0Xhc3Ncem2nmr2UnJFGxMn/VSuU7oj2EhKVN+2Iuoae9oHYzKLx9sHpbSbmYrkTVgyPYAUvf7sTVSlCxCmXk9ZDGo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR13MB4673
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 25, 2023 at 02:43:59PM +0200, Maxime Chevallier wrote:
> Hello Simon,
> 
> On Thu, 25 May 2023 13:02:39 +0200
> Simon Horman <simon.horman@corigine.com> wrote:
> 
> > On Thu, May 25, 2023 at 12:11:23PM +0200, Maxime Chevallier wrote:
> > > There exists several examples today of devices that embed an
> > > ethernet PHY or PCS directly inside an SoC. In this situation,
> > > either the device is controlled through a vendor-specific register
> > > set, or sometimes exposes the standard 802.3 registers that are
> > > typically accessed over MDIO.
> > > 
> > > As phylib and phylink are designed to use mdiodevices, this driver
> > > allows creating a virtual MDIO bus, that translates mdiodev register
> > > accesses to regmap accesses.
> > > 
> > > The reason we use regmap is because there are at least 3 such
> > > devices known today, 2 of them are Altera TSE PCS's, memory-mapped,
> > > exposed with a 4-byte stride in stmmac's dwmac-socfpga variant, and
> > > a 2-byte stride in altera-tse. The other one
> > > (nxp,sja1110-base-tx-mdio) is exposed over SPI.
> > > 
> > > Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>  
> > 
> > ...
> > 
> > > +struct mii_bus *devm_mdio_regmap_register(struct device *dev,
> > > +					  const struct
> > > mdio_regmap_config *config) +{
> > > +	struct mdio_regmap_config *mrc;
> > > +	struct mii_bus *mii;
> > > +	int rc;
> > > +
> > > +	if (!config->parent)
> > > +		return ERR_PTR(-EINVAL);
> > > +
> > > +	mii = devm_mdiobus_alloc_size(config->parent,
> > > sizeof(*mrc));
> > > +	if (!mii)
> > > +		return ERR_PTR(-ENOMEM);
> > > +
> > > +	mrc = mii->priv;
> > > +	memcpy(mrc, config, sizeof(*mrc));
> > > +
> > > +	mrc->regmap = config->regmap;
> > > +	mrc->valid_addr = config->valid_addr;
> > > +
> > > +	mii->name = DRV_NAME;
> > > +	strscpy(mii->id, config->name, MII_BUS_ID_SIZE);
> > > +	mii->parent = config->parent;
> > > +	mii->read = mdio_regmap_read_c22;
> > > +	mii->write = mdio_regmap_write_c22;
> > > +
> > > +	if (config->autoscan)
> > > +		mii->phy_mask = ~BIT(config->valid_addr);
> > > +	else
> > > +		mii->phy_mask = ~0UL;  
> > 
> > Hi Maxime,
> > 
> > phy_mask is a u32.
> > But 0UL may be either 32 or 64 bits wide.
> 
> Right
> 
> > I think a better approach would be to use U32_MAX.
> 
> I guess ~0 would also work, and this would also align with what
> fixed-phy and sfp do for their internal MDIO bus.

Yes, I guess so too.

> I'll fix that for next revision

Thanks!