Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 May 2023 09:32:00 -0600
From:   Mathieu Poirier <mathieu.poirier@linaro.org>
To:     Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Cc:     linux-remoteproc@vger.kernel.org, agross@kernel.org,
        andersson@kernel.org, lgirdwood@gmail.com, broonie@kernel.org,
        robh+dt@kernel.org, quic_plai@quicinc.com, bgoswami@quicinc.com,
        perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org,
        quic_rohkumar@quicinc.com, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, swboyd@chromium.org,
        judyhsiao@chromium.org, devicetree@vger.kernel.org,
        krzysztof.kozlowski@linaro.org, corbet@lwn.net,
        quic_visr@quicinc.com
Subject: Re: [PATCH v5 0/2] Update section header name check
Message-ID: <ZG9/cEMRMg06Pz4u@p14s>
References: <20230223150559.2429562-1-quic_mohs@quicinc.com>
 <20230302215735.GA1401708@p14s>
 <f9c6fead-d573-a8bc-7e88-a53313ff8bef@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f9c6fead-d573-a8bc-7e88-a53313ff8bef@quicinc.com>
Precedence: bulk

On Thu, May 11, 2023 at 10:09:45PM +0530, Mohammad Rafi Shaik wrote:
> 
> On 3/3/2023 3:27 AM, Mathieu Poirier wrote:
> > On Thu, Feb 23, 2023 at 08:35:57PM +0530, Mohammad Rafi Shaik wrote:
> > > Update section header name check and corresponding documentation.
> > > Changes since v4:
> > >      -- Rephrase commit message.
> > Asked for clarifications on V4 that were never given to me.  This patchset will
> > not move forward until those have been resolved.
> The present Qualcomm DSP binary contains resource table name as
> ".resource_table.ac_bin_process.",

My questions still haven't been answered:

1. Why do we have to change the kernel because of the way a company specific
tool generates an ELF?

2. Why is the "ac_bin_process" part needed at all?

> so the current logic with strcmp will fail with present comparision ?as the
> binary name is not only .resource_table but resource_table.ac_bin_process So
> to overcome this issue we modified the way of checking the resource table
> name to make it generic.
> 
> strstarts(name_table + name, ".resource_table");
> 
> This logic will perform a string comparison with name ".resouce_table"as our
> binary name is .resource_table.ac_bin_process it succeeds
> 
> > > Changes since v3:
> > >      -- Rephrase commit message.
> > > Changes since v2:
> > >      -- Update the commit message with example.
> > >      -- Update the documentation text appropriately.
> > > Changes since v1:
> > >      -- Update the commit message.
> > >      -- Use strstarts instead of strstr.
> > >      -- Update documentation file.
> > > 
> > > Srinivasa Rao Mandadapu (2):
> > >    remoteproc: elf_loader: Update resource table name check
> > >    docs: remoteproc: Update section header name requirement
> > > 
> > >   Documentation/staging/remoteproc.rst       | 5 ++++-
> > >   drivers/remoteproc/remoteproc_elf_loader.c | 2 +-
> > >   2 files changed, 5 insertions(+), 2 deletions(-)
> > > 
> > > -- 
> > > 2.25.1
> > >