Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1238586rwd; Thu, 25 May 2023 09:45:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ45CfeFqm8f1J8+p8WwUhYp0B8fE6ECZjjUonvHcbwc9HRCSw1IO831p9oPrLNpUchjOW3s X-Received: by 2002:a05:6a00:15cf:b0:643:59cd:6caa with SMTP id o15-20020a056a0015cf00b0064359cd6caamr11694998pfu.7.1685033142012; Thu, 25 May 2023 09:45:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685033141; cv=none; d=google.com; s=arc-20160816; b=dhPQo0lQuzf+l6i/dHPLC/ZfGErooXOvh4jj73vHN+iK66i7s5IRkFXnfLSJpjsKte txdOh9zoBgZYPA6UhzHpi9t9Ade/2oNwuJzGHVT0QCNUEUaRf9x26P2hyw42u18r1vcu 7rojuxGPjByWlOYkAgjENRw9R2FSHSk3ccmOq9hHI5K1S4+nGkX37jmxZ82Uo51Wkw1P qAg0bISShd2VIQn3w4jns5exBviqlXFuHxmEwxKcgr6jDDcfhC8PBUO+rSoYcYl8YhyK KynnTNqpTBtfaSBGPttlnxMAKB9i7bPUyIrrktKjw1eMxIogUiNUHrlHTnguRh4PkBuP SXcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=QJG3XonGqwQZM3zjv5292/4k+DBqsTBpPdeV3DeaMU0=; b=ewqSq9AiX8OTlg+BqNSuhbumUY0QwEHDksO7UChj8WgH3QIjOIRWGnWog6iH+df5cj nbjzSnX3xuChv54i9INf/Nj9a1u20dwG1sBdZJ02cw9r1rr346g+ApYir6mD4ABCfeRm 9fGbStnblYnSAr1I/Sl3wyUvhBu0O+J+sgFUgnyk+Q0kRZQUMxPpSTKVrmoQoT1fYDHk cAvxXBYBf6UwPk1jkPck7HBgun2f0GjHqgPM3fnxENzr8fn5fmTjB/hskWxc3DwlqP5C X1/pOXHCemSTQW0cUSIEOQBahZY2//k2jJYVtEyNOw7EFkotULGADX3o4lecWHZCEPRV a1Aw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q22-20020a637516000000b0052d7238ad55si1440953pgc.793.2023.05.25.09.45.27; Thu, 25 May 2023 09:45:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235065AbjEYQiA (ORCPT + 99 others); Thu, 25 May 2023 12:38:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233178AbjEYQh6 (ORCPT ); Thu, 25 May 2023 12:37:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E976195; Thu, 25 May 2023 09:37:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2A25361423; Thu, 25 May 2023 16:37:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A40FC433EF; Thu, 25 May 2023 16:37:50 +0000 (UTC) Date: Thu, 25 May 2023 17:37:47 +0100 From: Catalin Marinas To: Hugh Dickins Cc: Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Russell King , Will Deacon , Geert Uytterhoeven , Greg Ungerer , Michal Simek , Thomas Bogendoerfer , Helge Deller , John David Anglin , "Aneesh Kumar K.V" , Michael Ellerman , Alexandre Ghiti , Palmer Dabbelt , Heiko Carstens , Christian Borntraeger , Claudio Imbrenda , John Paul Adrian Glaubitz , "David S. Miller" , Chris Zankel , Max Filippov , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 03/23] arm64/hugetlb: pte_alloc_huge() pte_offset_huge() Message-ID: References: <77a5d8c-406b-7068-4f17-23b7ac53bc83@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 09, 2023 at 09:45:57PM -0700, Hugh Dickins wrote: > pte_alloc_map() expects to be followed by pte_unmap(), but hugetlb omits > that: to keep balance in future, use the recently added pte_alloc_huge() > instead; with pte_offset_huge() a better name for pte_offset_kernel(). > > Signed-off-by: Hugh Dickins Acked-by: Catalin Marinas