Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1264536rwd; Thu, 25 May 2023 10:05:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6DG5IdndP+5R4KeoVfjCkKCD2UcshgjxEHb/VKLIL6JQz6wZCzaTtKsxwDDZgIiETkGveu X-Received: by 2002:a17:902:ec88:b0:1af:cbdf:8e73 with SMTP id x8-20020a170902ec8800b001afcbdf8e73mr3057904plg.8.1685034349533; Thu, 25 May 2023 10:05:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685034349; cv=none; d=google.com; s=arc-20160816; b=FLq8z2OyPxAbnl+iHfugCyPtaiifFlWUV1lFGjXCisCluGCK+/XdcaY53sNIFzMvD4 fTqG02woiVCFEu6oRdfKwxG/W/3Zc4eLBs9U8UdlJatTTm36d1aOoAiVu0C6+hL/THWn fT+0+glX0o+KlUjmUQx/Rhu6K3bEg59mX2doef1m9UX6YYm4xsLPpGFPNyTUZ16IqZ03 3kQEHFrll5FOLFa8tN4Bj7/xKg97BHSztUmmUQgPhPDFPMBz48J8VihxTDCSG//+m2qR b/xyepv19EnkEh5sk3g4XT7ZI55Z5Y3zKwdpPbmVQQgwC6tCL+g9aohWAraW2zl2Ui80 Vu9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=paBP0vOj1Oa5uUTdrTpCNVgRYwIDOWgjDLReXMmgoho=; b=DttWl3EQrwh0QyUaF3A2OymyrbCbZOAHzmIlC6VshMDUCg7SqDJKimsRg14gLCfTIT vUKKSDnDy/B/yOaFkXOsJoJIknmtVFfzqeKXbAyA6s4Hjsiy/i13ckW7Viwe+cVidzv5 +m1l0nUOtkIAsXmR32KlC/GiHdp8ygdUD42m2mJ8sqW1EihbSEZJzu2GJLZerQYCQvql TPUV5Lyqjhpr7WcgdOTeChHlF+/wcUc/XK7KTmK9BsRkVk2XLqFLagXmgH8uznDG+DGr gCZU3jbMNwU0Ni11ASl0CDDPGKDNqU61ML9F2GV+MAaF/AtB7S0jkgbi9j0Cpno4tViZ qF/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Xi5dK1+1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x2-20020a170902fe8200b001992f451a28si1776963plm.384.2023.05.25.10.05.32; Thu, 25 May 2023 10:05:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Xi5dK1+1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239290AbjEYQuN (ORCPT + 99 others); Thu, 25 May 2023 12:50:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232833AbjEYQuL (ORCPT ); Thu, 25 May 2023 12:50:11 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE3BB189; Thu, 25 May 2023 09:50:10 -0700 (PDT) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34PF9tvx003813; Thu, 25 May 2023 16:50:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=paBP0vOj1Oa5uUTdrTpCNVgRYwIDOWgjDLReXMmgoho=; b=Xi5dK1+1RtMSb/aBQCRaP7WrsYOonAR06ndYPgOLiZ32vYMZAt0VfypOGsEG7Pc1BemO 1693ElnbQ6pGQzyMaRj11UxZ3PyQz/CO660DmABkyaO9oBnmZq+wOmWQgqXK5F21ESU2 sKizJ8ZQqqpQVKyTF5Em/v+958Y/C2Fk7+sm5buAEpQ6xGqZgbIA+jm5RSdioV/lcOOY PODFlZAjyjSFTzARNA9ybT6vIZOmAsmHHRyY5p3+J+mB7MbCXfscQjQbTZDcfx8O/fjL +TEu2olJAZDbLh9+98vHKXSPCXvhUIEkhV6DIJV8uckvqpFKajxh84g8QXossgkP2vgj bg== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qt5ufru84-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 May 2023 16:50:07 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 34PGo6MI026040 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 May 2023 16:50:06 GMT Received: from [10.216.52.104] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Thu, 25 May 2023 09:49:57 -0700 Message-ID: <0a1a5403-8e56-9c47-02e1-78bba820581e@quicinc.com> Date: Thu, 25 May 2023 22:19:51 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 3/4] clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550 To: Bryan O'Donoghue , Andy Gross , Michael Turquette , "Stephen Boyd" , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley CC: Bjorn Andersson , Konrad Dybcio , , , , , Taniya Das , "Satya Priya Kakitapalli" , , References: <20230519155602.6642-1-quic_jkona@quicinc.com> <20230519155602.6642-4-quic_jkona@quicinc.com> <0d0a1985-a08b-29ed-4bc4-2eea560d7ac0@linaro.org> From: Jagadeesh Kona In-Reply-To: <0d0a1985-a08b-29ed-4bc4-2eea560d7ac0@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: QamMLoHGi-IFv8fUqG6CzAvWUqCPD0I2 X-Proofpoint-GUID: QamMLoHGi-IFv8fUqG6CzAvWUqCPD0I2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-25_09,2023-05-25_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1011 adultscore=0 priorityscore=1501 mlxlogscore=950 spamscore=0 bulkscore=0 impostorscore=0 phishscore=0 mlxscore=0 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305250140 X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bryan, Thanks for your review! On 5/20/2023 1:56 AM, Bryan O'Donoghue wrote: > On 19/05/2023 16:56, Jagadeesh Kona wrote: >> +MODULE_DESCRIPTION("QTI CAM_CC SM8550 Driver"); > > This pattern looks odd and inconsistent in our clock drivers. We mostly > have CAMCC or VIDEOCC but occasionally have CAM_CC and VIDEO_CC. > > I'd drop that underscore to, in addition to Konrad's comment on Ucase hex. > > Other than that, LGTM. > Will take care of this in next series. > Reviewed-by: Bryan O'Donoghue Thanks & Regards, Jagadeesh