Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230525103428.49712-1-linmiaohe@huawei.com>
In-Reply-To: <20230525103428.49712-1-linmiaohe@huawei.com>
From:   Suren Baghdasaryan <surenb@google.com>
Date:   Thu, 25 May 2023 10:43:34 -0700
Message-ID: <CAJuCfpEP0m+4fdTSvY5TuWwvvpiQntG5OBhSmEMJipoX75eNLg@mail.gmail.com>
Subject: Re: [PATCH] sched/psi: make psi_cgroups_enabled static
To:     Miaohe Lin <linmiaohe@huawei.com>
Cc:     hannes@cmpxchg.org, mingo@redhat.com, peterz@infradead.org,
        juri.lelli@redhat.com, vincent.guittot@linaro.org,
        dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com,
        mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, May 24, 2023 at 7:43=E2=80=AFPM Miaohe Lin <linmiaohe@huawei.com> w=
rote:
>
> The static key psi_cgroups_enabled is only used inside file psi.c.
> Make it static.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Reviewed-by: Suren Baghdasaryan <surenb@google.com>

> ---
>  kernel/sched/psi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> index 81fca77397f6..2ccb0b2ebd78 100644
> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -140,7 +140,7 @@
>  static int psi_bug __read_mostly;
>
>  DEFINE_STATIC_KEY_FALSE(psi_disabled);
> -DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
> +static DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
>
>  #ifdef CONFIG_PSI_DEFAULT_DISABLED
>  static bool psi_enable;
> --
> 2.27.0
>