Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <208f05b3-ed92-5b22-6200-8bb28d62fd77@quicinc.com>
Date:   Thu, 25 May 2023 11:10:24 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [Freedreno] [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"
Content-Language: en-US
To:     Kuogee Hsieh <quic_khsieh@quicinc.com>,
        Leonard Lausen <leonard@lausen.nl>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        "Bjorn Andersson" <andersson@kernel.org>
CC:     <freedreno@lists.freedesktop.org>,
        Sankeerth Billakanti <quic_sbillaka@quicinc.com>,
        Bjorn Andersson <quic_bjorande@quicinc.com>,
        <regressions@lists.linux.dev>, David Airlie <airlied@gmail.com>,
        "Nikita Travkin" <nikita@trvn.ru>, <linux-kernel@vger.kernel.org>,
        <dri-devel@lists.freedesktop.org>, Rob Clark <robdclark@gmail.com>,
        "Daniel Vetter" <daniel@ffwll.ch>, <linux-arm-msm@vger.kernel.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Sean Paul <sean@poorly.run>,
        Johan Hovold <johan+linaro@kernel.org>
References: <e547edf4-1b48-5d12-1600-45f78e7cab49@quicinc.com>
 <1345a125-f745-4fe3-0f5e-bfe84225958d@quicinc.com>
 <b0cc40d5-6de1-91cc-e2cd-f47cc53551e4@quicinc.com>
 <ebbcd56ac883d3c3d3024d368fab63d26e02637a@lausen.nl>
 <20230508021536.txtamifw2vkfncnx@ripper>
 <3802269cd54ce105ef6dece03b1b9af575b4fa06@lausen.nl>
 <ad351c02-1c29-3601-53e8-f8cdeca2ac63@linaro.org>
 <49d175ec16e3f65a18265063e51092ee8d0d79c1@lausen.nl>
 <f2d1bb37-ea83-4d5d-6ef5-ae84c26d6ac1@quicinc.com>
 <b9c8243ed53c5c9d7c1b5711237f6130976ea99b@lausen.nl>
 <7deff127-4c6d-1f59-33a8-f44eea86bacd@quicinc.com>
From:   Abhinav Kumar <quic_abhinavk@quicinc.com>
In-Reply-To: <7deff127-4c6d-1f59-33a8-f44eea86bacd@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 5/25/2023 10:57 AM, Kuogee Hsieh wrote:
> 
> On 5/24/2023 5:58 AM, Leonard Lausen wrote:
>>>>>>>> [  275.025497] [drm:dpu_encoder_phys_vid_wait_for_commit_done:488]
>>>>>>>> [dpu error]vblank timeout
>>>>>>>> [  275.025514] [drm:dpu_kms_wait_for_commit_done:510] [dpu 
>>>>>>>> error]wait
>>>>>>>> for commit done returned -110
>>>>>>>> [  275.064141] [drm:dpu_encoder_frame_done_timeout:2382] [dpu
>>>>>>>> error]enc33 frame done timeout
>>>>>> This is a different crash but the root-cause of both the issues is 
>>>>>> the
>>>>>> bridge hpd_enable/disable series.
>>>>>>
>>>>>> https://patchwork.freedesktop.org/patch/514414/
>>>> Yes, the new patch to fix this issue is here
>>>>
>>>> https://patchwork.freedesktop.org/patch/538601/?series=118148&rev=3
>>>>
>>>> Apologies if you were not CCed on this, if a next version is CCed,
>>>> will ask kuogee to cc you.
>>>>
>>>> Meanwhile, will be great if you can verify if it works for you and
>>>> provide Tested-by tags.
>>> Hi Leonard,
>>>
>>> I had  cc you with v5 patches.
>>>
>>> Would you please verify it.
>> Hi Kuogee,
>>
>> thank you. Verified the v6 patch fixes the regression when ported to
>> 6.3.3. One non-fatal issue remains: Suspending and resuming the system
>> while USB-C DP monitor is connected triggers an error, though the system
>> recovers within a second without the need to unplug the cable.
>>
>> [drm:drm_mode_config_helper_resume] *ERROR* Failed to resume (-107)
>>
>>
>> dmesg snippet related to the suspend below
>>
>>
>> [  197.845110] usb 2-1.4.4: reset SuperSpeed USB device number 12 
>> using xhci-hcd
>> [  198.235191] [drm:drm_mode_config_helper_resume] *ERROR* Failed to 
>> resume (-107)
> 
> Hi Leonard,
> 
> I did not see this problem at my setup (Kodiak) during suspend/resume.
> 
> Will investigate more on Trogdor device.
> 
> Thanks,
> 

Hi Leonard

Feel free to open a bug for this and assign to me, we can check this and 
ask more info if needed on that bug.

Thanks

Abhinav

> 
>> [  198.528638] OOM killer enabled.
>> [  198.531866] Restarting tasks ...
>> [  198.531994] usb 1-1.4.4.1: USB disconnect, device number 27
>> [  198.532223] usb 1-1.4.3: USB disconnect, device number 23
>> [  198.532509] usb 1-1.4.2.1: USB disconnect, device number 29
>> [  198.534805] r8152-cfgselector 2-1.4.4.2: USB disconnect, device 
>> number 13
>> [  198.535444] done.
>> [  198.535536] usb 1-1.1: USB disconnect, device number 15
>> [  198.567811] random: crng reseeded on system resumption
>> [  198.583431] PM: suspend exit