Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230521160426.1881124-1-masahiroy@kernel.org> <20230521160426.1881124-17-masahiroy@kernel.org>
In-Reply-To: <20230521160426.1881124-17-masahiroy@kernel.org>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Thu, 25 May 2023 11:30:48 -0700
Message-ID: <CAKwvOd=aF19UauHr76tQNzn=Hzihv5TzaOw4Tj7HzYYgvMaFKw@mail.gmail.com>
Subject: Re: [PATCH v6 16/20] modpost: merge fromsec=DATA_SECTIONS entries in
 sectioncheck table
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        Nathan Chancellor <nathan@kernel.org>,
        Nicolas Schier <nicolas@fjasle.eu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, May 21, 2023 at 9:05=E2=80=AFAM Masahiro Yamada <masahiroy@kernel.o=
rg> wrote:
>
> You can merge these entries.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

> ---
>
>  scripts/mod/modpost.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 516323c3910a..aea9d6cd243d 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -884,12 +884,7 @@ static const struct sectioncheck sectioncheck[] =3D =
{
>  },
>  {
>         .fromsec =3D { DATA_SECTIONS, NULL },
> -       .bad_tosec =3D { ALL_XXXINIT_SECTIONS, NULL },
> -       .mismatch =3D DATA_TO_ANY_INIT,
> -},
> -{
> -       .fromsec =3D { DATA_SECTIONS, NULL },
> -       .bad_tosec =3D { INIT_SECTIONS, NULL },
> +       .bad_tosec =3D { ALL_XXXINIT_SECTIONS, INIT_SECTIONS, NULL },
>         .mismatch =3D DATA_TO_ANY_INIT,
>  },
>  {
> --
> 2.39.2
>


--=20
Thanks,
~Nick Desaulniers