Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <38e24fd4-9213-229d-9919-7ae3bfb113bb@intel.com>
Date:   Thu, 25 May 2023 12:05:42 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v2] x86/lib: Do not use local symbols with
 SYM_CODE_START_LOCAL()
Content-Language: en-US
To:     Nadav Amit <nadav.amit@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>
Cc:     Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Nadav Amit <namit@vmware.com>
References: <20230525184244.2311-1-namit@vmware.com>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <20230525184244.2311-1-namit@vmware.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/25/23 11:42, Nadav Amit wrote:
> From: Nadav Amit <namit@vmware.com>
> 
> When SYM_CODE_START_LOCAL() is used, the symbols are local but need to
> be preserved in the object. However, using the ".L" label prefix does
> not retain the symbol in the object.
> 
> It is beneficial to be able to map instruction pointers back to symbols,
> for instance for profiling. Otherwise, there are code addresses that do
> not map back to any symbol.  Consequently, the ".L" label prefix should
> not be used when SYM_CODE_START_LOCAL() is used.
> 
> Few symbols, such as .Lbad_put_user_clac and currently have both the
> SYM_CODE_START_LOCAL() invocation and the ".L" prefix.  This commit
> removes the ".L" prefix from these symbols.
> 
> No functional change, other then emitting these symbols into the object,
> is intended.

Nadav, could you perhaps do a bit of research on how this situation came
to be?  Was it an accident or on purpose that these symbols came to be
.L?  Then, could you CC the folks who made this change and ask them
directly if they intended to induce the effects that you find undesirable?