Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d63a3757-0f58-d125-b735-7fe86230bc9c@wanadoo.fr>
Date:   Thu, 25 May 2023 21:16:32 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v3] i2c: ocores: use devm_ managed clks
Content-Language: fr, en-US
To:     =?UTF-8?B?5byg572R?= <m202171703@hust.edu.cn>
Cc:     Peter Korsgaard <peter@korsgaard.com>,
        Andrew Lunn <andrew@lunn.ch>,
        hust-os-kernel-patches@googlegroups.com, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Dan Carpenter <dan.carpenter@linaro.org>
References: <5572a733.abc0.18846f13b0b.Coremail.m202171703@hust.edu.cn>
 <20230524154318.2259-1-silver_code@hust.edu.cn>
 <68c4b991-6af9-36e8-354c-7c3b232ba4c2@wanadoo.fr>
 <5cceb5b5.c1fe.18850f830e0.Coremail.m202171703@hust.edu.cn>
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <5cceb5b5.c1fe.18850f830e0.Coremail.m202171703@hust.edu.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 25/05/2023 à 05:33, 张网 a écrit :
> Hi  Christophe,
> 
> Thanks for your suggestions. However, both clk_get_rate and clk_prepare_enable
> will return 0 if i2c->clk is NULL, so I think we may not need to take this issue
> into account.
> 
> Regards,
> Wang Zhang
> 

Ouch!

For some reaon, when I read:
 > +	rate = clk_get_rate(i2c->clk) / 1000;

I read "if i2c->clk is NULL, then the i2c pointer is NULL as well and is 
dereferenced".

:/

sorry for the noise.

CJ (slightly ashamed)