Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e1e0895e-4c8d-6453-d098-972beb4d0255@linux.intel.com>
Date:   Thu, 25 May 2023 15:47:46 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCHv2 3/6] hwmon: (socfpga) Add hardware monitoring support on
 SoCFPGA platforms
To:     Armin Wolf <W_Armin@gmx.de>, linux-hwmon@vger.kernel.org
Cc:     dinguyen@kernel.org, devicetree@vger.kernel.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        linux-kernel@vger.kernel.org, jdelvare@suse.com,
        linux@roeck-us.net,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
References: <20230508212852.8413-1-dinh.nguyen@linux.intel.com>
 <20230508212852.8413-3-dinh.nguyen@linux.intel.com>
 <4aa37522-9072-ac8d-0ba7-c2234c3228bc@gmx.de>
Content-Language: en-US
From:   Dinh Nguyen <dinh.nguyen@linux.intel.com>
In-Reply-To: <4aa37522-9072-ac8d-0ba7-c2234c3228bc@gmx.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Armin,

On 5/8/2023 7:57 PM, Armin Wolf wrote:
> Am 08.05.23 um 23:28 schrieb dinh.nguyen@linux.intel.com:
>
>> From: Dinh Nguyen <dinh.nguyen@linux.intel.com>
>>
>> The driver supports 64-bit SoCFPGA platforms for temperature and voltage
>> reading using the platform's SDM(Secure Device Manager). The driver
>> also uses the Stratix10 Service layer driver.
>>
>> This driver only supports OF SoCFPGA 64-bit platforms.
>>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Signed-off-by: Dinh Nguyen <dinh.nguyen@linux.intel.com>
>> ---
>> v2: clean up race conditions in probe/remove functions
>>      move changes in service driver to a separate patch
>>      fix undefined 'ret' value in socfpga_read()
>>      fix up socfpga_hwmon_err_to_errno() to handle signed integer
>>      add platform specific dts binding
>> ---
>>   Documentation/hwmon/index.rst         |   1 +
>>   Documentation/hwmon/socfpga-hwmon.rst |  30 ++
>>   drivers/hwmon/Kconfig                 |  11 +
>>   drivers/hwmon/Makefile                |   1 +
>>   drivers/hwmon/socfpga-hwmon.c         | 408 ++++++++++++++++++++++++++
>>   5 files changed, 451 insertions(+)
>>   create mode 100644 Documentation/hwmon/socfpga-hwmon.rst
>>   create mode 100644 drivers/hwmon/socfpga-hwmon.c ICENSE("GPL");

Thanks for the review. I've addressed all of your comments in V3.

Dinh