Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <af7eab96-fc2b-0bbc-107c-35f83dc46022@amd.com>
Date:   Thu, 25 May 2023 17:10:09 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] drm/amdkfd: remove unused function
 get_reserved_sdma_queues_bitmap
To:     Tom Rix <trix@redhat.com>, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, nathan@kernel.org, ndesaulniers@google.com,
        "Joshi, Mukul" <Mukul.Joshi@amd.com>
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
References: <20230525200759.3214525-1-trix@redhat.com>
Content-Language: en-US
From:   Felix Kuehling <felix.kuehling@amd.com>
Organization: AMD Inc.
In-Reply-To: <20230525200759.3214525-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1JINWFRMWpROUkrS3E3aWlRSERVejVJdStLVU8rM3M1WlBIbTIvNjFHQ0Vh?=
 =?utf-8?B?Z3hHNXZGaFM2NE10UVZjZFBBeVlHdW1lNldJTTNOeDJQc3A0QWF3dlUyVDdQ?=
 =?utf-8?B?ZEJrUGZsTVoyUVpQYVhlcFY0Zkp0YzNNNjhMcWw1b3o3MG45REtqblRYckd6?=
 =?utf-8?B?Vys4V1dVdmlDRk5WYnRWRVIwVTZIcWQvNFZYM216OXJ5b0JhU1c2dzZFeU93?=
 =?utf-8?B?MUNpRU1FeEEvSzRlL0ZZYS9BL0NSZk9ZZWtnTzNEVUQ5Q1RJK1ZGelJuc3hp?=
 =?utf-8?B?enpjR1NQK05Ic0RjR29mYmtPdSs4ZjY4NmIzRGFwUm92VlAzVlFoR0FndVd4?=
 =?utf-8?B?RlNsY21zYVJLSEdOWDJQcTgvSktLMVJjNFg5TTcvV29SSVhVOEw3cTlSUjNK?=
 =?utf-8?B?d2dxSXpqVkZKMEFHcVRQdzBpK0hvOWM2Q2ZKMkFOb0tyL280RE1OTmlrL2V0?=
 =?utf-8?B?VmEyd29DRVlKaDVqeDVaa1hnRWU5RzZyY0dGZ1J5OTNqY3lIUGlCYzltZmJY?=
 =?utf-8?B?OE9tQzhCZU1oWnd2ZzYwVjUrbW9MLzh0ZUQwdDRhTTZNMlV6Zk9waVFwMVJJ?=
 =?utf-8?B?aUtDdWx0YU9oZVRxc0NFTnRzUThqTFJXd1Z5cElrK25UWGRxdGFwclR4cmkr?=
 =?utf-8?B?VlROQmpqSng0QmFjOTZEVHdrbHA5aXI4QUlXZndUZ1JnUW8rUk9udEZCa3Fy?=
 =?utf-8?B?b1lWcG10T2ZvTFl5WXd6WmIraHBEOVU5clFtNnhTMGpkZUNBMVhLdERHZ01k?=
 =?utf-8?B?Q29Zd0NySDNod3kzSElQdmFHcmlqS00yZFl4K2RkK3Jsdm5KNExFYlhnRDh5?=
 =?utf-8?B?REhiQ3lyZmQ5ekhScC81eXcrTzBZVXhxbmdoWDRqbTdNY1JrRlAyLzhqQXpu?=
 =?utf-8?B?NUtuQi9OWldjK0FLSjRPWnQzTTEvQXlwVC9qa1ZoeTNFSFBsdDFMZEZ0RHM1?=
 =?utf-8?B?WkV3OWx4enZoVnlOMWFKZTRpT2NNVEV4Z3IvRlAwcG1HT3BvSUVCajRtd3ps?=
 =?utf-8?B?SDJqY3BIKzFGd0ZiWExXNkNHamtRNXQxUDIvOGhLRTZGb2Z5Qk1FK1pRRGlI?=
 =?utf-8?B?UEI0UXcyalRVTlgyNmo4ZHVFdFF4MEVrRSswUjFQOXpoblcrbGRYbHQ5SHlQ?=
 =?utf-8?B?RVgxKzNrLy9zbGNVOC83cXc5RVF1NjB0K1FaL0oySHoybVMvaE1sRWYzOVpI?=
 =?utf-8?B?blZESlhtd2o3dnYwalk3N0RybFBiNkE1c3VMdWRTS0F3U2VRcFZ4WWxoWUpm?=
 =?utf-8?B?V2VYaDByQStrdmVzTHc5YnhHY2NiQnoxVEg4Q1BDSUNqemJKY0s0NWdWRitC?=
 =?utf-8?B?alk0T2pzZXp4SlRRK1NmUm9peWQyVDhZRHJzU1RKcFArZVNES1hHUzlxdVh6?=
 =?utf-8?B?LzNCQjNrNkJSK0kzRXlDYmpVNzl2UE9IbXJhMElKczc1RTlMN1I4NSsrQkJy?=
 =?utf-8?B?ME1rYis3UlFvUnIwQTJ0QzdDMDRVb3UrdmNjdW1uTDgrZ1lyTW9WTThDaVd6?=
 =?utf-8?B?OGoyRHB5bVNuZHFBa1Z0OW51MFhrL1c2VHY2bms2SVlZTzhab3JQUFdpek9t?=
 =?utf-8?B?bmsycHhDYnorTWhxbEx1aW00RXd3b1ltelN2NEw2VVZjdW1NdkJtbkR6SWJ6?=
 =?utf-8?B?dWRtRC9CS1NUeDFwejBFTHR3ZDA1dGJYd3NSVGZLQ0czeTA4c3F2MTFONDFO?=
 =?utf-8?B?ZjN4ajlzWTJlbVZuLzlTYTdDR1FZdWo3VnlwTmRUbGtkUjB1dEswWklKZjkx?=
 =?utf-8?B?MGUvdit6SnNaR1VQeCtmdkptYzl1d0FDd0tUcEJOaG1XZndiWG9VVk81dUZ3?=
 =?utf-8?B?dTEzV3BFVXdCc0NhN2JWa3h3Z3RvV3c5dGlZWjVsdXo5THJIalBaUDFpeWth?=
 =?utf-8?B?NzJjdTFUTmxnU0VzanRTZEs5MlFuM2VKcFEzcXdWZEp1ZnVkK3JkM1BWN1ZU?=
 =?utf-8?B?TE9XbENDZElSS0VYZmtjOHZkdm02TnNnODNLSzJlZVdBblpIZnVuaUlrcVhj?=
 =?utf-8?B?Y04yWEc3ZXY4QTdjV2lxd0s5NjBWaU9kcTJLcTVyQXlaUEdkTGlWaEdHQVJQ?=
 =?utf-8?B?eHIxY0crWGNKSGJYSnJvN2xUeVJpcVRZT05mZmNBU0Z4NlJndWJOL0RkeHNl?=
 =?utf-8?Q?keVMKUF/VaijCe8Lerd6wwSRF?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23c6b1c3-0339-4673-6f0b-08db5d646db8
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2023 21:10:12.4855
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 65+RxHWmUskL282OaMEdORB4crFeTRBWjoCT0LjU3/wrDmAFzd9XGiHfFfrEQjIjDSaVQ7b4l13IueF9m0opdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6060
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[+Mukul]

Looks like this problem was introduced by Mukul's patch "drm/amdkfd: 
Update SDMA queue management for GFX9.4.3". Could this be a merge error 
between GFX 9.4.3 and GFX11 branches? I think the 
reserved_sdma_queues_bitmap was introduced after the 9.4.3 branch was 
created. Mukul, you worked on both, so you're probably in the best 
position to resolve this.

Regards,
   Felix


On 2023-05-25 16:07, Tom Rix wrote:
> clang with W=1 reports
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device_queue_manager.c:122:24: error:
>    unused function 'get_reserved_sdma_queues_bitmap' [-Werror,-Wunused-function]
> static inline uint64_t get_reserved_sdma_queues_bitmap(struct device_queue_manager *dqm)
>                         ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> index 493b4b66f180..2fbd0a96424f 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -119,11 +119,6 @@ unsigned int get_num_xgmi_sdma_queues(struct device_queue_manager *dqm)
>   		dqm->dev->kfd->device_info.num_sdma_queues_per_engine;
>   }
>   
> -static inline uint64_t get_reserved_sdma_queues_bitmap(struct device_queue_manager *dqm)
> -{
> -	return dqm->dev->kfd->device_info.reserved_sdma_queues_bitmap;
> -}
> -
>   static void init_sdma_bitmaps(struct device_queue_manager *dqm)
>   {
>   	bitmap_zero(dqm->sdma_bitmap, KFD_MAX_SDMA_QUEUES);