Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b36bd5d9-a7dc-b478-9b89-ed3b10bd6725@linux.intel.com>
Date:   Thu, 25 May 2023 16:20:12 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCHv2 3/6] hwmon: (socfpga) Add hardware monitoring support on
 SoCFPGA platforms
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linux-hwmon@vger.kernel.org
Cc:     dinguyen@kernel.org, devicetree@vger.kernel.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        linux-kernel@vger.kernel.org, jdelvare@suse.com,
        linux@roeck-us.net,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
References: <20230508212852.8413-1-dinh.nguyen@linux.intel.com>
 <20230508212852.8413-3-dinh.nguyen@linux.intel.com>
 <9459547a-0ff9-9972-602d-3098b616602b@linaro.org>
From:   Dinh Nguyen <dinh.nguyen@linux.intel.com>
In-Reply-To: <9459547a-0ff9-9972-602d-3098b616602b@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Krzysztof,

On 5/9/2023 1:57 AM, Krzysztof Kozlowski wrote:
> On 08/05/2023 23:28, dinh.nguyen@linux.intel.com wrote:
>> From: Dinh Nguyen <dinh.nguyen@linux.intel.com>
>>
>> The driver supports 64-bit SoCFPGA platforms for temperature and voltage
>> reading using the platform's SDM(Secure Device Manager). The driver
>> also uses the Stratix10 Service layer driver.
>>
>> This driver only supports OF SoCFPGA 64-bit platforms.
>>
> (...)
>
>> +static int socfpga_probe_child_from_dt(struct device *dev,
>> +				       struct device_node *child,
>> +				       struct socfpga_hwmon_priv *priv)
>> +{
>> +	struct device_node *grandchild;
>> +	const char *label;
>> +	const char *type;
>> +	u32 val;
>> +	int ret;
>> +
>> +	if (of_property_read_string(child, "name", &type))
>> +		return dev_err_probe(dev, -EINVAL, "No type for %pOF\n", child);
>> +
>> +	for_each_child_of_node(child, grandchild) {
>> +		ret = of_property_read_u32(grandchild, "reg", &val);
>> +		if (ret)
>> +			return dev_err_probe(dev, ret, "missing reg property of %pOF\n",
>> +					     grandchild);
> Where do you drop child reference?

Not sure what you mean here? Can you clarify?

Thanks,

Dinh