Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1739034rwd; Thu, 25 May 2023 17:56:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6lHKJ3O3DF3/AGVaRdv6Mvq0nriTNcuIvn8ENLxFkQ4YZXaVFbdsdPC2sa19Rsgv6hiRvy X-Received: by 2002:a17:902:d512:b0:1a9:80a0:47ef with SMTP id b18-20020a170902d51200b001a980a047efmr4390546plg.20.1685062566947; Thu, 25 May 2023 17:56:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685062566; cv=none; d=google.com; s=arc-20160816; b=ypnZ+GvTRDoTIeocyld+dOcsVoy1NiMstPXCME60hTn+3YG6EIfKp9xfkbhy+dpRie l24VHJXoceN7GUtCU+TVDPYrqJJU0etC+1AtdgrBE5GblhSbG66B6vZQbQLHae7NQxXS mb1yRga3PP3chDkzjeoAJemUhF2PEyeK3YqJL4+O8Hr5GPlqykBmlajWPIbzdHrdraM4 fdZRk1fvV6zwjKL8YsxaiHWDtgmjReBsWwmNfpdDV2TIY0JT3qzCUizTCQRtpCeG5RCa 6lVjmjk/Sd/d3M2GzUkLpQUyiUbLp/myzHMm8ZFmEoVK30IdZn9HDE04XTDnI+yV9ls1 0+lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=lADgijYxOAGlajTx6faEQYwgRpQN4Isftb78tpF1Xrk=; b=vn22MQTw2gMF3We9c3n8RTaNyoB7UUTy9tJlXatLozbhkPV5xw+hTTx0jvTMoqHdCy K3ZUD62RseEdTnto5gY+AqpYg/4GCR+Ri/8dy/ZyrcE7FeaIZuOgqpvrGCnbkC2DyS9/ 4ty2FEv1vNBQ6nkkS6+bnpoN0x3ea2tWwL2GKQoHUYwCGBpo9wMU2NLTbE98MGC5DDMY Cqj0b2wwiiFpVDosJ6Lws8OeUDxHQoLzUPzldOTGLsO52PkBcChbUtv4K9TorM8wqDZE ECqwTHSUYe/uFIsDfLhyc5DnTrjgXH3OU2HijTfcKG116G+9FIPmfpcgHRqL96TROnI6 owbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=X9p955qc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jj5-20020a170903048500b001ae4026d82bsi2597981plb.12.2023.05.25.17.55.52; Thu, 25 May 2023 17:56:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=X9p955qc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234071AbjEZAm4 (ORCPT + 99 others); Thu, 25 May 2023 20:42:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229832AbjEZAmy (ORCPT ); Thu, 25 May 2023 20:42:54 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAE6512E; Thu, 25 May 2023 17:42:53 -0700 (PDT) Received: from [192.168.2.2] (109-252-147-95.dynamic.spd-mgts.ru [109.252.147.95]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id E80A466056D7; Fri, 26 May 2023 01:42:50 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1685061772; bh=b7KTbM4WhfYXB/uJQOVCQcF+/n4UsmItxYts7ak+544=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=X9p955qco/4LsnrR3Fs9iBBQ6k5LF4ildGWZENBsZXu7Beb5V7+FxMT/CrwVYPME9 oPadLycKEEy3ZrbSqSqYEhnaYEnJT61A49IhMckbd0qrO6NCc0r1CB/rdvBbFcNRj1 Qw26UXPNiRkzkKaoKikk76Y8Zhy0GoHC9x/cX5ju6UZ4YCq/+nuoF+rldkSK/PQEvA SCwzyj/kA3M+N3OgjLSZ2o60bi6dyk7PPG8NPwBPkl3+8h1su6sL90EhEuOGbKcK1j rDOj7viXyrovhz1l+tmnsD4MkxXOas9L7mrz6t+TMyEj/6LS3YCE8JZNKGF7ARTKxN H3Now5JbFoTKw== Message-ID: Date: Fri, 26 May 2023 03:42:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 3/8] iio: adc: rockchip_saradc: Make use of devm_clk_get_enabled Content-Language: en-US To: Shreeya Patel , jic23@kernel.org, lars@metafoo.de, heiko@sntech.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, sebastian.reichel@collabora.com Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, gustavo.padovan@collabora.com, serge.broslavsky@collabora.com References: <20230525212712.255406-1-shreeya.patel@collabora.com> <20230525212712.255406-4-shreeya.patel@collabora.com> From: Dmitry Osipenko In-Reply-To: <20230525212712.255406-4-shreeya.patel@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/26/23 00:27, Shreeya Patel wrote: > @@ -600,8 +560,6 @@ static int rockchip_saradc_suspend(struct device *dev) > struct iio_dev *indio_dev = dev_get_drvdata(dev); > struct rockchip_saradc *info = iio_priv(indio_dev); > > - clk_disable_unprepare(info->clk); > - clk_disable_unprepare(info->pclk); > regulator_disable(info->vref); Why clocks need to be enabled during suspend? -- Best regards, Dmitry