Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230525071133.2066610-1-irogers@google.com> <20230525071133.2066610-2-irogers@google.com>
 <CAM9d7cgaSPbnjoA6bv8fwkpoyc6nCdXOOrbmBm_jGbZbm3a_4w@mail.gmail.com>
In-Reply-To: <CAM9d7cgaSPbnjoA6bv8fwkpoyc6nCdXOOrbmBm_jGbZbm3a_4w@mail.gmail.com>
From:   Ian Rogers <irogers@google.com>
Date:   Thu, 25 May 2023 19:38:57 -0700
Message-ID: <CAP-5=fX0BnzQacr1NRQfis42osk07BuKJ9BqNTf7pGBMoj4ORA@mail.gmail.com>
Subject: Re: [PATCH v1 01/16] perf header: Make nodes dynamic in write_mem_topology
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
        "Steven Rostedt (Google)" <rostedt@goodmis.org>,
        Ross Zwisler <zwisler@chromium.org>,
        Leo Yan <leo.yan@linaro.org>,
        Tiezhu Yang <yangtiezhu@loongson.cn>,
        Yang Jihong <yangjihong1@huawei.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Ravi Bangoria <ravi.bangoria@amd.com>,
        Sean Christopherson <seanjc@google.com>,
        K Prateek Nayak <kprateek.nayak@amd.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, May 25, 2023 at 12:15=E2=80=AFPM Namhyung Kim <namhyung@kernel.org>=
 wrote:
>
> On Thu, May 25, 2023 at 12:12=E2=80=AFAM Ian Rogers <irogers@google.com> =
wrote:
> >
> > Avoid a large static array, dynamically allocate the nodes avoiding a
> > hard coded limited as well.
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> >  tools/perf/util/header.c | 33 +++++++++++++++++++++------------
> >  1 file changed, 21 insertions(+), 12 deletions(-)
> >
> > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> > index 2dde3ca20de5..80593ed8c79b 100644
> > --- a/tools/perf/util/header.c
> > +++ b/tools/perf/util/header.c
> > @@ -24,6 +24,7 @@
> >  #include <bpf/libbpf.h>
> >  #endif
> >  #include <perf/cpumap.h>
> > +#include <tools/libc_compat.h> // reallocarray
> >
> >  #include "dso.h"
> >  #include "evlist.h"
> > @@ -1396,13 +1397,14 @@ static int memory_node__sort(const void *a, con=
st void *b)
> >         return na->node - nb->node;
> >  }
> >
> > -static int build_mem_topology(struct memory_node *nodes, u64 size, u64=
 *cntp)
> > +static int build_mem_topology(struct memory_node **nodesp, u64 *cntp)
> >  {
> >         char path[PATH_MAX];
> >         struct dirent *ent;
> >         DIR *dir;
> > -       u64 cnt =3D 0;
> >         int ret =3D 0;
> > +       size_t cnt =3D 0, size =3D 0;
> > +       struct memory_node *nodes =3D NULL;
> >
> >         scnprintf(path, PATH_MAX, "%s/devices/system/node/",
> >                   sysfs__mountpoint());
> > @@ -1426,16 +1428,24 @@ static int build_mem_topology(struct memory_nod=
e *nodes, u64 size, u64 *cntp)
> >                 if (r !=3D 1)
> >                         continue;
> >
> > -               if (WARN_ONCE(cnt >=3D size,
> > -                       "failed to write MEM_TOPOLOGY, way too many nod=
es\n")) {
> > -                       closedir(dir);
> > -                       return -1;
> > -               }
> > +               if (cnt >=3D size) {
> > +                       struct memory_node *new_nodes =3D
> > +                               reallocarray(nodes, cnt + 4, sizeof(*no=
des));
> >
> > +                       if (!new_nodes) {
> > +                               pr_err("Failed to write MEM_TOPOLOGY, s=
ize %zd nodes\n", size);
> > +                               free(nodes);
> > +                               closedir(dir);
> > +                               return -ENOMEM;
> > +                       }
> > +                       nodes =3D new_nodes;
> > +                       size +=3D 4;
> > +               }
> >                 ret =3D memory_node__read(&nodes[cnt++], idx);
>
> I think you need to handle error cases here.
>
> Thanks,
> Namhyung

Not sure I follow. The reallocarray tests for failure, frees nodes and
returns -ENOMEM on error.

Thanks,
Ian

>
> >         }
> >
> >         *cntp =3D cnt;
> > +       *nodesp =3D nodes;
> >         closedir(dir);
> >
> >         if (!ret)
> > @@ -1444,8 +1454,6 @@ static int build_mem_topology(struct memory_node =
*nodes, u64 size, u64 *cntp)
> >         return ret;
> >  }
> >
> > -#define MAX_MEMORY_NODES 2000
> > -
> >  /*
> >   * The MEM_TOPOLOGY holds physical memory map for every
> >   * node in system. The format of data is as follows:
> > @@ -1464,8 +1472,8 @@ static int build_mem_topology(struct memory_node =
*nodes, u64 size, u64 *cntp)
> >  static int write_mem_topology(struct feat_fd *ff __maybe_unused,
> >                               struct evlist *evlist __maybe_unused)
> >  {
> > -       static struct memory_node nodes[MAX_MEMORY_NODES];
> > -       u64 bsize, version =3D 1, i, nr;
> > +       struct memory_node *nodes =3D NULL;
> > +       u64 bsize, version =3D 1, i, nr =3D 0;
> >         int ret;
> >
> >         ret =3D sysfs__read_xll("devices/system/memory/block_size_bytes=
",
> > @@ -1473,7 +1481,7 @@ static int write_mem_topology(struct feat_fd *ff =
__maybe_unused,
> >         if (ret)
> >                 return ret;
> >
> > -       ret =3D build_mem_topology(&nodes[0], MAX_MEMORY_NODES, &nr);
> > +       ret =3D build_mem_topology(&nodes, &nr);
> >         if (ret)
> >                 return ret;
> >
> > @@ -1508,6 +1516,7 @@ static int write_mem_topology(struct feat_fd *ff =
__maybe_unused,
> >         }
> >
> >  out:
> > +       free(nodes);
> >         return ret;
> >  }
> >
> > --
> > 2.40.1.698.g37aff9b760-goog
> >