Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 26 May 2023 15:23:47 +0800
From:   Yujie Liu <yujie.liu@intel.com>
To:     "Paul E. McKenney" <paulmck@kernel.org>
CC:     kernel test robot <lkp@intel.com>, <llvm@lists.linux.dev>,
        <oe-kbuild-all@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [paulmck-rcu:rcu/next 19/19] kernel/rcu/rcuscale.c:340:20:
 error: use of undeclared identifier 'get_rcu_tasks_trace_gp_kthread'; did
 you mean 'show_rcu_tasks_trace_gp_kthread'?
Message-ID: <ZHBeg7SyMQnWJ5Gd@yujie-X299>
References: <202305190259.Rm6JC6Nz-lkp@intel.com>
 <e51237d6-5b10-424d-a0d3-afe8ee24f530@paulmck-laptop>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <e51237d6-5b10-424d-a0d3-afe8ee24f530@paulmck-laptop>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GRsRuWN2kVDYqRlC70AosDt+tQg+h7MRuChU7AzCmWsH3swmNEYUG7YLnY36?=
 =?us-ascii?Q?pl0MKuD3VDSE5X9dFNZwhzd85i1v2s7dPGoryTdPH5Lvec+r3QK/WFSP+0Ss?=
 =?us-ascii?Q?r5a2EZ7+aNrX8EQfslrKp8P2k2IgQ8lR+KBCC6218V1vJk+fUECpyQk9u39Z?=
 =?us-ascii?Q?5yfjg7R/7jYXEWdYF9W/OrwbMVV3wgjNDiucPPeC/i5F7Je6lPZTEt0L/HwS?=
 =?us-ascii?Q?84EMJcJefJmpLw8vACDBoV9kG9GOWZeV0cn7daC+0kgpJVTS784bpFyOJ2vx?=
 =?us-ascii?Q?oWpvSkXNVgcwkF7yVyRwJ0oChpBExjUqsknAglpLkjkbFVFynIM1axHj7ixe?=
 =?us-ascii?Q?Mnj2tsoEfZ5oyOfhEVcqmfl35yt3g4yKH0XUH4hvwxfDHFq80y7UGBGG9NKk?=
 =?us-ascii?Q?nmUx8VFXiG4lATjfDGin5WttVtBXqKm9JrSMB384VE80zwlp5ZKy98Hi8XEk?=
 =?us-ascii?Q?TLBfo+I21/dKBfdvBwmuTruIEHwor3m396UDE1hwgd7cvBYxagvmbEegs8Il?=
 =?us-ascii?Q?buwM33lcyxBCYs4N6Ot3BRB/mN5wjXlMx62aoS96P24Lh7uBsBNBXR67vlAB?=
 =?us-ascii?Q?0W92fwc1cu0CFToRyuvGi3tFgVmpasUp11fPvfJ00+Iq+dDMtqWebEnfQRf7?=
 =?us-ascii?Q?StlLCScwrNPdoHXts7h4/wrZ+oxJ1LGygBZ305jVBlx9gkhhmd3Tl6JXPHrN?=
 =?us-ascii?Q?OqKMjADXDgLZWGqM7G1+kGoLEg06oBdMqQfp1kdVtyWyFEXalqxC7MhYp8wD?=
 =?us-ascii?Q?5iepht+Cosia0paJoEr7VS833bqPRDPXONT1P3YH8N+IKBAXKw16nULZ5VtE?=
 =?us-ascii?Q?LWGBZ/+OQHtj6itmdgyBiON3eVp+2LvupJwAbYUgUH5rPPa4eeuONw9N9iQz?=
 =?us-ascii?Q?IGnW3v1GR8C/mlQAG/TpmGMaRxlcx6UVHLMAWk1lWdmWnFMHkNnKh9uvK9wC?=
 =?us-ascii?Q?H8jWynQrzxZnamTX8NX+92mxjQ0wflrn8dyya+1aAo66q1wtTGcl7HHmpdKv?=
 =?us-ascii?Q?59zU1pHTVZPkWYTtlXFu8IQzQiYcXARJd3YOpzQyq5u0+6lwvOYyWlbDTDII?=
 =?us-ascii?Q?naxLdVlqbeWVHrqynWaeQKTkUVOBbf4NFGuF3sf3ERJp8/nAu1OrP0N7oQTg?=
 =?us-ascii?Q?SI3nvjPoduEmZkdY8YydMfwdH5y8+Pha4D+sugq9BgYpEaPD7SqXncRgIa8P?=
 =?us-ascii?Q?gEPMQgYkx1vX4ASwgPx53HWRnwmvosCsk2WvQSTzdOVC62yhUdO9/gbTlmDe?=
 =?us-ascii?Q?/NZZmFhrSS86Wq8Sje/e1ccwvaIiOuGWe9jFuRV4etndAFbvW5mFrlcvnjcc?=
 =?us-ascii?Q?nyP805/5mj0t1NeLM3g1KcDgzls9D7MPLhIhsPBB+6xBaskNer1IQRwvWPzk?=
 =?us-ascii?Q?idvGwk1WLXDCRBTsPjxKDPrGml3qvwsoUkhkHi+RfcElbvTI2aI8iJ6cRNvp?=
 =?us-ascii?Q?gjdezTpWnzri3LuOMPW6/SByx5Grn2+RqrydxBo1UbmvR5JSHojTFaRCEO00?=
 =?us-ascii?Q?6ldnSlE7Ofmjv5YwcLIaYlIQBcx/qYtBd4LU1QfNPv99tc+pdzaLMkX1OWBO?=
 =?us-ascii?Q?epbEBt7ni9TBEhiOArVyD9unrBCuFjtso7wiiN4H?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f4e3ed69-296c-4646-6150-08db5dba9861
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2023 07:27:00.8256
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FdT+V+hn0zLgzLGghSPU/q2jpBsPqomeYAV5BODpe4iYx2cbD8nvqTrV6UkZs/JESikAQnVhaL36f5u2mV818Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7272
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Paul,

On Thu, May 18, 2023 at 07:11:33PM -0700, Paul E. McKenney wrote:
> On Fri, May 19, 2023 at 02:30:11AM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next
> > head:   9bb839a83e1bbbfd4f7f20827aafd0a39fad00c7
> > commit: 9bb839a83e1bbbfd4f7f20827aafd0a39fad00c7 [19/19] rcuscale: Measure grace-period kthread CPU time
> > config: x86_64-randconfig-a001
> > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/commit/?id=9bb839a83e1bbbfd4f7f20827aafd0a39fad00c7
> >         git remote add paulmck-rcu https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
> >         git fetch --no-tags paulmck-rcu rcu/next
> >         git checkout 9bb839a83e1bbbfd4f7f20827aafd0a39fad00c7
> >         # save the config file
> >         mkdir build_dir && cp config build_dir/.config
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash kernel/rcu/
> > 
> > If you fix the issue, kindly add following tag where applicable
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202305190259.Rm6JC6Nz-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>):
> > 
> > >> kernel/rcu/rcuscale.c:340:20: error: use of undeclared identifier 'get_rcu_tasks_trace_gp_kthread'; did you mean 'show_rcu_tasks_trace_gp_kthread'?
> >            .rso_gp_kthread = get_rcu_tasks_trace_gp_kthread,
> >                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >                              show_rcu_tasks_trace_gp_kthread
> >    kernel/rcu/rcu.h:642:20: note: 'show_rcu_tasks_trace_gp_kthread' declared here
> >    static inline void show_rcu_tasks_trace_gp_kthread(void) {}
> >                       ^
> > >> kernel/rcu/rcuscale.c:340:20: error: incompatible function pointer types initializing 'struct task_struct *(*)(void)' with an expression of type 'void (void)' [-Werror,-Wincompatible-function-pointer-types]
> >            .rso_gp_kthread = get_rcu_tasks_trace_gp_kthread,
> >                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >    2 errors generated.
> 
> Apologies for the hassle!  Does the diff below help at your end?

Sorry for the late reply. We noticed that rcu/next branch was respined
and the diff below has been applied. We tested the new head commit
60901dadfadc ("rcuscale: Measure grace-period kthread CPU time")
and the build error is gone. Thanks.

Tested-by: Yujie Liu <yujie.liu@intel.com>

> 
> 						Thaxn, Paul
> 
> ------------------------------------------------------------------------
> 
> diff --git a/include/linux/rcupdate_trace.h b/include/linux/rcupdate_trace.h
> index 3a5a322939b6..eda493200663 100644
> --- a/include/linux/rcupdate_trace.h
> +++ b/include/linux/rcupdate_trace.h
> @@ -87,9 +87,7 @@ static inline void rcu_read_unlock_trace(void)
>  void call_rcu_tasks_trace(struct rcu_head *rhp, rcu_callback_t func);
>  void synchronize_rcu_tasks_trace(void);
>  void rcu_barrier_tasks_trace(void);
> -# ifdef CONFIG_RCU_SCALE_TEST
>  struct task_struct *get_rcu_tasks_trace_gp_kthread(void);
> -# endif
>  #else
>  /*
>   * The BPF JIT forms these addresses even when it doesn't call these
>