Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2084510rwd; Fri, 26 May 2023 01:12:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5CTnaJtSsuXgq8Y3Cv47ursgiyHgWFHWqKDLZzltBxiqAnL+7Y+Ew/Ui27p1fXaF1MYAR5 X-Received: by 2002:a05:6a20:7486:b0:10a:f5ca:153d with SMTP id p6-20020a056a20748600b0010af5ca153dmr1333340pzd.41.1685088760886; Fri, 26 May 2023 01:12:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685088760; cv=none; d=google.com; s=arc-20160816; b=GohKCHxws5dO+GwJb2iPkIss/oB0p9H1H0ZPaX83Gx6yYWYXlAimsV+hm63xO+AI0Z 4XZ/JT8kaYK5pmvUgYikPx1T0TJtYkgMMruAtzcazCxyRu3YWux5MZMvMFBZJP1VTR19 t8T7Bu2FI+tyBiGPKigkSF76K+umBejcpejdGCTwGYDj50TbnVqPDiwuPcjhosCKiDJH ydvgre5gn4rmQ6AX83Qvhx215WRLPa2kWUgo7PDnhbeSDpWuKL4lrjbzIRhzZXy51f/Q 63aL57zHu29R2SMEvhpjJ9xLA6/007tiVE2sCmvBtjOf5y9DIR/n3Awb7z4fYhhJYuBF MUGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Wrp/p2JlYlr1a42eE9mpYkhzTkjQuCT4cr2Pi5Zpf5g=; b=Gj8z0EwfuwcIoETItU5PlqcmDSVCD7gYmj0uC7LCFiIIcq3ahvvYcrgYNCSGL7NpFo IKBoMVx/3j5ICZDxkwz92cKTvlFT0yYdClbUV3KvkC8Mg8xlaGa/jVCTjUbOF7oe1rcC q3B9P/jlUKqfqSZjYHadkohABfE9fuQc5JknlFLWz/+g+BSuwI0F66HCDWNJvPN9Z5rz WRFqN54Le44htxwWXshteIZNb4LV8FyhpWCNIbLaHKXziZkYCRnbt0SL0HQACaQAVZBN VtWuY861Ueh8IFCpzmYRzS33Zmp36725+Y9f0DcSzjGBTcAIgYhkJ8a01X9ExuOeFqDd boPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p190-20020a625bc7000000b00643a50dd697si2523508pfb.265.2023.05.26.01.12.29; Fri, 26 May 2023 01:12:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236721AbjEZH7A (ORCPT + 99 others); Fri, 26 May 2023 03:59:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242018AbjEZH64 (ORCPT ); Fri, 26 May 2023 03:58:56 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9D7AE66 for ; Fri, 26 May 2023 00:58:32 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id B2A4268D09; Fri, 26 May 2023 09:57:46 +0200 (CEST) Date: Fri, 26 May 2023 09:57:46 +0200 From: Christoph Hellwig To: "min15.li" Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: fix miss command type check Message-ID: <20230526075746.GE16072@lst.de> References: <20230526110434.17036-1-min15.li@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230526110434.17036-1-min15.li@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + if (!ns) { Instead of all the extra indentation just return early here if ns is set.