Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2104945rwd; Fri, 26 May 2023 01:35:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6deVNGHBF9N4MOhCuJNwmcUoZk2zi5TrdqvwHflz+9jKeqzoipIrc+ob1feHtQb0EqFy9D X-Received: by 2002:a17:903:1209:b0:1ac:b363:83a6 with SMTP id l9-20020a170903120900b001acb36383a6mr2019806plh.17.1685090131210; Fri, 26 May 2023 01:35:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685090131; cv=none; d=google.com; s=arc-20160816; b=zHa3UlMzXnHzYNlrR+BSm/SWIgE+Qd31Sf4Pbp2citMBBjgIYPG3ix4T4K8x50jdhf K9q07qJPZE2pWXqQC6qBKBBGcCLWMreN35hjk1JUbiLj2y55vRePYZeYkcKIcUPwD0Sh g/MAdCvW9yGOyJ6t5c5gROq/TIq+6MjgmUAU8OPRnTNpvNl9kdXnQIkgPAjfvZ211mtB BBItwRbr2rwM147OX+iYyRsr7NmgSwXEQ1Ku/v95s2B5UyG25ba6dIHMDHsmX8CWQ7Ix cBB53x/j5Hfwz5lBk2zsI2nWcIQIgZM/BiXdGRybXGiKSZMalTVD7sc5j3rd+4PkPF4X Xdgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=prrh+Vu8nZehcp2nu1mWJdpU7JobgL09F7dm++keKyY=; b=gQtA+1yBH0B9cenEfwYVM86m3lt4vw3SJjDNAXuO8kLUsQZcOnm6ehRU9wpW33VdgE 71M0jiz8NJTIxH9+efuhQbF62pCcYjZQCjigLyE1fx/9Ix5IRmTdFDBrS/ejIXqUsIb5 EQovKVXkWXVpWD9pN3dgvskY/KqJIWnNxg9ukuOHOtk7UWmgqFtl1U67Aa8z6cVv60bN 7Isza4jsdjN5EqaE9iPK4RyubEWL7bqyhS/RxyXu0fQSYwGk6fKGvb9UltcRXVK5qcB5 GEYCjx8cuj/kP4yvK9Mc56iSUaD3SjP5jOVpEcd/eON8Z50iFeUyIlMDnKRbxeDvxrmo LqGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=umJlhCfP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w10-20020a1709029a8a00b001adb9d3bf5bsi246279plp.372.2023.05.26.01.35.18; Fri, 26 May 2023 01:35:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=umJlhCfP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242610AbjEZIXJ (ORCPT + 99 others); Fri, 26 May 2023 04:23:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242221AbjEZIXG (ORCPT ); Fri, 26 May 2023 04:23:06 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF262FB; Fri, 26 May 2023 01:23:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=prrh+Vu8nZehcp2nu1mWJdpU7JobgL09F7dm++keKyY=; b=umJlhCfPvB0nzbxm6ULM/0LnjH oyH9rE6v2h2WrBu1/kmbwIMuqiJ0zfzxtbVHpaDRXW2zgaIpjI9v8Ye7FAEef53vR6XqbEizHzClG q7840vr8smS/71lIbGsg/TxXmerP0FeUxx1Lv61qjxzvXnXdSztqLvix+Oz2u6xd8Hf42/cmR29J7 dHGKm6IJmYeDg6M4DDL+rML6LdIDMRtExJUx8pE+8k0380bLI1yD4Oak4EHIyaG/bmKuRkQK3BUV7 sC0eM0ZDHAwRuThs1EwByrXR7i9N4AC3xn6QXp9rCCynFxvkNbTGqejKiCH3KAb8YytnywAxqowQV 2dh8Y51Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q2Sis-001ajq-1w; Fri, 26 May 2023 08:22:54 +0000 Date: Fri, 26 May 2023 01:22:54 -0700 From: Christoph Hellwig To: David Howells Cc: Christoph Hellwig , David Hildenbrand , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton Subject: Re: [RFC PATCH v2 1/3] mm: Don't pin ZERO_PAGE in pin_user_pages() Message-ID: References: <20230525223953.225496-1-dhowells@redhat.com> <20230525223953.225496-2-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230525223953.225496-2-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Shouldn't unpin_user_pages and bio_release_page also be updated to skip a zero page here?