Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b8a3e7f0-d227-117f-443b-0f6b193e792b@linaro.org>
Date:   Fri, 26 May 2023 10:21:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
From:   Neil Armstrong <neil.armstrong@linaro.org>
Reply-To: neil.armstrong@linaro.org
Subject: Re: [PATCH] Revert "dt-bindings: bridge: samsung-dsim: Make some
 flags optional"
Content-Language: en-US
To:     Conor Dooley <conor.dooley@microchip.com>
Cc:     Inki Dae <inki.dae@samsung.com>,
        Jagan Teki <jagan@amarulasolutions.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Robert Foss <rfoss@kernel.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230526-revert-bad-binding-v1-1-67329ad1bd80@linaro.org>
 <20230526-oppressor-cabbie-fd5332dbc2cc@wendy>
Organization: Linaro Developer Services
In-Reply-To: <20230526-oppressor-cabbie-fd5332dbc2cc@wendy>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 26/05/2023 10:02, Conor Dooley wrote:
> On Fri, May 26, 2023 at 09:27:16AM +0200, Neil Armstrong wrote:
>> This reverts commit cfaf76d349837f695c8aa6d7077847fec4231fe5 which was applied
>> without review due to a bad tool manipulation.
> 
> Is it a dt-binding maintainer review that you are missing on that
> patch?

Exact

> 
> For this one:
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks, I'll apply this revert now and wait until the original
bindings patch gets properly reviewed.

Thanks,
Neil

> 
> Thanks,
> Conor.
> 
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>>   .../devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml    | 9 ++++-----
>>   1 file changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
>> index 360fea81f4b6..9f61ebdfefa8 100644
>> --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
>> +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
>> @@ -70,9 +70,7 @@ properties:
>>     samsung,burst-clock-frequency:
>>       $ref: /schemas/types.yaml#/definitions/uint32
>>       description:
>> -      DSIM high speed burst mode frequency when connected to devices
>> -      that support burst mode. If absent, the driver will use the pixel
>> -      clock from the attached device or bridge.
>> +      DSIM high speed burst mode frequency.
>>   
>>     samsung,esc-clock-frequency:
>>       $ref: /schemas/types.yaml#/definitions/uint32
>> @@ -82,8 +80,7 @@ properties:
>>     samsung,pll-clock-frequency:
>>       $ref: /schemas/types.yaml#/definitions/uint32
>>       description:
>> -      DSIM oscillator clock frequency. If absent, the driver will
>> -      use the clock frequency of sclk_mipi.
>> +      DSIM oscillator clock frequency.
>>   
>>     phys:
>>       maxItems: 1
>> @@ -137,7 +134,9 @@ required:
>>     - compatible
>>     - interrupts
>>     - reg
>> +  - samsung,burst-clock-frequency
>>     - samsung,esc-clock-frequency
>> +  - samsung,pll-clock-frequency
>>   
>>   allOf:
>>     - $ref: ../dsi-controller.yaml#
>>
>> ---
>> base-commit: cfaf76d349837f695c8aa6d7077847fec4231fe5
>> change-id: 20230526-revert-bad-binding-f77a3ca96419
>>
>> Best regards,
>> -- 
>> Neil Armstrong <neil.armstrong@linaro.org>
>>