Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2112199rwd; Fri, 26 May 2023 01:44:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7f4v/yYAECrHvVbDdxRkoYpMj3Il4jxGmktCZkYmFxUkdXUGuFE6BdfCaP/3LuMl4SHF6C X-Received: by 2002:a17:902:dac8:b0:1ab:28b4:6d5 with SMTP id q8-20020a170902dac800b001ab28b406d5mr4736167plx.5.1685090665367; Fri, 26 May 2023 01:44:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685090665; cv=none; d=google.com; s=arc-20160816; b=Pi3HHjxOsYjP2k+tMcg0ZNAfMRgRU6wjuTSdiOsYEFkwEntabkuldIbFnP5UywpHFd fyo5dSrcMZcu50ufPX9kTDP6727qhC+XtdwYbBG5Ztqfq6RRgoBBvKO6PVGrRdUM5WV8 2wYFBLAoquesLDcQS1KurykzafVFf/tIqJeMeoDTb3FFVFTjv9WNTBT/MLYouWroOlji uAZ/YkjM4VlgaxJDAOyDjh+0Hmkjgr66zexqHRi6X34gqrfd2IRtekJWJOnc2sGcI4pv KCc0UyTsABmCkv86jDKyHFb6dkzDorMUyFePvz8vuoo3L5cdmQZCN8CeFf8812CSkXXM 2Iig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=a1+k8geEgB3EI42+JJ+lx1nGKMJgJ9cIZX0cMtf11v8=; b=nJks6IA+4YJ0RYYraerjcz/g7MfQTPg32gUVRFt76S5B49aTTZXUO5+Rz/DTJizdId ho2z1eUUMNjK+IK5rVOVtbRgD9xUjRLKTMdNalVeGN4TbzNqyvG0NAT/I66JoUoevoDb rPUiCqGgVGAm7//TvC4W8uHH82nIy5o+zmwlNNa57e0eu/yVv3XcSU3J0Y7Dkn+sKXvR WOZVJ2oItM1Pfb7ow2fyl+ZkoF5awjrq9x9OutYSapmSuki8vbRwcQ2hQOvUPElO+/JR j1qK48XlgaAEznPGJsy+ulDzFiyTcgcWvzMZoLBivrXSxUBq+NCRqj3/3xYU797rP6YE RKgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=YmHfcSlC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b15-20020a170903228f00b001ac9a3ebb38si3687789plh.360.2023.05.26.01.44.13; Fri, 26 May 2023 01:44:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=YmHfcSlC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242721AbjEZIeV (ORCPT + 99 others); Fri, 26 May 2023 04:34:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236850AbjEZIeT (ORCPT ); Fri, 26 May 2023 04:34:19 -0400 Received: from out-40.mta0.migadu.com (out-40.mta0.migadu.com [IPv6:2001:41d0:1004:224b::28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32BDB128 for ; Fri, 26 May 2023 01:34:18 -0700 (PDT) Date: Fri, 26 May 2023 04:34:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1685090056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a1+k8geEgB3EI42+JJ+lx1nGKMJgJ9cIZX0cMtf11v8=; b=YmHfcSlC6Hj1py8HMz8oTzzq+ZfEqeBn9Pz/Ed/IQtvrF6RfexPzvh/A/8AYkicbAz78LB o9z8e2ts1pjbylZmZNsPRSHfTV8H+Il0z8tQSYR9//uxbgsPVnS9Fvo4aqt9a7iMtin30f oNKadLj96+v5lfZsEVRpmAnphhg6I7Y= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Christoph Hellwig Cc: Jan Kara , cluster-devel@redhat.com, "Darrick J . Wong" , linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-bcachefs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Kent Overstreet Subject: Re: [Cluster-devel] [PATCH 06/32] sched: Add task_struct->faults_disabled_mapping Message-ID: References: <20230510010737.heniyuxazlprrbd6@quack3> <20230523133431.wwrkjtptu6vqqh5e@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 26, 2023 at 01:06:46AM -0700, Christoph Hellwig wrote: > On Thu, May 25, 2023 at 04:50:39PM -0400, Kent Overstreet wrote: > > A cache that isn't actually consistent is a _bug_. You're being > > Obsequious. And any time this has come up in previous discussions > > (including at LSF), that was never up for debate, the only question has > > been whether it was even possible to practically fix it. > > That is not my impression. But again, if you think it is useful, > go ahead and seel people on the idea. But please prepare a series > that includes the rationale, performance tradeoffs and real live > implications for it. And do it on the existing code that people use > and not just your shiny new thing. When I'm ready to lift this to the VFS level I will; it should simplify locking overall and it'll be one less thing for people to worry about. (i.e. the fact that even _readahead_ can pull in pages a dio is invalidating is a really nice footgun if not worked around). Right now though I've got more than enough on my plate just trying to finally get bcachefs merged, I'm happy to explain what this is for but I'm not ready for additional headaches or projects yet.