Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 26 May 2023 10:52:17 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc:     Mark Brown <broonie@kernel.org>, davem@davemloft.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        alexis.lothore@bootlin.com, thomas.petazzoni@bootlin.com,
        Andrew Lunn <andrew@lunn.ch>, Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>
Subject: Re: [PATCH net-next v3 4/4] net: stmmac: dwmac-sogfpga: use the lynx
 pcs driver
Message-ID: <ZHBzQaWi5oskThI2@corigine.com>
References: <20230526074252.480200-1-maxime.chevallier@bootlin.com>
 <20230526074252.480200-5-maxime.chevallier@bootlin.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230526074252.480200-5-maxime.chevallier@bootlin.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6hsvvPuNnA26Z26uHGLUIVrTbnjlsYcnHiWMp7qeODOMaDkRk4vg6MH5HDbL?=
 =?us-ascii?Q?ozPuvzsBGWVNlGOjSW+YXICl7MtjBqnmrsf4silYTJsgcVVKylz0MaUyOImO?=
 =?us-ascii?Q?L8b8xKic0WMMSvf1jErPOj96gZubOSOSdNdy6Jnj5WwfosFEYr3l3AUa544e?=
 =?us-ascii?Q?u5qnXhi28ypVccBzXW3K4mSy4Ll0gRInEo+kK3aRkplb9NgWVDbDeL0cz/30?=
 =?us-ascii?Q?8q3pGw0nDzy5aDywC4Ey0V4V96LZWbTUBYwYfWPuSxkMf3UAMyVzvRm1d+H+?=
 =?us-ascii?Q?hHMO8s2AShIms/Qiqf+C3/1byIibiiXgwlqf3gMvnP3t3s6F8wrohu0u5PqX?=
 =?us-ascii?Q?OhyrWy5wWcgEabzEES+WV3XU23dtUesAf+1rqzgEvpIf+oP1n+MyLZFLZ891?=
 =?us-ascii?Q?73nhw0lFVNrdHCTeBhUMVlQ6eCWGQpwnAIRpLSbN1rKU3OHVrzXrrIWfKUdd?=
 =?us-ascii?Q?EkYYIKG5mWT1ixXRxqRAaAu+X4DKw4Ngay1XhkyCfWh/36aZU1R9E6+ssy1d?=
 =?us-ascii?Q?DYGJKzwA1y7TYnScYgTGEEmwgW1apyf0GtXnMRPao90zZUqhONpWUiqf0zOE?=
 =?us-ascii?Q?iM4WTwIP7lTKGtOPVo/7rVVKl9ky+CpKNwYL9eIlCwxnL/ECRrwaU1mWMQWh?=
 =?us-ascii?Q?/oTTLXkIU7sxylJqKeWxwb3HpFU7drIlzTFxZ7tn98lBolBLjqwThjz3+nhc?=
 =?us-ascii?Q?bCUn09PT+wVuHah/EaIxM5VckmzAlcIz2q0C/ekzSvBepaLOJoCPAYy3wT3n?=
 =?us-ascii?Q?O8GAJwBSiqeV/qBN1aE9hQ3V1rEysMQOQzONA19aA5zTTXmPLgNtDREI12EQ?=
 =?us-ascii?Q?FMqco9EBSpYWjp9cyM7iK+Yrxl0PlLbGNVCFHoSRO4/MIZtD1GMlPeUgS8Yq?=
 =?us-ascii?Q?5qpsQ2JFkTgBLakPvNYS3qK0MOul2Rei4XZxO2Is5k78m4dJ7S1p8cbR16gt?=
 =?us-ascii?Q?+1xmtQU/T0XsBQ5K35sqLQ/kbiemNExX9y/+xxbgleCTIIEbYjSjZ3X7Mn+0?=
 =?us-ascii?Q?CUFVY8iVXT1mFnxds0e5rnnEzOJ1TWyCT5HDT/73h38iT+BK/7AatKh+To4k?=
 =?us-ascii?Q?tVkYs+aa+IE7HsQ3psLWgIbmN9b+N6zK3dMa17+QkgoQHkKdJLZQNhEC1b23?=
 =?us-ascii?Q?U/T8CWoRlfSbKwG7p6IRZxKZvIdasoFVwId0z33gq9SwJBgY2A2uAJKtqQAN?=
 =?us-ascii?Q?ALVbd5BBmIHBOjpcaOWvG5izzH/9Tm6c4oDXMi0YvVr7QfH0qXhBRhOWuYdv?=
 =?us-ascii?Q?4M2SxLS/1CBWGVbfbCU80Jfsqh6ivME8pzH4jw656F2iLCBD4ZB9VRb2yG6v?=
 =?us-ascii?Q?X5FGn/hHTR4k2lFc8Xz2zxyhhGou78q22YeqKVSsx6jOCFJEygI0lNognL+S?=
 =?us-ascii?Q?rK+cQ9CK/sC9A8nfmyZCdlWQCqhlNfbm+ILjyLqAeXOlwE7VLOy+on3iSFvw?=
 =?us-ascii?Q?uSN93sb4/iGftmG7hiuKcVoIjlvckGp9jVTkSq3Lcc+c2q7OEeV9ubYp5GSN?=
 =?us-ascii?Q?tbaWNpnRhpwiKhmoC3aPbde7FCMifUHS0kv5TinyQ1/ENXIhTnjRmY5iztrP?=
 =?us-ascii?Q?Qhfv+APaVnjTEQEVjcVKLb2fxyJtvYxgfNTxV4iLfwFY4OgCCN++XkRH9a2l?=
 =?us-ascii?Q?Qd6G73L9XT8OlnRBemUo3mN/R8MZvkYlob3YISxeLC2k148xr6AI4aNp7iIx?=
 =?us-ascii?Q?n2iykg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f829a2c1-a407-430a-3543-08db5dc68df1
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2023 08:52:37.0620
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: klRf8QjjLfvsNzqr2A+NS8PhMTtbQUeuoqU6xA/VqiHMtkz6dVNi41q/J2E8hO83FPA6YzkzczC+HruJ6sEjfs6QHy+9Nyf7jtZyc2xjK+c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR13MB4808
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 26, 2023 at 09:42:52AM +0200, Maxime Chevallier wrote:
> dwmac_socfpga re-implements support for the TSE PCS, which is identical
> to the already existing TSE PCS, which in turn is the same as the Lynx
> PCS. Drop the existing TSE re-implemenation and use the Lynx PCS
> instead, relying on the regmap-mdio driver to translate MDIO accesses
> into mmio accesses.
> 
> Instead of extending xpcs, allow using a generic phylink_pcs, populated
> by lynx_pcs_create(), and use .mac_select_pcs() to return the relevant
> PCS to be used.
> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> ---
> V2->V3 : No changes
> V1->V2 : No changes
> 
>  drivers/net/ethernet/stmicro/stmmac/Kconfig   |   1 +
>  drivers/net/ethernet/stmicro/stmmac/Makefile  |   2 +-
>  .../ethernet/stmicro/stmmac/altr_tse_pcs.c    | 257 ------------------
>  .../ethernet/stmicro/stmmac/altr_tse_pcs.h    |  29 --
>  drivers/net/ethernet/stmicro/stmmac/common.h  |   1 +
>  .../ethernet/stmicro/stmmac/dwmac-socfpga.c   |  90 ++++--
>  .../net/ethernet/stmicro/stmmac/stmmac_main.c |  12 +-
>  7 files changed, 76 insertions(+), 316 deletions(-)

Another nice diffstat :)

...

> @@ -443,6 +454,35 @@ static int socfpga_dwmac_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_dvr_remove;
>  
> +	memset(&pcs_regmap_cfg, 0, sizeof(pcs_regmap_cfg));
> +	pcs_regmap_cfg.reg_bits = 16;
> +	pcs_regmap_cfg.val_bits = 16;
> +	pcs_regmap_cfg.reg_shift = REGMAP_UPSHIFT(1);
> +
> +	/* Create a regmap for the PCS so that it can be used by the PCS driver,
> +	 * if we have such a PCS
> +	 */
> +	if (dwmac->tse_pcs_base) {

nit: perhaps the scope of pcs_regmap and pcs_bus could be reduced to
     this block.

> +		pcs_regmap = devm_regmap_init_mmio(&pdev->dev, dwmac->tse_pcs_base,
> +						   &pcs_regmap_cfg);
> +		if (IS_ERR(pcs_regmap)) {
> +			ret = PTR_ERR(pcs_regmap);
> +			goto err_dvr_remove;
> +		}
> +
> +		mrc.regmap = pcs_regmap;
> +
> +		snprintf(mrc.name, MII_BUS_ID_SIZE, "%s-pcs-mii", ndev->name);
> +		pcs_bus = devm_mdio_regmap_register(&pdev->dev, &mrc);
> +		if (IS_ERR(pcs_bus)) {
> +			ret = PTR_ERR(pcs_bus);
> +			goto err_dvr_remove;
> +		}
> +
> +		dwmac->pcs_mdiodev = mdio_device_create(pcs_bus, 0);
> +		stpriv->hw->phylink_pcs = lynx_pcs_create(dwmac->pcs_mdiodev);
> +	}
> +
>  	return 0;
>  
>  err_dvr_remove:

...