Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a5891478-bf4a-8389-e1c9-00244c5b406e@linaro.org>
Date:   Fri, 26 May 2023 11:22:27 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 1/2] mfd: pm8008: fix module autoloading
Content-Language: en-US
To:     Johan Hovold <johan+linaro@kernel.org>, Lee Jones <lee@kernel.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
References: <20230526091646.17318-1-johan+linaro@kernel.org>
 <20230526091646.17318-2-johan+linaro@kernel.org>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20230526091646.17318-2-johan+linaro@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 26.05.2023 11:16, Johan Hovold wrote:
> Add the missing module device table alias to that the driver can be
> autoloaded when built as a module.
> 
> Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> Cc: stable@vger.kernel.org      # 5.14
Looks like the commit referenced in Fixes is from 5.13-rc1, perhaps
5.13 would be more fitting here?

Konrad
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>  drivers/mfd/qcom-pm8008.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
> index 837246aab4ac..29ec3901564b 100644
> --- a/drivers/mfd/qcom-pm8008.c
> +++ b/drivers/mfd/qcom-pm8008.c
> @@ -199,6 +199,7 @@ static const struct of_device_id pm8008_match[] = {
>  	{ .compatible = "qcom,pm8008", },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, pm8008_match);
>  
>  static struct i2c_driver pm8008_mfd_driver = {
>  	.driver = {