Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 26 May 2023 12:22:22 +0200
From:   Joel Granados <j.granados@samsung.com>
To:     Dan Carpenter <dan.carpenter@linaro.org>
CC:     <mcgrof@kernel.org>, Christian Brauner <brauner@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Iurii Zaikin <yzaikin@google.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: Re: [PATCH v4 7/8] sysctl: Refactor base paths registrations
Message-ID: <20230526102222.c5anxpcfia5djnxe@localhost>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="s4khld4elb45pjku"
Content-Disposition: inline
In-Reply-To: <c97bfda5-cecf-4521-880b-02c6da987120@kili.mountain>
CMS-TYPE: 201P
References: <20230523122220.1610825-1-j.granados@samsung.com>
        <CGME20230523122236eucas1p17639bfdbfb30c9d751e0a8fc85fe2fd3@eucas1p1.samsung.com>
        <20230523122220.1610825-8-j.granados@samsung.com>
        <c97bfda5-cecf-4521-880b-02c6da987120@kili.mountain>
Precedence: bulk

--s4khld4elb45pjku
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 25, 2023 at 11:37:47AM +0300, Dan Carpenter wrote:
> On Tue, May 23, 2023 at 02:22:19PM +0200, Joel Granados wrote:
> > This is part of the general push to deprecate register_sysctl_paths and
> > register_sysctl_table. The old way of doing this through
> > register_sysctl_base and DECLARE_SYSCTL_BASE macro is replaced with a
> > call to register_sysctl_init. The 5 base paths affected are: "kernel",
> > "vm", "debug", "dev" and "fs".
> >=20
> > We remove the register_sysctl_base function and the DECLARE_SYSCTL_BASE
> > macro since they are no longer needed.
> >=20
> > In order to quickly acertain that the paths did not actually change I
> > executed `find /proc/sys/ | sha1sum` and made sure that the sha was the
> > same before and after the commit.
> >=20
> > We end up saving 563 bytes with this change:
> >=20
> > ./scripts/bloat-o-meter vmlinux.0.base vmlinux.1.refactor-base-paths
> > add/remove: 0/5 grow/shrink: 2/0 up/down: 77/-640 (-563)
> > Function                                     old     new   delta
> > sysctl_init_bases                             55     111     +56
> > init_fs_sysctls                               12      33     +21
> > vm_base_table                                128       -    -128
> > kernel_base_table                            128       -    -128
> > fs_base_table                                128       -    -128
> > dev_base_table                               128       -    -128
> > debug_base_table                             128       -    -128
> > Total: Before=3D21258215, After=3D21257652, chg -0.00%
> >=20
> > Signed-off-by: Joel Granados <j.granados@samsung.com>
> > [mcgrof: modified to use register_sysctl_init() over register_sysctl()
> >  and add bloat-o-meter stats]
> > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> > Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
>=20
> This needs a Fixes tag so it doesn't get backported by some weird fluke.
> Or you could just fold it in with the original patch which introduced
I folded it into the original patch

thx

Best
> the bug.
>=20
> Probably add a copy of the output from dmesg?  Maybe add some
> Reported-by tags?
>=20
> regards,
> dan carpenter
> >=20

--=20

Joel Granados

--s4khld4elb45pjku
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmRwiF4ACgkQupfNUreW
QU/Phgv/dM4OeXZoGMXjp7WJRASyGlFsDMvhxkoTWqze/5olOWjFw31231QWfvkr
VWqUxm5CPzLt7/x0UNg/jiT5NrF72kVJssTuYUNPW/01J7NYhNSoEX0gGB2d7LOU
DrHC+0LGLGYbvKIOg58xvQul3DPMk3sofThlyajSQVfH5zqJEZB7Pt9f8rrYAXZF
wJrs+5lTtQ0uJjfA1NGYfom5tDJH9c0ekVR8SjfpflswiHSf1ZXarN+x6qy0LBv4
wk6IDhCh4pZRrUSd3z6InRApXGnyFJpY4JrLVb7h9Beibs8QIBWBTQs1xIblAOKR
wZzGfMZrps4RJumsIxxU6tP+yb5NjKIhx8z7MZ761uLW5j8agKzGLT4fSprQ7/H3
WI29BR58yVyO0a5Kig3rmpqvR88KVCHy+1TEgJzMfL9wbEdxwX08iyRxNX/NhVs9
e4dVJSBXnZoUuc2iVOV7j77d3fTQ5S0MwRuYmss/WNV2s2q4fW7kkAo6b3tsvM98
LhlD2/fi
=uLjI
-----END PGP SIGNATURE-----

--s4khld4elb45pjku--