Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2331855rwd; Fri, 26 May 2023 05:18:47 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5A7TpuS0U8ndz41p0zSZYO13kKKqBvYa6wC2ZctUwngD5P5ac0RRRM1c8aN//bIlb0XCua X-Received: by 2002:a05:6a20:9146:b0:10a:9f45:e3f with SMTP id x6-20020a056a20914600b0010a9f450e3fmr2737309pzc.12.1685103527250; Fri, 26 May 2023 05:18:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685103527; cv=none; d=google.com; s=arc-20160816; b=Kwmn6qm+VuGjeO9Rzu6xefaiwAIlerSyZUCJYoQ09PGxttITlV4RWpAt5YEf41K43/ NorViNkA6Npo+GrOX8JrsRCIq/LOs1emE+wRGKALRQpYwOwz7H8ANXpcDtuDPC2sr7fL 4yH6m2DS1cKJJrRLV4gJ4yleqWIWcoG9Yx9xyO1QNz3QJCo3FsFjgAtwOTOL4R0jnHkj 6yRGidup5AzLU0qopVyj6MJcWAtSqE3phh9ZqII3KPgH1tAqbmynFsBOyEr8RFTo9OTq DWOQEgDx5bjkH8z/2Bslxhd2+3VYFxZogcd5cNFt74WyHjF10HublflCmYYAl7kYzRfe 5VvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4Ys1st8FwMfEn5Qg+odGKWT++eyoaYj5WpZLq7WXWow=; b=g1N2p75qhPg9IaxJn/SG1bUSK0ATtFFHMbr2Q/GATmOxxkGXBNE+1oKTAeWrXqjsIE ufrteAoDhdhm0BN0VKy6YICO7FJ2Gwye4XCkDdYxOWZ/fjYeIC3uSHaEb1acv2WTLRFy gT1mUtosTEsiV0ew7SoyKokQBY/mGXufrDxBi5PxitWOArXq3bMekFWXLn0cOz9sEUuH rP2Zb/WJdpB8xFp3XlkT91Y2fsa8aFRGpwihbJ0WZlvJpb9EoCSe1N6eLodFVGTLGQor A+8VHX6NVVtzHx4TM5hXXdeXRWdZTTGzLP9rVFyJYf7C3UpMYn0HkrImIFhnjLEzlCgV Dw4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YAgA8Lfe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k5-20020a6568c5000000b005348f8c06edsi3586165pgt.520.2023.05.26.05.18.30; Fri, 26 May 2023 05:18:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YAgA8Lfe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242864AbjEZMNB (ORCPT + 99 others); Fri, 26 May 2023 08:13:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231270AbjEZMM7 (ORCPT ); Fri, 26 May 2023 08:12:59 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2121A4; Fri, 26 May 2023 05:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685103178; x=1716639178; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3mF6zurg5dlS4/06LH1kw8Ah/Zk773sNRWv9o+cBqOA=; b=YAgA8Lfe4wIO0aqhFink1Fbq2FkRg+EgJ0+WLBmull2koXjqd5zXyyJX CF/Br24jilWAuf2jOqHM3YeXq4xHLOjzlP1t/Q99LFE54upTqPQ2Sl1CY JWN6Xg9fL2/Ql/cu9amiYemQN7DwPZ8azyruj4o0N6BV6eGpd/cIkt3dm swyStxP9SVT46FTXP1+Hp++wytOw/qEK88qAXIIcFRknnGX51hs27CJFA AuKSd6s6Orel8i3Dkd2VmUMdWj+3nDsSrhaCC2NPIUtu1MYAGWDc72QLo AOccGyUczBkfo2+feQmCHHCQeAThkX+pJhauvh8Td0+lNhAK2IUAjImzp A==; X-IronPort-AV: E=McAfee;i="6600,9927,10721"; a="357441214" X-IronPort-AV: E=Sophos;i="6.00,194,1681196400"; d="scan'208";a="357441214" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2023 05:12:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10721"; a="655611684" X-IronPort-AV: E=Sophos;i="6.00,194,1681196400"; d="scan'208";a="655611684" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga003.jf.intel.com with ESMTP; 26 May 2023 05:12:37 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 85068413; Fri, 26 May 2023 15:12:41 +0300 (EEST) Date: Fri, 26 May 2023 15:12:41 +0300 From: Mika Westerberg To: Mario Limonciello Cc: Bjorn Helgaas , "Rafael J . Wysocki" , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, S-k Shyam-sundar , Natikar Basavaraj , Deucher Alexander , linux-pm@vger.kernel.org, Lukas Wunner Subject: Re: [PATCH v4 1/2] PCI: Refactor pci_bridge_d3_possible() Message-ID: <20230526121241.GU45886@black.fi.intel.com> References: <20230524190726.17012-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230524190726.17012-1-mario.limonciello@amd.com> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2023 at 02:07:25PM -0500, Mario Limonciello wrote: > All of the cases handled by pci_bridge_d3_possible() are specific > to these branches: > ``` > case PCI_EXP_TYPE_ROOT_PORT: > case PCI_EXP_TYPE_UPSTREAM: > case PCI_EXP_TYPE_DOWNSTREAM: > ``` > Drop a level of indentation by returning false in the default case > instead. No intended functional changes. > > Signed-off-by: Mario Limonciello Reviewed-by: Mika Westerberg