Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2371415rwd; Fri, 26 May 2023 05:54:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ57WQbjcUxMbg6X/M6urE58QKff4cbBKzabICG73Wj/5DkAihmDCxPdUXOyBK1ZbdzM9Pnc X-Received: by 2002:a17:90a:70ce:b0:254:ce9e:53 with SMTP id a14-20020a17090a70ce00b00254ce9e0053mr2488824pjm.23.1685105658226; Fri, 26 May 2023 05:54:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685105658; cv=none; d=google.com; s=arc-20160816; b=CI2iMATb7URK34ArFaf4oj50U/LavnxZhymn7sOjLzMI+QOoAnYLtOPc8lh0a72xf3 9Nc358N14tueiI5LEcfLmH/d+oQjQswAW5pmpjpYsEYdwSNQgzvP1UsODdTI+ME6fDon +hK4FekTQ4CrYrmaeHHZxr8KfBZ16IPJ5SpLSnHA82jCX/p29m2o3f8brmb32LFe6ap7 9v1FXZ8OmwHP4MpM70HqCNNphvCV2tUtOMOXk4nm7qKYndwM15NN7j2e9PI+nKDXxwxG gRRViLGrNOkBoiL2DVZiPqtndOEPt36XU1UQ55Qa9uiUelJg8vdlk/5jad4rWoqqeMsM Aclg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=KOY0B6u359smQyAo1CyvD9Z/TXScq6EVSjESa8SKKho=; b=jgsfcVG466Mn0kbjc/RKLMphdqVZaAf748qdl6xIUxybnkuDLbf2Yaxl4bAoyCQ53B X91nk3Ka87V7oVLcUrb01eUOP2XYboelUpD37t8QlstcdmFGJPgHlhnR+9nf6Bw+LzzY QAAdBJxclR4WKvi5Bo9LVZxwp2RgURbRFymRkxseskN0pwZYQfdTpV0aknKSnAFZT2u8 +SjScwRs6UYUpF3wM2s6CmpSuVaxbQWNqMS4r3uCl6Cx+NJ4FXX7px3hdLmKMZwAziDm fQQ5xiUU7YmPaZe9j+LByF2LVBpoA3MTYhYXXp9Exhxx9ia39z9aR9qcwQKSFJjMKrft inqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g14-20020a17090a708e00b002527f171401si588540pjk.182.2023.05.26.05.54.06; Fri, 26 May 2023 05:54:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237232AbjEZMfV (ORCPT + 99 others); Fri, 26 May 2023 08:35:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230139AbjEZMfU (ORCPT ); Fri, 26 May 2023 08:35:20 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BE5FE7F; Fri, 26 May 2023 05:34:56 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 29F416732A; Fri, 26 May 2023 14:34:09 +0200 (CEST) Date: Fri, 26 May 2023 14:34:08 +0200 From: Christoph Hellwig To: Yu Kuai Cc: hch@lst.de, tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk, lukas.bulwahn@gmail.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, yangerkun@huawei.com, "yukuai (C)" Subject: Re: [PATCH -next v2 6/6] blk-sysfs: add a new attr_group for blk_mq Message-ID: <20230526123408.GA4569@lst.de> References: <20230512093554.911753-1-yukuai1@huaweicloud.com> <20230512093554.911753-7-yukuai1@huaweicloud.com> <8cafbd02-182a-4071-7e04-cc6f96045852@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8cafbd02-182a-4071-7e04-cc6f96045852@huaweicloud.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch looks good to me: Reviewed-by: Christoph Hellwig