Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230526121751.41060-1-lihuisong@huawei.com>
In-Reply-To: <20230526121751.41060-1-lihuisong@huawei.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Fri, 26 May 2023 14:39:10 +0200
Message-ID: <CAMj1kXHgPbzgPm1Sq5hqqz7RX6sj2axze5F+fvMyfPY=d9=Hhw@mail.gmail.com>
Subject: Re: [PATCH] arm64: acpi: Export symbol for acpi_os_ioremap
To:     Huisong Li <lihuisong@huawei.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@linaro.org>
Cc:     catalin.marinas@arm.com, will@kernel.org, sudeep.holla@arm.com,
        rafael.j.wysocki@intel.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, anshuman.khandual@arm.com,
        wangkefeng.wang@huawei.com, liuyonglong@huawei.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

(cc Lorenzo)

On Fri, 26 May 2023 at 14:20, Huisong Li <lihuisong@huawei.com> wrote:
>
> The driver who calls the acpi_os_ioremap() cannot be compiled if the 'M'
> is selected for the driver. The compiling log is as follows:
> -->
> MODPOST Module.symvers
> ERROR: modpost: "acpi_os_ioremap" [drivers/soc/hisilicon/xxx.ko] undefined!
> scripts/Makefile.modpost:136: recipe for target 'Module.symvers' failed
> make[1]: *** [Module.symvers] Error 1
>
> So this patch exports symbol for acpi_os_ioremap.
>

That driver does not exist in mainline.

Why does it need to use acpi_os_ioremap() instead of the ordinary
memremap/ioremap routines?


> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> ---
>  arch/arm64/kernel/acpi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c
> index dba8fcec7f33..ec0414caf3d1 100644
> --- a/arch/arm64/kernel/acpi.c
> +++ b/arch/arm64/kernel/acpi.c
> @@ -354,6 +354,7 @@ void __iomem *acpi_os_ioremap(acpi_physical_address phys, acpi_size size)
>         }
>         return ioremap_prot(phys, size, pgprot_val(prot));
>  }
> +EXPORT_SYMBOL(acpi_os_ioremap);
>
>  /*
>   * Claim Synchronous External Aborts as a firmware first notification.
> --
> 2.33.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel