Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [syzbot] [bpf?] WARNING: bad unlock balance in bpf
To:     syzbot <syzbot+8982e75c2878b9ffeac5@syzkaller.appspotmail.com>,
        andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
        davem@davemloft.net, haoluo@google.com, hawk@kernel.org,
        john.fastabend@gmail.com, jolsa@kernel.org, kpsingh@kernel.org,
        kuba@kernel.org, linux-kernel@vger.kernel.org,
        martin.lau@linux.dev, netdev@vger.kernel.org, sdf@google.com,
        song@kernel.org, syzkaller-bugs@googlegroups.com, yhs@fb.com
References: <000000000000ea970305fc95f3c6@google.com>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <beb1ea86-4de2-f18f-99b0-f00e8ce40ae7@iogearbox.net>
Date:   Fri, 26 May 2023 14:52:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <000000000000ea970305fc95f3c6@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/26/23 12:10 PM, syzbot wrote:
> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:    c4c84f6fb2c4 bpf: drop unnecessary bpf_capable() check in ..
> git tree:       bpf-next
> console+strace: https://syzkaller.appspot.com/x/log.txt?x=119576a9280000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=8bc832f563d8bf38
> dashboard link: https://syzkaller.appspot.com/bug?extid=8982e75c2878b9ffeac5
> compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=10391dde280000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=137da9c5280000
> 
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/3cb57feeb883/disk-c4c84f6f.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/7ccb6d78c42d/vmlinux-c4c84f6f.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/fb02c9cdb21c/bzImage-c4c84f6f.xz
> 
> The issue was bisected to:
> 
> commit c4c84f6fb2c4dc4c0f5fd927b3c3d3fd28b7030e
> Author: Andrii Nakryiko <andrii@kernel.org>
> Date:   Wed May 24 22:54:19 2023 +0000
> 
>      bpf: drop unnecessary bpf_capable() check in BPF_MAP_FREEZE command
> 
[...]

Fyi, fixed this up today in bpf-next tree.

#syz fix: bpf: Fix bad unlock balance on freeze_mutex