Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2479645rwd;
        Fri, 26 May 2023 07:09:02 -0700 (PDT)
X-Google-Smtp-Source: ACHHUZ62ybLj5IDmsphgsUnG2mh0Y5bwQOMRziTGlorDPHMgDCYB7z1eLZUtrtAmF4l2ousPtIBH
X-Received: by 2002:a17:902:7085:b0:1a9:6a10:70e9 with SMTP id z5-20020a170902708500b001a96a1070e9mr2071433plk.33.1685110142257;
        Fri, 26 May 2023 07:09:02 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1685110142; cv=none;
        d=google.com; s=arc-20160816;
        b=FYGNZmVzMEI6AUAeELH2fGw8K80gKI8q8bxMvQlm1NI8ZYPRutURk5YMRkDUbd1mv9
         RwRUImYTGxH7H01DQBXoYwy3UxOGHui82U3ufTOY4n3YCfCCOaZhKhzdw3JP9yb6+wXM
         9vG9GfccDDm4gZqbM4YnrbEazkV019FXXZWmNUJ31wKct9p4NI7slE0o9Bcr14o5W7Y4
         u55jWERPOgNbFLMBoHY61+qqLvIKNto5Mt07/mGO8QnyTGxzcPhe5NQaY3kGfQbYEBPe
         GqE4AdxPHVUAMT4qRJr/ivU8F2kKzafrqyF7FoyGjLE6cxjfr0Me4JMpouQyjPgM9Nnn
         HqaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:user-agent:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date;
        bh=KizVpMB7LTAMarME1h+1OkUzEIUJ7qxFuQbeIruNhZ4=;
        b=SIieAEBPeOuXEjOD3bafDJtJJfRvNn4VmPTwxUjl1XBkLJix7v7CRIJVu1Ge4IFnRn
         I8o+zynF5aN97B8Z0omybXhSz1spJo+RdrLTWVpXKfukKE5mBBYW42pMxoVdP4mfMVLs
         tPquBk36Ff+ryu/Arathhqte6Xvy15ignlh6XxMxfRH1+1DcGm6JiSqjMl6hF4VH2qOE
         uxedbn0KeBP5groo0DHxKHxsuA+T0s6x/LuDF6ExCoGPoQ8YmIAPjcAXSgmrLpI/X+K6
         cByiRgWn2xvZsg3FoOEMjG4oCFEka59s7mqjqGVn+wMoSm9xWZ69RBEBecy5yRWkb40Q
         906A==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id p18-20020a639512000000b0053ef158b0c3si32191pgd.25.2023.05.26.07.08.43;
        Fri, 26 May 2023 07:09:02 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S243397AbjEZNhP (ORCPT <rfc822;a225855305@gmail.com> + 99 others);
        Fri, 26 May 2023 09:37:15 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38466 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S237082AbjEZNhO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 26 May 2023 09:37:14 -0400
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18041D8
        for <linux-kernel@vger.kernel.org>; Fri, 26 May 2023 06:37:13 -0700 (PDT)
Received: by verein.lst.de (Postfix, from userid 2407)
        id 5E61F6732A; Fri, 26 May 2023 15:37:10 +0200 (CEST)
Date:   Fri, 26 May 2023 15:37:10 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc:     Phillip Lougher <phillip@squashfs.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>, hch@lst.de,
        linux-kernel@vger.kernel.org, kernel@axis.com
Subject: Re: [PATCH mm-nonmm-unstable 2/2] squashfs: fix page indices
Message-ID: <20230526133710.GC8803@lst.de>
References: <20230526-squashfs-cache-fixup-v1-0-d54a7fa23e7b@axis.com> <20230526-squashfs-cache-fixup-v1-2-d54a7fa23e7b@axis.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230526-squashfs-cache-fixup-v1-2-d54a7fa23e7b@axis.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 26, 2023 at 03:25:46PM +0200, Vincent Whitchurch wrote:
> The page cache functions want the page index as an argument but we're
> currently passing in the byte address.

Can you avoid the overly long lines by movning the GFP_NOFS parameters
to the following lines?

The rest look good.