Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 26 May 2023 17:18:45 +0200
From:   luca abeni <luca.abeni@santannapisa.it>
To:     Vineeth Remanan Pillai <vineeth@bitbyteword.org>
Cc:     Juri Lelli <juri.lelli@redhat.com>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Valentin Schneider <vschneid@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 2/5] sched/deadline: Fix reclaim inaccuracy with SMP
Message-ID: <20230526171845.698656a5@nowhere>
In-Reply-To: <CAO7JXPhDCzJOvanKG=04wU3Q=C6GRW=+t2Zq6GmuQvfutjE8PA@mail.gmail.com>
References: <20230515025716.316888-1-vineeth@bitbyteword.org>
        <20230515025716.316888-3-vineeth@bitbyteword.org>
        <20230515100616.33ba5dd9@luca64>
        <CAO7JXPgq8V5yHM6F2+iXf4XJ9cyT30Hn4ot5b2k7srjsaPc3JQ@mail.gmail.com>
        <20230516093729.0771938c@luca64>
        <CAO7JXPh5uLV4QjAEi6bJXfAGSsZ=XsnCyzrvKS8m35BGbRPYJw@mail.gmail.com>
        <20230519115621.2b3f75e2@luca64>
        <20230519121804.6c85a3ed@luca64>
        <CAO7JXPhZPvzVRyL87qNT5VnaVOf=0wrRftFB-Rjx-vJc3JUMog@mail.gmail.com>
        <20230520115857.3838a7ea@nowhere>
        <CAO7JXPgXi8q02HBeBR_RLWmODd9uQBH_UMCYgVQwbf+FX=Qxkg@mail.gmail.com>
        <20230523225831.60d75b38@nowhere>
        <CAO7JXPihFGX5Dop=ox3YDQ=8aQbzZ-ka_1h3hT1G46vsbxpzNw@mail.gmail.com>
        <CAO7JXPhDCzJOvanKG=04wU3Q=C6GRW=+t2Zq6GmuQvfutjE8PA@mail.gmail.com>
Organization: Scuola Superiore Sant'Anna
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?D3eYBKJXRUq+Bue1ncpugsP5jYD9l4jspLlcUDTdAJfrO9uHNOOlHVIM4/U7?=
 =?us-ascii?Q?RUSJM/OENKADVzyG5OaQJ90RXMLQb+wvLv1WJYBtKnnOBz//y9RJEhDS5Bnh?=
 =?us-ascii?Q?juTLTgMtQBIy2aJe0M8iBNsmILikd47zOiLmbq6p6xVBs+m8dYFRi7O1Qb8O?=
 =?us-ascii?Q?Xj27s8jP2zoPlRrK+PHXWT0hP6p6A/I5vFtecwIBh5HLs9qpbBaI4mOHsigD?=
 =?us-ascii?Q?jAyppl3uJUjuhnWteEh9fdq0YUVrbOv/N8/rVE1iZdzKyVGhfhH+6lOi3Lda?=
 =?us-ascii?Q?bAj2coe5AYv31V8sqxoMUmVNm4zh+6cU86B65vKKshurfH13haAXjF6JiQsE?=
 =?us-ascii?Q?FCcnhCGi93GaSLpJhdbYQwF8OvABDOJpkrfunNhb7KvYu0dCzDgz/y38c8Nf?=
 =?us-ascii?Q?ex6ysXSrZWjIijl0GL0UrxIbkegbGVSn0o+u+2tDkChtUkg6HP8G8Agr2Uyb?=
 =?us-ascii?Q?lOJmpyd/PUgVJqhH2bc5/X+QHkp3Tg4XYLkdJ7sL9ymOijBkUdEPBXkyfMzH?=
 =?us-ascii?Q?VEvd5qlKAX7x/N2N1cGXcOLwGbjeUzIN7T5RwQ1jvUKX4pJWqyz1Mt/2DT9b?=
 =?us-ascii?Q?pY+Flsrp76EZGzyu/LNMbj8QWUSZH93wzeCXGdHXP2uFOIdG5CcBAvFc0ksh?=
 =?us-ascii?Q?Y5knK+oFwrzTiv5y+rmjIiVQOWUbCVpw3mLHavK7zQtzWmhKSax9+9OTZpQB?=
 =?us-ascii?Q?MbDAYA61JiR61ULqQUvI26ivbnNdyFPNCb0K08DgDhO2iuqyG4tJbKBplw47?=
 =?us-ascii?Q?6M0xBYfd8sW/XICePYfsc3VFG4SI0zDQD9iiqj5E12YeKUYNveD/JD83VpNF?=
 =?us-ascii?Q?b15Lp4Ayaj3fSuYJ4A7Ldnzr4SY+PcLNsc+mvkEqAp7Pn2P7nJOJQuLNK1mE?=
 =?us-ascii?Q?u6e/Z+ocU2X/sYskUwNgaqWNCoDwokW7LUEjAjzS/jfKgZRGmzxXijWBjYvs?=
 =?us-ascii?Q?uxzfD/O0p/Y1g0rWgO6McbPmsVzx8zYtu5JS+2BItK0XdWpTsZVdfdk8u91l?=
 =?us-ascii?Q?PDWhbH6FbJeQaLS0DlXHKheWF9XqY600QnK9jiZTP7I8rU9B/DlyZdRZcE33?=
 =?us-ascii?Q?CkDEBfl9xb8jOZHX92L3CchRRJep37Eh2/DYtqiCkpkP42N5l12nekDoOivo?=
 =?us-ascii?Q?DEQO5fhcgTYdifgvPhuZlmCIj6MIxxeaFcsxraT7vdPMNFCD+X5Crq00YH1w?=
 =?us-ascii?Q?LU5s4ctqaD82GLO7kp4RdI+xDzGyNkJk1r83JrUfegGzOYJZjz/TLPTpB4R0?=
 =?us-ascii?Q?+AGS70KQXigDruoCK/PKLFpDV/xnqV7UJhJosejZgI/nefAzUz6uzaq0a3aj?=
 =?us-ascii?Q?HIuxu+1yg1ujHvr1RE5Lg2HWMTS2T0aG+TOPsPsLPLoGVibmQWTdLXrgkID2?=
 =?us-ascii?Q?nge2LgBPENarLVrCBfwh9I1hNH/hlhh9oT/AbsM/X7Bul+9iQ2yoUPZf1t76?=
 =?us-ascii?Q?VzCUejQKoBsiQu7gCASxcAZMrkPJmHZ1Z/m3tXXbS7qty7Xa96h5mVt4NtLu?=
 =?us-ascii?Q?cZmmyF2g+vedSF9kZ/B8BbnrPeSqHcR9KMJ3iRC3ggSxRg9JQOnVhnpIhoes?=
 =?us-ascii?Q?hw+TKsFDT4NB+w8P6F9Pnw2IKM7gTwlp5Yfv9sYvsNaP+/5BvFCTaW8J0Zqu?=
 =?us-ascii?Q?sA=3D=3D?=
X-OriginatorOrg: santannapisa.it
X-MS-Exchange-CrossTenant-Network-Message-Id: d0b2105c-4226-413c-32b6-08db5dfc80bf
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB2880.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2023 15:18:47.7850
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d97360e3-138d-4b5f-956f-a646c364a01e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LyIMAJ75yZ3f8+GqBiW3izhg0V9Ih2zuLsLqW/wx77L5lanvBRhjrCsWNQllNmlg504C7m145cOh5LE/YzgmGfh+Kr9epJOVz2qBzatNFSA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR03MB7863
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 26 May 2023 10:54:09 -0400
Vineeth Remanan Pillai <vineeth@bitbyteword.org> wrote:
[...]
> Sorry for the delay. I was trying to fix the inaccuracy when normal
> and SCHED_FLAG_RECLAIM tasks are present. Its a bit complicated than
> I initially thought as Umax_reclaim and Uextra needs to be computed
> at the root domain level and this would mean more locking. I have a
> patch ready but I think I need to do more testing to understand the
> performance implications and it is better to batch it as a separate
> series.
> 
> So, I am just sending out the GRUB equation fix which is tested well
> and I am confident about. Will send out rest of the fixes later as
> a separate series.

Looks good to me. And... Thanks again for taking care of this issue!


			Luca