Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2595584rwd; Fri, 26 May 2023 08:32:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6VCbcgNWTZ5fjzynFTfn/8K8GKdXYjxmIVsj9/0SkuvB5Zyj4TDkwLLruXq/FidkaL5raG X-Received: by 2002:a05:6a20:1613:b0:10d:5390:ea90 with SMTP id l19-20020a056a20161300b0010d5390ea90mr2894550pzj.59.1685115160517; Fri, 26 May 2023 08:32:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685115160; cv=none; d=google.com; s=arc-20160816; b=00rvC7h7+6SlHr+3Np4NN+1bA3w8egjtHS0bxLqqDLiLp6O4Y8eG9wNIJhD8N1faR9 MuwiCmLb+EX6tEWeaQqzUrZ79kGT7JZY0hqALGLk+nEmJgWVXTXY4w2Ns/IURwBX7Yrt livAFmjfQaCHjMC2JROPHySd6Uk0049R+rKgz9ZiWfcu3tt83y24tgXGD0HUpKww7Uee rCsQFI+wTDFtfO80CxDt3GTcZnPggNvsXytXF55AlQu2N07CTSYD0o1gvFTWni2YY/Ir 8/xbfzpq90R60gBiyE5KBCMYWVnbSmrgo7r8LRdxH2Avp6wP4lVFpj0aqMFcqqta78Sn Tpqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=4zuErwq34qH9Oj8EBxRjLTGjwoxlorXTghE1W1F92Y4=; b=azN+FpFLifLIGT/gWUdv1gtuC8Oo8wRBQiKnstZYI0gf1/XHVoy2QH4aMW0b8iNumm 6/ULO0A2dYFu19xGtVvPceZzb5uVRb80O6SVED56bkoC6RO3FZTlBkkHLVhXooKsufmd 2+jG5kZUwhW00L5M4Rtzoqzes+YAbgxhC3xzjR67V04katZGMT2ghrLfaSJ2ss3I9N1K 0IGOS35xYw5a9fd+nIEktm45GpqUdccfers06mK7tt4ZyGU/Wfq8eJxjQslCvrEZNtV/ OI7eHvYdy70pzuCDg9vWySMgKOMGxk8OB9u7oNraYUu9mpvPlMK6ppgv6qnVjzUB+rmz F8mQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mEdr5gtI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u60-20020a17090a51c200b00250c9a70af9si322126pjh.63.2023.05.26.08.32.27; Fri, 26 May 2023 08:32:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mEdr5gtI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243272AbjEZP2e (ORCPT + 99 others); Fri, 26 May 2023 11:28:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243918AbjEZP2c (ORCPT ); Fri, 26 May 2023 11:28:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 244A11BF; Fri, 26 May 2023 08:28:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1F72C650E5; Fri, 26 May 2023 15:28:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A0DAC433EF; Fri, 26 May 2023 15:28:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685114901; bh=LCSRCtx+txpAlMWcHwFZ0OLjSSHA39brvSCzsYhZqJ8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mEdr5gtIfYVukLgXLz6UnzVWJUAoI0fVU2VjZsFbTyrxeXmkR2ZSNFdKpoPo9en1z Apq9eKZ9dTBJ8tA40YrW8fcJyIw3gGsfyVpjGPEL51uSnDnCE4wok0EmdVGLdoPX+r wGQ42fSYWV+Jparf8CDubBjXgHCIncC0m3RZAob61o2MY2xypt6k3eRxHU/m8q65Fd bG8PAwa7rmFmEr4WX7qNbJIIF3xYxU4qBWzWqbcpqaLS5+OJSER6zKILW/i2/yuyGV vTCQPG39gL77IX8r1toBhYxr8MvwMUWm+3H64ZzeHaoCy/ygZVXq8Gj8Vfr2HWmdgS n2Jf/L5vKmJ2A== Date: Fri, 26 May 2023 08:28:19 -0700 From: Jakub Kicinski To: Haiyang Zhang Cc: "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , Dexuan Cui , KY Srinivasan , Paul Rosswurm , "olaf@aepfle.de" , "vkuznets@redhat.com" , "davem@davemloft.net" , "wei.liu@kernel.org" , "edumazet@google.com" , "pabeni@redhat.com" , "leon@kernel.org" , Long Li , "ssengar@linux.microsoft.com" , "linux-rdma@vger.kernel.org" , "daniel@iogearbox.net" , "john.fastabend@gmail.com" , "bpf@vger.kernel.org" , "ast@kernel.org" , Ajay Sharma , "hawk@kernel.org" , "tglx@linutronix.de" , "shradhagupta@linux.microsoft.com" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH V2,net] net: mana: Fix perf regression: remove rx_cqes, tx_cqes counters Message-ID: <20230526082819.26ab0a9a@kernel.org> In-Reply-To: References: <1685025990-14598-1-git-send-email-haiyangz@microsoft.com> <20230525202557.5a5f020b@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 May 2023 14:42:07 +0000 Haiyang Zhang wrote: > > Horatiu's ask for more details was perfectly reasonable. > > Provide more details to give the distros and users an > > idea of the order of magnitude of the problem. Example > > workload and relative perf hit, anything. > > For example, a workload is iperf with 128 threads, and with RPS enabled. > We saw perf regression of 25% with the previous patch adding the counters. > And this patch eliminates the regression. Exactly what I was looking for, thanks. Please put that in the commit message and post v3 (feel free to add the review tags which came in for v1 in the meantime).