Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 26 May 2023 16:33:23 +0100
From:   Mark Brown <broonie@kernel.org>
To:     William Qiu <william.qiu@starfivetech.com>
Cc:     devicetree@vger.kernel.org, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Emil Renner Berthing <kernel@esmil.dk>,
        Ziv Xu <ziv.xu@starfivetech.com>
Subject: Re: [PATCH v1 1/3] dt-bindings: qspi: cdns,qspi-nor: Add clocks for
 StarFive JH7110 SoC
Message-ID: <87e9ed95-ea57-44c8-85f8-34264b5c6dde@sirena.org.uk>
References: <20230526062529.46747-1-william.qiu@starfivetech.com>
 <20230526062529.46747-2-william.qiu@starfivetech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="k1KNVGTJrGqHtc0k"
Content-Disposition: inline
In-Reply-To: <20230526062529.46747-2-william.qiu@starfivetech.com>
Precedence: bulk


--k1KNVGTJrGqHtc0k
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, May 26, 2023 at 02:25:27PM +0800, William Qiu wrote:

>      then:
>        properties:
> +        clocks:
> +          maxItems: 3
> +
> +        clock-names:
> +          items:
> +            - const: qspi-ref
> +            - const: qspi-ahb
> +            - const: qspi-apb
> +

Are these really the names that the clocks have in the IP?  It seems
weird that they'd include the IP name in there and not just be ref, ahb
and apb.

--k1KNVGTJrGqHtc0k
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRw0UMACgkQJNaLcl1U
h9DBagf9HzZRKBRscmFdDMGNaPloiDN0Kfiy13vOIf3Uk5whgF17nUJKVr81u2Sx
Dyn6MkuiP14JXAI4RtuTWPeIPdTJqbdenQ74rr1p5Taf4cn3XirLkJ6YBjWccsjC
zPwO+qLmb8swT/JzWonBFqiVmeHzJ179GhKWBxPkME1iO89LaFbFAa+mI4LqzYZ9
XbZ4VT4kpdnru//sZG1kq06xxwVzYvJy/FHZKpKxa0ZX5/SAaluYKb/z+Qt4Dtas
4ReA/isOd8wUcjLDIG+yV98pOteXAmQy9BsCUdMLzDnDZYl1WXsZuIaJX4yudBlo
Ih9Vt+8NxZvlVeO0zrn6/jwnIiaJbQ==
=GwnE
-----END PGP SIGNATURE-----

--k1KNVGTJrGqHtc0k--