Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ee9c0ab3-028f-cadf-c577-e57a139de5ce@quicinc.com>
Date:   Fri, 26 May 2023 21:06:19 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] smb: delete an unnecessary statement
Content-Language: en-US
To:     Dan Carpenter <dan.carpenter@linaro.org>,
        Steve French <sfrench@samba.org>
CC:     Paulo Alcantara <pc@manguebit.com>,
        Ronnie Sahlberg <lsahlber@redhat.com>,
        Shyam Prasad N <sprasad@microsoft.com>,
        Tom Talpey <tom@talpey.com>, <linux-cifs@vger.kernel.org>,
        <samba-technical@lists.samba.org>, <linux-kernel@vger.kernel.org>,
        <kernel-janitors@vger.kernel.org>
References: <077d93ae-adbf-4425-9cc4-eea5163b050c@kili.mountain>
From:   Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <077d93ae-adbf-4425-9cc4-eea5163b050c@kili.mountain>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/26/2023 5:31 PM, Dan Carpenter wrote:
> We don't need to set the list iterators to NULL before a
> list_for_each_entry() loop because they are assigned inside the
> macro.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>


Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>

-Mukesh

> ---
>   fs/smb/client/smb2ops.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
> index 5065398665f1..6e3be58cfe49 100644
> --- a/fs/smb/client/smb2ops.c
> +++ b/fs/smb/client/smb2ops.c
> @@ -618,7 +618,6 @@ parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf,
>   		 * Add a new one instead
>   		 */
>   		spin_lock(&ses->iface_lock);
> -		iface = niface = NULL;
>   		list_for_each_entry_safe(iface, niface, &ses->iface_list,
>   					 iface_head) {
>   			ret = iface_cmp(iface, &tmp_iface);