Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2647085rwd; Fri, 26 May 2023 09:12:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ70beqdq3RQAQkPnws3Oi4zZkTBsEabp8NcwZLNfXFn39GAKJelDHp8rRm1T7fZNhGrI4tP X-Received: by 2002:a05:6a20:a11f:b0:10c:5ff4:8bc6 with SMTP id q31-20020a056a20a11f00b0010c5ff48bc6mr3163681pzk.38.1685117530594; Fri, 26 May 2023 09:12:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685117530; cv=none; d=google.com; s=arc-20160816; b=FNdwmCUc7yaUOAQOwjX7s+SlLZQ4reGF7qS/PdepS9j4TkYRWNzYmKmnA5F5RCQ5MI kjSyI5v7IdOh6Nz0xSV89ajr1K90jMvvkpcGoT1u3ZFPixjxpdELPGgL7ywZk+8Z6JDC X/Dvz73+Qd08gPPJq17X6am/BWCHBTYJqHkM3lDhtOoQlLv/NdPRNs8rOkQjZOeRPSdr QJmenFFVq+2YD+ZH6CflWRFBpEL7AFTTecgSDRumJy8MKRdaPAM0ASTUOYN0FpPL2bs1 F9ultgPenqvk55QVhSpKgZtjg+31EVmLFkhfS+5VXwKEu9jA5QTCA5lqfoD5dowrMblx io8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=UxJRX95nR7lgawLbY9ei/X7hSzGOF/KUvLucc8yijNM=; b=bdNflaBqwqrVFUxfwNjv9rQGlS1Ht8nh9/p4DIXmn9AQjqG8lxaXXwt1oIqJHbPOx1 czK+hjDgy5iNVKlXR7F/SSAx2oLUNqxa4RlcP7Rafg2CYjxO9tpuG1eLRueNuQDY/bwr 6Fz8ZHqS6VWj3Xn61xm4TKzQMSyKELpIGpQWIQ6Q5pVy3PFtfrC9v1L/MROD0DY1WBmG QvLOsqhuF5fP6tjSXeB/w+3yuqW9uZbOOKrFh734fJ+h37/16VwubBog+jA9bpTb7Xrr pztAswhGRKmZi+oaPg1kaxiC1vtiwqh0HiyJ2RPAKVlRLbxlWmJFlGVc9eqH9PYKHytQ DKrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=g7PSHot2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q38-20020a17090a1b2900b00250365255b9si1090921pjq.116.2023.05.26.09.11.55; Fri, 26 May 2023 09:12:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=g7PSHot2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243840AbjEZPzE (ORCPT + 99 others); Fri, 26 May 2023 11:55:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244039AbjEZPyx (ORCPT ); Fri, 26 May 2023 11:54:53 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D4E613D for ; Fri, 26 May 2023 08:54:51 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-30addbb1b14so255024f8f.2 for ; Fri, 26 May 2023 08:54:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685116489; x=1687708489; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UxJRX95nR7lgawLbY9ei/X7hSzGOF/KUvLucc8yijNM=; b=g7PSHot2l7VS8EXyTj17hqAOLoSsCnLRDW6gY0Spb1atRcCo3AyvjDAQdFQmYEhL3g DIvb/y/nRRwgZNWt65p58Iz/nQWLCJ1XMLBqQ3jxrvcC1K1eiRzqeF66lxDnBUNnf01U q+MtowiYszrvL5JxgMgiD6m0/h5HDxVgGjD29lE9rGSYgElFnPnaNFCkIYGRHsJvfLLb yRHcbrZUVkKmbIQnigv6vgukxaCmLcL5R+XltVbbnHB+ZlxD5L9pmLW5Jho3Nxxl/td+ l1TKWDQZnEj0c5RYy4V52YhvZ53SAU8tMwoSJzqY04pcFUQARJMwSyL4rK2etQ4S4E4i oruw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685116489; x=1687708489; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UxJRX95nR7lgawLbY9ei/X7hSzGOF/KUvLucc8yijNM=; b=TKdI5gR2F9463UvHsS5sa2U0FhV7VKvoDTStGEu9yKDe6wewabhBAcCflFlAZEwv1T JRAhpCMkiurg1cR2MqC+FkRA7W88GkJVS7iwoDqynf3tIkls8gEnkJjySvbluAt8IPY+ 5S4WFs8xpocqZOABwNksFCry7z3Z1sCCfsaGe6a8EjGzA5C4bfNoGMZTWSsKsfPc67Sy IVMTdKchJaPM1GqxZ6CFbZ1xbFJZURvuKlM5mksc3rxJTu64nFhom25P7r7iJQbSPEfM tFNMRNUlHX9c1lRWgsDOn/BTq4w6h2ZWEJa13LwfE9n3OP8EpSfNBrI7uQ7wsiQWjPm2 ZatA== X-Gm-Message-State: AC+VfDwA2rkyLxMeWLCqV67DglMpqM6frWOM9ubqYX8lwGSyoJ2MFBqw 0jpqrWrh8efdJ6wU/cOYrA0wjIu0ZL+mwexWk5ve9Q== X-Received: by 2002:a05:6000:505:b0:309:42f3:4c3a with SMTP id a5-20020a056000050500b0030942f34c3amr2040157wrf.32.1685116489672; Fri, 26 May 2023 08:54:49 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id e18-20020adfef12000000b00304b5b2f5ffsm5419516wro.53.2023.05.26.08.54.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 May 2023 08:54:49 -0700 (PDT) Message-ID: <240fa683-afb1-eb60-c24f-2b3f1d7f1339@linaro.org> Date: Fri, 26 May 2023 16:54:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH V2 3/6] clk: qcom: clk-alpha-pll: Remove explicit CAL_L configuration for EVO PLL Content-Language: en-US To: Jagadeesh Kona , Andy Gross , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Bjorn Andersson , Konrad Dybcio , Vladimir Zapolskiy , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taniya Das , Satya Priya Kakitapalli , Imran Shaik , Ajit Pandey References: <20230525172142.9039-1-quic_jkona@quicinc.com> <20230525172142.9039-4-quic_jkona@quicinc.com> From: Bryan O'Donoghue In-Reply-To: <20230525172142.9039-4-quic_jkona@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/05/2023 18:21, Jagadeesh Kona wrote: > Fixes: 260e36606a03 ("clk: qcom: clk-alpha-pll: add Lucid EVO PLL configuration interfaces") Is this a "Fixes" without the previous patch to stuff the CAL_L_VAL and VAL_L fields ? [PATCH V2 3/6] clk: qcom: clk-alpha-pll: Remove explicit CAL_L configuration for EVO PLL Surely you need _both_ with this patch depending on the previous, per your comment ? - .l = 0x3e, + /* .l includes CAL_L_VAL, L_VAL fields */ + .l = 0x0044003e, --- bod