Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 26 May 2023 16:36:15 +0100
From:   Mark Brown <broonie@kernel.org>
To:     William Qiu <william.qiu@starfivetech.com>
Cc:     devicetree@vger.kernel.org, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Emil Renner Berthing <kernel@esmil.dk>,
        Ziv Xu <ziv.xu@starfivetech.com>
Subject: Re: [PATCH v1 2/3] spi: cadence-quadspi: Add clock configuration for
 StarFive JH7110 QSPI
Message-ID: <fecc9d6a-022e-49d9-a452-8a63c409ebf3@sirena.org.uk>
References: <20230526062529.46747-1-william.qiu@starfivetech.com>
 <20230526062529.46747-3-william.qiu@starfivetech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="v+3QrjJW0SnLoR7W"
Content-Disposition: inline
In-Reply-To: <20230526062529.46747-3-william.qiu@starfivetech.com>
Precedence: bulk


--v+3QrjJW0SnLoR7W
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, May 26, 2023 at 02:25:28PM +0800, William Qiu wrote:

>  	if (of_device_is_compatible(pdev->dev.of_node, "starfive,jh7110-qspi")) {
> +		qspi_ahb = devm_clk_get(dev, "qspi-ahb");
> +		if (IS_ERR(qspi_ahb)) {
> +			dev_err(dev, "Cannot claim QSPI_AHB clock.\n");
> +			ret = PTR_ERR(qspi_ahb);
> +			return ret;
> +		}
> +
> +		ret = clk_prepare_enable(qspi_ahb);
> +		if (ret) {
> +			dev_err(dev, "Cannot enable QSPI AHB clock.\n");
> +			goto probe_clk_failed;
> +		}

Nothing ever disables or unprepares this clock as far as I can tell?
Perhaps also consider using the clk_bulk_ APIs.

--v+3QrjJW0SnLoR7W
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRw0e4ACgkQJNaLcl1U
h9DDjAf/R/4LWKt8MIxLgActzDmknNj+os5gInUv/NtPY46t1E8c3jR/Eg97Gwi5
OlkkK9IGHeqfKcfWzj2JTZP+474sqV5Jss5qmQuBHcG+O8Vl63kxhlgDJi/v88Rs
CkyE+kbTbQgjNXVoq5XmHRRJfj5ncsv74NqrldUZEsfogSW6xuidDwgbp9lHOM21
5qZ2jLYI/JMLyu0hXO5HKofG8QcizYDmBsRrHBu/Im9RLesezvQDHpAaO2E0nl2q
MLLFaPijxFFGpl4sivm4QBJOO66TXc/Lh8JDk+qJd9EnElYMMw9YC/qxR+8syUp/
8kxK93togpBNaxDL4x5zo8EiNX0nBQ==
=c3SD
-----END PGP SIGNATURE-----

--v+3QrjJW0SnLoR7W--