Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <60367660-f4a3-06dc-4d17-4dbdc733ef74@oracle.com>
Date:   Fri, 26 May 2023 09:44:34 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v4] mm, compaction: Skip all non-migratable pages during
 scan
To:     Matthew Wilcox <willy@infradead.org>,
        Steven Sistare <steven.sistare@oracle.com>
Cc:     akpm@linux-foundation.org, david@redhat.com, ying.huang@intel.com,
        mgorman@techsingularity.net, baolin.wang@linux.alibaba.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Khalid Aziz <khalid@kernel.org>
References: <20230525191507.160076-1-khalid.aziz@oracle.com>
 <ZG+99h3zg7POIits@casper.infradead.org>
 <ee093583-71c3-51ba-980f-0facb03b0e23@oracle.com>
 <ZG/I7tYY4uV/32hP@casper.infradead.org>
 <ZG/To8Z3StoVoenU@casper.infradead.org>
Content-Language: en-US
From:   Khalid Aziz <khalid.aziz@oracle.com>
In-Reply-To: <ZG/To8Z3StoVoenU@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXhzalliTkVxTUR2UUFGYmZoWjBmMjMyNHBsNXdSTlJjOGY0VnVFMG5iY2cy?=
 =?utf-8?B?WjViMjRBQzJEMGxleitDT0NHWDczS3pIS3dvTVBvSHNoVmRkcVNOR0gyaHlE?=
 =?utf-8?B?T1pnc0tERVdMaWZoeElCWUlUS2pydXEwTXNBNFZGK3Q2YXJYVlFrMGFCVG5j?=
 =?utf-8?B?Q0l6Zm50a1NzMDkxazJiNHBpcFk5ZTN2THFudXV6RTVTd2gzRnlpaHZNak15?=
 =?utf-8?B?Nkc2cUJqS2dVR2IxOU1iL1NYTmdkT2F6TlRZQmcxN3hmYjFMeEZoaFkxZDNa?=
 =?utf-8?B?czAydnQwWUdaNWZTcVRsZmJYWFcrRjArSUFDT1NVQTBMelE4Sm81ZEJFZHdL?=
 =?utf-8?B?bXM1V2h5ZXREWnBYSmVuQWpyRC8xOE0vWU5rM2Q1TTZXL1loS3FDdjFaREps?=
 =?utf-8?B?clhPeUVVZC9mdXZqMnZBb0huVUNUcnRrVG8ya0NGaWdjc0JEQThQN0J0d2FN?=
 =?utf-8?B?QXFnNW1QZDRQa1A0MnA1OG1NbGFyUXdlODZuMytzeVNrUTV4dmMveG1IZU5o?=
 =?utf-8?B?K1F5RjI2ai9MczFJTjN1TWdHWkNoZFQxUzZXZFZ0b3pPbzVxZFQ5QTM2bXRU?=
 =?utf-8?B?Q3lldHUxRFhXZTd2RnJmVnpoK051Lyt0cXU0dFlhd3liK0JuQjM3NVJLbEV3?=
 =?utf-8?B?UXc1amhJWEd5WXE5bTNYb2NxOUtuc1ZjTnJTUkVUdk1lZHMyNWRSUUJ6VjVE?=
 =?utf-8?B?TElvZTltcGFDWU16OHcwSlVqUFYwdkZ2S2VWNnRGRGhaVzVITmdJaFc4UWhx?=
 =?utf-8?B?d3hnRHRqd3R3cmhDV2pxdDBCdEZDKzlIVXNRaXZDS0s3dFZQRkI3QnJPd0th?=
 =?utf-8?B?SnU1UlJKMHZpTytJcVZDNWlHZ0dpcmF4a1UrYlRaWnpiOC90U3NQMzJPVEZt?=
 =?utf-8?B?b2hWUThEeEhFTHRmMjJQZVdiZWNkZkM2Q1d4VzBCUGhJU09EeWRNSnlvOGRx?=
 =?utf-8?B?cDFHdElSS3dPVGVsN0h5b2oxODBZZUJFWW9LUXZEcUd6d09lRnJjV3M5ZGtn?=
 =?utf-8?B?M0JHamdUZmZSOENHT2tkZVUxTGFVbmJaL20zVXRsODUyREw4eUxMNnlqa0dQ?=
 =?utf-8?B?ZEFJNXlxQ3BCVHhTaTNsOUR3ekNFNTFUeHNiSG5ySW42Q2VtN2ZBVUVSSnRo?=
 =?utf-8?B?TWRrWjhKUERNVTM3SEw3MjNPaVZwNFVxTFF5bXNnQTFIS3BQUjYwUlNZS21J?=
 =?utf-8?B?dU1TVlpXSlpJWVBtMVVXa21jSklKSWd5YTdKcDE1ZGp3V0xhY0ZFVWlQSThZ?=
 =?utf-8?B?Y08xSzYwWlB2MUY5TVVWTXYxQkRvNnpCMzVGcVFEalhPbzVSL3c0NXdoSkUz?=
 =?utf-8?B?R1VMWEY1M21HQkcvZ3czV2NkMEszR2ZzRHZOYzZCSDlSZU5KWEh5Q21aK3lv?=
 =?utf-8?B?Z3dmQmxzNjY3V1NrY29OM21ud2UvNUx1Sm02dG1vTUhnUTU3VUU3T1UwUUNC?=
 =?utf-8?B?b3d0RFltYW95Q1FTNWxFdUQ4eUpWcEFwMGlLU3V6NDJTbUo0UTFWL3dyblpJ?=
 =?utf-8?B?Y2c4TFQyYXBXcXVjTHNkVUJaMWdOd0U3cDlzQzVMTlpwVnZJT3NnQ3pwQ00y?=
 =?utf-8?B?QnV2OUw5ZVlROWgrQ0p2SGI2Y2NONjRVTzNudFFvM3Ewa3VRdCtvQ2EzRUQ3?=
 =?utf-8?B?NWFUMno2K3k2ZXYrcU9Lby82N0tGNGxpMHJTZjNjK2srUVBYVStpV2oxbTRo?=
 =?utf-8?B?bVRuY2hwc3ZiaklTdGhDait1b0pkZmU3bi9qQVU3L3hRaVBqSkJOVm9SVUJz?=
 =?utf-8?B?Z3VkWWJwZXk4SGdDcWEzUkdaN0xoU3JXY1JBNjJCQllmK2t6S3laS0szaVpN?=
 =?utf-8?B?UUNaUHorNGZIOGRBRE1Cem5vcXlHdVA2a2o2a05GbGw3c2RiR3lIclJEeEo3?=
 =?utf-8?B?Wmdld3oyNU9GcmxDSzJxdXZhLy9PMFJaVnR6ZGJRbkl2cFhwY09DM3p3QVFp?=
 =?utf-8?B?ODR3N0pSWTlROHpMcWRDYWMrMzVQY3lUS3dLNDR2OHRWSDBmSjRzRWRMczVG?=
 =?utf-8?B?V2lZZ3p4VlFIWG5keWIyWTFIYk1VaWIvZVpkRllDUDdkWVNBL2NLaG9lSFVa?=
 =?utf-8?B?Z0lxMFlSQm9UZ3BNU0ZWR3M3cFU1cWZpQWRudVJzeWZxazBxTFlSZjZoalAz?=
 =?utf-8?Q?vqQWnjO4tfjqF1i9VKahrliod?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?MnlnVkhEa2hxaUU0ZlVnTDFURW9CTUlqcUdLTm5YOG1YcXZJdERUTk9OYjJI?=
 =?utf-8?B?a0ZSdlZFMVdCWE9hL29zV3loNlJuZkd1bTJKYUtZOUREd0IyclZIZ0NNa2V3?=
 =?utf-8?B?T1BZbVFKRUVRRTQrQkEwZDVqTWtwYUJRejIreXovR2VxM2QrUWNNdFhyNVBC?=
 =?utf-8?B?M1l5blVXNTBNaXorQ2RielltZS9mbjlTRjdQSXZwSkRRVzlUWTZuSk1iaW5J?=
 =?utf-8?B?MFFHeW5keDkvQjRjVjBuVVZ3bm1kWWgrR25TaGNpcVBVekJydXFUbTI0MmM0?=
 =?utf-8?B?UWllRDcwSFZQL3lqT3YxQTVtU1NKaWU4cVZVN0VLdi9ndHlKWURrRituNjc2?=
 =?utf-8?B?U3AwcXFvUy96dzhXc2RMRUY0bk1QSkF5MUYrWWJCQWdpalYwYnhyY0JsOGgz?=
 =?utf-8?B?NE5JSXF3QzMzUHF3MnVQWDFTZmxZcEI0dkV0ZWJJdGw4RUpmdENKTW42RUdn?=
 =?utf-8?B?Ty85WmZKM2FwZEFqUEtKQkgyOVNMRldRTnEvS3RwWllEV3gvTVJZNmd4VXl2?=
 =?utf-8?B?cnJTZUJ0WkFiK245YVd2aHNwMHBMclNSL2tOM1JUK2FNMDJobks3NnRxVkV5?=
 =?utf-8?B?NHRPTE1xZk5lWU5BN2JpQm1MU1U4TnBzdEhQSmZ0Ukl6OFlyRlZJMi9zdWk3?=
 =?utf-8?B?blhBUVc5UGdEM29nRGdmTXJzRnhtTmlZcXVKS1o2bndZTXdMMmJOd28vME5a?=
 =?utf-8?B?SXJKYmVMMm5DT2NPOUc5NXBxeFZaRW0rcW1pVWx3MUIvSkFGQWwrQjNMOW1o?=
 =?utf-8?B?b3dwMnNyZ1lLbXJzUHFxN25SUzlUOHFNQkJYY294KzZqVlRpUVZJNEZRTHl5?=
 =?utf-8?B?QXpzWW13UGNQdEtWdjRCZmtPbmMzZzd0WjNKSXVoa2orUmZzRXhxcjBnbjhs?=
 =?utf-8?B?VGRmRm41RTFJSmp6R3VRNlpSbEdYWWE3VFBWdU8yOHRpVFEzNWFQZ3VwOEpo?=
 =?utf-8?B?dlN4OERTaEVQTzA3ZktERE5lUFdzUWtsZ0hrSEc3YkxvMmI2K3A3TVFlRXNp?=
 =?utf-8?B?OVNabGV3QnlRekU3S0lQZUpFVmNzMDlaK09SNFRmeE5YbzhQbEE3cERhdktF?=
 =?utf-8?B?d3FhOWpaSllpQ05HYysxR2hHTVBwcitEOHdta0pxbGhMTTFQOHJjWFN0VmJW?=
 =?utf-8?B?Y2FTVE55ZTl1MEhtZEM1ZFlLYjB1K0JKN3R6ckVrcm1iSnp3V1ZWOTFlODMz?=
 =?utf-8?B?TUNSemUweHBZM01QZWwrYmhleXVrb3dMdkNVUGFzL1JITk1DclFkcXo5UE9V?=
 =?utf-8?B?OTBOOFNQUnA0QWExSmdxeEJvRVVaZDM5WmV4L3pDWnZYWWZqQU5KZVpRdDZO?=
 =?utf-8?B?OFYyY0JDSjJkOERBaTFvcW16SnFaekhGOTJYUkIrTFdmMHJEWUl2Z1dSQ2Jw?=
 =?utf-8?B?elA1NW1EczE5bDhxSGhNNEZLWkhYZEtQUFNQY2xVZm9TNzU4MmgzLytnSzBx?=
 =?utf-8?Q?uSiXLYRE?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 756d4947-5918-4f7c-a1f4-08db5e001c0e
X-MS-Exchange-CrossTenant-AuthSource: CH3PR10MB6810.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2023 15:44:36.9931
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f3wRVk2Go8Y0AexnqLjMTptBIutSK5hvQI1BHG9DlATsF4u7RYCjr3klLcUI88O5/jFlj1TrY9pwEew7tZfkow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4318
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-05-26_06,2023-05-25_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 mlxscore=0
 mlxlogscore=999 bulkscore=0 malwarescore=0 suspectscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2305260133
X-Proofpoint-ORIG-GUID: Zsl-_67mWvgPN0Y5uIizsHr5hVpqVOjU
X-Proofpoint-GUID: Zsl-_67mWvgPN0Y5uIizsHr5hVpqVOjU
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/25/23 15:31, Matthew Wilcox wrote:
> On Thu, May 25, 2023 at 09:45:34PM +0100, Matthew Wilcox wrote:
>>>> Isn't "long term pinning" the wrong description of the problem?  Long term
>>>> pins suggest to me FOLL_LONGTERM.  I think this is simple short term
>>>> pins that we care about here.
>>>
>>> vfio pins are held for a long time - Steve
>>
>> So this is a third sense of "pinned pages" that is neither what
>> filesystems nor the mm means by pinned pages, but whatever it is that
>> vfio means by pinned pages?  If only "pin" weren't such a desirable
>> word.  Can somebody explain to me in small words what a vfio pin looks
>> like because I've tried reading vfio_iommu_type1_pin_pages() and I
>> don't recognise anything there that looks like pinning in either of
>> the other two senses.
> 
> Oh, I think I found it!  pin_user_pages_remote() is called by
> vaddr_get_pfns().  If these are the pages you're concerned about,
> then the efficient way to do what you want is simply to call
> folio_maybe_dma_pinned().  Far more efficient than the current mess
> of total_mapcount().

vfio pinned pages triggered this change. Wouldn't checking refcounts against mapcount provide a more generalized way of 
detecting non-migratable pages?

Thanks,
Khalid