Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2684360rwd; Fri, 26 May 2023 09:41:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4a4s5POHNRB0HHAxfNAzG2z+kelhi+dKVxnH5zXlSO/B8ahKK7DU2Jx1WSamXC0pxnfUO1 X-Received: by 2002:a05:6a20:3955:b0:10b:2ba5:ca66 with SMTP id r21-20020a056a20395500b0010b2ba5ca66mr3420277pzg.20.1685119299063; Fri, 26 May 2023 09:41:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685119299; cv=none; d=google.com; s=arc-20160816; b=GzHPfzgy2L21p1xKxG/G7Mrt5o4U4nuof+IhiQ2SmJ9VtraI5eCN7MfJCRu19oZA46 8mwXihXUvdPcs2BdO/S700NBVv4sjZBOo/D43n2sXX1vfplJiFUoAloiOxDXVbRVQMrb 3gvMxOv212AquA+KiYG0h1gba3NARj8Vk+qBAE4dLicO7A52hhwQSXjIiZVkTu0NBagQ YlppBAeoiv5Nf328TWioQeSz0h7DT0dr1qb27UHlWTMgfED8ZTUTxewgECImQpuBfz3B DWRyEVVw52DvfCyAYF2StsDbWc2sGnrnDJ5On9aeeE//3Cu7EUONFHeSj91H+SmbiPHa g7Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mX5+bjBBZlaoKw7taDUef0eZ0B/7aaJbLLfQ646in4U=; b=kajTdZvWUx0RVTiMfhFkQn0mQfjcEpp0lqh+By2lScttR9oeepHMBBbPj++ZXPbF/R gc77fZTe/l1Wfz379OsChuCzKEt2tv44LRph/vsvxOVZisXIgc6z0+qOFdIKl/Si0f6t UIG3MNQ2Zb8ULP2zW9ccDMbuCcstiAtyz5BfYJS4v95c/8aCoty+YbrAcRu+uz39jYDs FOHaHmRyyGfts4ojHFSNywiHsC6KtcfJUhmcZUXZ8L1UUWt6PqmmwnmOtKz1tLHdUXfk GmtR1pwQYJg3vJ2zZjFRBKP7Sz0lwNIj14/mbwTVTXGN+4ChPcfBKsn3dvK1FX31+xyb HXCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=dEjqUnr4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z19-20020a63e113000000b004dacaa17ecbsi3898352pgh.559.2023.05.26.09.41.24; Fri, 26 May 2023 09:41:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=dEjqUnr4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229502AbjEZQVR (ORCPT + 99 others); Fri, 26 May 2023 12:21:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229833AbjEZQVP (ORCPT ); Fri, 26 May 2023 12:21:15 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D006CD9 for ; Fri, 26 May 2023 09:21:13 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-64d24136663so850590b3a.0 for ; Fri, 26 May 2023 09:21:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1685118073; x=1687710073; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mX5+bjBBZlaoKw7taDUef0eZ0B/7aaJbLLfQ646in4U=; b=dEjqUnr4j4gcR0Vx5ZawmCnVcL1lGxH3zJtPCZiuDv+vUCTSZi4+fTGf+Snya2As5j E1B9A3kXDH5vKZDyHZkz2ycBza3FewyuJM9IfbCvHg8mGReom4T4ydBUpT68aAHMB+36 5JwVjDBMWVZQbIi5QwdVaSBHTffYQeIQmaOrM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685118073; x=1687710073; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mX5+bjBBZlaoKw7taDUef0eZ0B/7aaJbLLfQ646in4U=; b=My+3co9SxJj84rty6r1PRtryGELx5D6hMHB+IhVAxBrvHbGZ8wRpcXRdovp1iJalWb uXf3KdR/82txWD7YMODKR7x2tiQtoJTR8VuqVsk6eLZtT8z48djahrpsawMKprr0HgMy ugu1RQGaBlBfFgYVLDyEJUaGk5/ahO6Ofwde3u0wReHyK+b7ArwZCzeSsvdmBkdG2N7s XOmrrntz7FjY4S27goZDV/MszQpPUPh9BGuVIH4d4wfoQOsxJ5C0hvCvSdMmxk+f4ThE 3PebFxVcZYJYrZ6n/AVuwj9657ckiB6FH9fQ9rx3u142q5vj63glMTqf5XZoZzUryk8p 5DOQ== X-Gm-Message-State: AC+VfDwnBpxzw0rQWRtBWTSas88VSJR+cUX1lGUYdqATk7AB7NvsMrMl NN405CfoyuQmdSMCL+HETRE3BA== X-Received: by 2002:a05:6a20:9146:b0:10c:9773:5e6 with SMTP id x6-20020a056a20914600b0010c977305e6mr3121676pzc.47.1685118072839; Fri, 26 May 2023 09:21:12 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id k17-20020aa78211000000b0064d4d11b8bfsm2916467pfi.59.2023.05.26.09.21.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 May 2023 09:21:12 -0700 (PDT) Date: Fri, 26 May 2023 09:21:11 -0700 From: Kees Cook To: Maninder Singh Cc: cai@lca.pw, mcgrof@kernel.org, thunder.leizhen@huawei.com, vincenzopalazzodev@gmail.com, wedsonaf@google.com, pmladek@suse.com, ojeda@kernel.org, peterz@infradead.org, alan.maguire@oracle.com, stephen.s.brennan@oracle.com, samitolvanen@google.com, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, v.narang@samsung.com Subject: Re: [PATCH 1/1] kallsyms: remove unsed API lookup_symbol_attrs Message-ID: <202305260920.BE175FAD@keescook> References: <20230526072123.807160-1-maninder1.s@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230526072123.807160-1-maninder1.s@samsung.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 26, 2023 at 12:51:23PM +0530, Maninder Singh wrote: > with commit '7878c231dae0 ("slab: remove /proc/slab_allocators")' > lookup_symbol_attrs usage is removed. > > Thus removing redundant API. > > Signed-off-by: Maninder Singh Yeah, looks like this is unused now. Reviewed-by: Kees Cook -- Kees Cook