Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230526150806.1457828-1-VEfanov@ispras.ru> <27614af23cd7ae4433b909194062c553a6ae16ac.camel@redhat.com>
 <027d28a0-b31b-ab42-9eb6-2826c04c9364@ispras.ru> <CANn89iLGOVwW-KHBuJ94E+QoVARWw5EBKyfh0mPkOT+5ws31Fw@mail.gmail.com>
 <d3fccbd0-c92e-9aff-8c32-48c1171746c3@ispras.ru>
In-Reply-To: <d3fccbd0-c92e-9aff-8c32-48c1171746c3@ispras.ru>
From:   Eric Dumazet <edumazet@google.com>
Date:   Fri, 26 May 2023 18:47:36 +0200
Message-ID: <CANn89i+UYRXD16epov9x7+Zr5vCKL+DTCidsOaQdMBjWMmK8CA@mail.gmail.com>
Subject: Re: [PATCH] udp6: Fix race condition in udp6_sendmsg & connect
To:     Vlad Efanov <vefanov@ispras.ru>
Cc:     Paolo Abeni <pabeni@redhat.com>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        David Ahern <dsahern@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, May 26, 2023 at 6:41=E2=80=AFPM Vlad Efanov <vefanov@ispras.ru> wro=
te:
>
> sk_dst_set() is called by sk_setup_caps().
>
> sk_dst_set() replaces dst in socket using xchg() call and we still have
> two tasks use one socket but expect different dst in sk_dst_cache.
>
>
> __sk_dst_set() is rcu protected, but it checks for socket lock.
>
>
> static inline void
> __sk_dst_set(struct sock *sk, struct dst_entry *dst)
> {
>      struct dst_entry *old_dst;
>
>      sk_tx_queue_clear(sk);
>      sk->sk_dst_pending_confirm =3D 0;
>      old_dst =3D rcu_dereference_protected(sk->sk_dst_cache,
>                          lockdep_sock_is_held(sk));
>      rcu_assign_pointer(sk->sk_dst_cache, dst);
>      dst_release(old_dst);
> }

I am quite familiar with this code.

What are you trying to say exactly ?

Please come with a V2 without grabbing the socket lock.