Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2853093rwd; Fri, 26 May 2023 12:14:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ54Ym2zPTqj4caoapAXE3nIQpZPMH/8x/LQzqynyrbze6Up9HDIV/sajLXU8NB6QbTMvKMa X-Received: by 2002:a05:6a00:895:b0:647:2ce5:57c4 with SMTP id q21-20020a056a00089500b006472ce557c4mr5324962pfj.5.1685128496501; Fri, 26 May 2023 12:14:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685128496; cv=none; d=google.com; s=arc-20160816; b=v0AxpUMoBVTqi+6RzU8f1BTLOLj+6EsKW+hN/43YJvLr5n+umxyTR3m17/+Nh6a7Pc j948Aqe/u1Y0MGsQarzgMhODxPb3czdIxLUcB7u69ql0TVRE/mfq3Bmm+bpr6RXny58t omv+yu/CZ47BPT0lq6fzdSsEr/zGnux+6+sQ7jH/FOP2YMxJp+lzpOOsDZuU+0ujGs9g jv7EOb6waejqATQsprPbQYCZdsO/5CP04rBgPpRxSFEFkoNLiPzaT7HXbcsVebyyQk61 7LgUe9UkIdg64+dUkLPhOV+PDOsCbFVEsF3/OdNNn29wO0pgL9UZlYdWbogEfm4wnU3/ hBoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=0SAeQ2xMzsERoeM9PeVs0BB2mFGDfR2b9upLxc7DKkI=; b=lvu7xHLcFW9IxXgnIU/n19Haw56KsGQ4xJce8IVLfR7sfB8Ll5z7tIyl+x1NKgtIXh E3NjX9hgNRvOo7DWtYiSNnCEe07ugpz4pDCwECoCwo/R8Txqq5C1WtKxqSCdfx78C7bo VDd2jYLFxYFLlC9zwM35f1IiRWlPUThpp9GVSzh9Db8y1TWrLJrYBnmhzziRm5/BblBY Camg2t3m9gVClUY1a+Wfj2uIMb0aH0Chd7oURHJ035uuTDRctEGUHGG4+VzXkhbbiqIX wxoeyGbC3L3QATnN89lgRlNNW1PiXyBIpOxRA8fya62v3DFlyoBrqIAFR4tmWL46BQdv osnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AVVFpfyu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s187-20020a625ec4000000b0064ebd286b56si1203402pfb.224.2023.05.26.12.14.42; Fri, 26 May 2023 12:14:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AVVFpfyu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243271AbjEZTFG (ORCPT + 99 others); Fri, 26 May 2023 15:05:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229732AbjEZTFF (ORCPT ); Fri, 26 May 2023 15:05:05 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4E5513D for ; Fri, 26 May 2023 12:05:02 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-64d1e96c082so1027130b3a.1 for ; Fri, 26 May 2023 12:05:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1685127902; x=1687719902; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0SAeQ2xMzsERoeM9PeVs0BB2mFGDfR2b9upLxc7DKkI=; b=AVVFpfyumrAcUAFk2l9Ratbv9bsaw11PAYDGo6T3IZvy3cYQrAwoQT01W1qnrApGOK oABFsf7K+o87TdmzTYPQgTYedlOWmW3p2s+2H+2XuKTFD9MUK0v6UxwH/z7PcuqMjNeO Mi+g8XRtj05iJjOqgqN+fHct+fTVCbzw17Bso= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685127902; x=1687719902; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0SAeQ2xMzsERoeM9PeVs0BB2mFGDfR2b9upLxc7DKkI=; b=XXAgfC3Fcnotx8L3oVkciAFMf1YPccczX9zTmnkGHLlFXD4FEcouT7LCbkVzUJSsNV 8Z/AZjQ05DStS/KxLclFiF36RdoGMSnl2bm6S+08J6iP33ZuBaRx7vDNsxvFAluReElO Yv918/Q7NHQzR9FMxQxsu8VOGMlgjutvv4iUEMK5PbQzfd/FpJRErWVDmghZ9bD9hZHn W5BAx81JiKM5ZYDx7dcf/Ug5E0oH5TLqQSRLrWTwZBEsrtI0nU3p8CXTiTGQfsaBUMPv U4ZrwJXJtPTcfXYgsQJJMDOAqLHSHirNf3evf2XXelU//eVf8mJrFQejkF6NhelqDAe1 jd+Q== X-Gm-Message-State: AC+VfDxoVhQ2yHJmCOqWIhf+m8GutaBT7EK76udGx90MgO7xQhjdkgcM 1GY+g3Z6mxx0FFO3SAXZUtsebG2HFB6ByTw9zZ5ReA== X-Received: by 2002:a05:6a20:938e:b0:104:d82a:63c5 with SMTP id x14-20020a056a20938e00b00104d82a63c5mr302697pzh.53.1685127902268; Fri, 26 May 2023 12:05:02 -0700 (PDT) MIME-Version: 1.0 References: <20230517150321.2890206-1-revest@chromium.org> <20230517150321.2890206-4-revest@chromium.org> <884d131bbc28ebfa0b729176e6415269@ispras.ru> <3c2e210b75bd56909322e8a3e5086d91@ispras.ru> <7c572622c0d8e283fc880fe3f4ffac27@ispras.ru> In-Reply-To: From: Florent Revest Date: Fri, 26 May 2023 21:04:51 +0200 Message-ID: Subject: Re: [PATCH v2 3/5] mm: Make PR_MDWE_REFUSE_EXEC_GAIN an unsigned long To: David Hildenbrand Cc: Alexey Izbyshev , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, catalin.marinas@arm.com, anshuman.khandual@arm.com, joey.gouly@arm.com, mhocko@suse.com, keescook@chromium.org, peterx@redhat.com, broonie@kernel.org, szabolcs.nagy@arm.com, kpsingh@kernel.org, gthelen@google.com, toiwoton@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 23, 2023 at 4:10=E2=80=AFPM David Hildenbrand wrote: > > >> I'm easily confused by such (va_args) things, so sorry for the dummy > >> questions. > > > > This stuff *is* confusing, and note that Linux man pages don't even tel= l > > that prctl() is actually declared as a variadic function (and for > > ptrace() this is mentioned only in the notes, but not in its signature)= . > > Agreed, that's easy to miss (and probably many people missed it). > > > Anyhow, for this patch as is (although it feels like drops in the ocean > after our discussion) > > Reviewed-by: David Hildenbrand Thanks everyone for the review and the exchange ! :)