Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8412fb0f-4b7c-b305-0947-ae68701bad20@alu.unizg.hr>
Date:   Fri, 26 May 2023 21:21:03 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [RESEND PATCH v5 2/3] test_firmware: fix a memory leak with reqs
 buffer
To:     Luis Chamberlain <mcgrof@kernel.org>,
        Dan Carpenter <dan.carpenter@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org,
        Russ Weight <russell.h.weight@intel.com>,
        Tianfei Zhang <tianfei.zhang@intel.com>,
        Shuah Khan <shuah@kernel.org>,
        Colin Ian King <colin.i.king@gmail.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        linux-kselftest@vger.kernel.org, stable@vger.kernel.org,
        Dan Carpenter <error27@gmail.com>, Takashi Iwai <tiwai@suse.de>
References: <20230509084746.48259-1-mirsad.todorovac@alu.unizg.hr>
 <20230509084746.48259-2-mirsad.todorovac@alu.unizg.hr>
 <256bc822-ba20-c41a-1f3b-5b6aacead32e@alu.unizg.hr>
 <f9212fd0-0a52-4076-a97a-c5af8de194cf@kili.mountain>
 <72257758-a0e6-1118-f397-431ac9ec3059@alu.unizg.hr>
 <828b1d4c-dac8-4a64-9f1d-452762dc07bd@kili.mountain>
 <ZG2h34KzhQWONNec@bombadil.infradead.org>
Content-Language: en-US
From:   Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
In-Reply-To: <ZG2h34KzhQWONNec@bombadil.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/24/23 07:34, Luis Chamberlain wrote:
> On Thu, May 18, 2023 at 06:20:37PM +0300, Dan Carpenter wrote:
>> On Fri, May 12, 2023 at 08:58:58PM +0200, Mirsad Goran Todorovac wrote:
>>> On 12. 05. 2023. 15:09, Dan Carpenter wrote:
>>>> On Fri, May 12, 2023 at 02:34:29PM +0200, Mirsad Todorovac wrote:
>>>>>> @@ -1011,6 +1016,11 @@ ssize_t trigger_batched_requests_async_store(struct device *dev,
>>>>>>     	mutex_lock(&test_fw_mutex);
>>>>>> +	if (test_fw_config->reqs) {
>>>>>> +		rc = -EBUSY;
>>>>>> +		goto out_bail;
>>>>>> +	}
>>>>>> +
>>>>>>     	test_fw_config->reqs =
>>>>>>     		vzalloc(array3_size(sizeof(struct test_batched_req),
>>>>>>     				    test_fw_config->num_requests, 2));
>>>>>
>>>>> I was just thinking, since returning -EBUSY for the case of already allocated
>>>>> test_fw_config->reqs was your suggestion and your idea, maybe it would be OK
>>>>> to properly reflect that in Co-developed-by: or Signed-off-by: , but if I
>>>>> understood well, the CoC requires that I am explicitly approved of those?
>>>>>
>>>>
>>>> If everyone else is okay, let's just apply this as-is.  You did all the
>>>> hard bits.
>>>>
>>>> regards,
>>>> dan carpenter
>>>
>>> If it is OK with you, then I hope I have your Reviewed-by:
>>>
>>
>> Wow.  Sorry for all the delay on this.
>>
>> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
>>
> 
> Thanks for doing this work! It looks much better now split up!

No problem. It's a great exercise for the little grey cells :-)

> For all 3 patches:
> 
> Acked-by: Luis Chamberlain <mcgrof@kernel.org>

Thanks,
Mirsad

> Greg, can you pick these up?
> 
>    Luis